Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Overlapping parts #11

Closed
Dexus opened this issue Dec 23, 2024 · 8 comments · Fixed by #53
Closed

🐛 Overlapping parts #11

Dexus opened this issue Dec 23, 2024 · 8 comments · Fixed by #53
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Dexus
Copy link
Member

Dexus commented Dec 23, 2024

https://github.com/deepnest-io/Deepnest/issues/145

Screenshot_2024-12-23_09-58-51
bug-test-overlap.zip

@Dexus Dexus added the bug Something isn't working label Dec 23, 2024
@Dexus Dexus self-assigned this Dec 23, 2024
@Dexus
Copy link
Member Author

Dexus commented Jan 31, 2025

@ClockworkBastard is it possible that this only happends when the "Use rough approximation" is enabled?

I did run 30.000.000 tests now and I was now able to get one result that would overlap with the option disabled.

@KoreUrala
Copy link

Hi! I just found this project out of having this exact issue!
Deepnest is a life saver for my sewing projects because it allows me to accommodate a myriad of different patterns in a single sheet, so first of all, thanks for your efforts!
Secondly, i'm having overlapping parts without the rough approximation feature :(

Image

this happened while trying to fit five of these bad boys

Image

in laser cut table (130cm * 90cm) dimensions.
I was using everything on default save for:
Part rotations - 2
Optimization type - Bounding box
Optimization ratio - 0.01
GA population - 256
GA mutation rate - 16

Using Windows 11 Pro running in an AMD Ryzen7 2700X along with a NVIDIA GeForce RTX 3060 with 16GB RAM
Dunno if the pc specs are relevant though...

@Dexus
Copy link
Member Author

Dexus commented Feb 23, 2025

@KoreUrala Thank you. Can you share the settings completely? Is the SVG Preprocessor acativated?

Do you have maybe the result file for me?

@KoreUrala
Copy link

KoreUrala commented Feb 23, 2025

SVG Prewhat...? Uhhh... idunno, it's probably on default...

Here, have a ss of the settings
Image
Also this
Image
Lemme run it again...
-time skip-

Image
It infuriates me to no end...

@Dexus
Copy link
Member Author

Dexus commented Feb 23, 2025

Thank you, could you please check if the behaviour is still the same when you enable "Use SVG Normalizer" in the settings?

I'll check this next week and create logs. I am expecting to get the same results. Thanks for providing the source file that is causing the problem. This should make it much easier.

@KoreUrala
Copy link

Yeah, still happens with normalizer, I also noticed it behaves slightly better in inches than in millimeters... very slightly...

@Dexus
Copy link
Member Author

Dexus commented Feb 25, 2025

Thank you for letting me know that. Hope that I can find the "bad" part now,

@Dexus
Copy link
Member Author

Dexus commented Feb 27, 2025

Thank you @KoreUrala! I have now been successful in recreating the behaviour and am currently finalising the fix. Will be released with v1.4.1 v1.5.0. I'm running some tests now, and if there are no more overlaps, it will be released tonight or tomorrow during the day.

Dexus added a commit that referenced this issue Feb 27, 2025
Dexus added a commit that referenced this issue Feb 27, 2025
Dexus added a commit that referenced this issue Feb 27, 2025
@Dexus Dexus linked a pull request Feb 27, 2025 that will close this issue
@Dexus Dexus added this to the v1.5.0 milestone Feb 27, 2025
@Dexus Dexus closed this as completed in #53 Feb 28, 2025
Dexus added a commit that referenced this issue Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants