From 90149204bd08c07eb672cd5b19d782fed3d96ddc Mon Sep 17 00:00:00 2001 From: David Spickett Date: Thu, 10 Oct 2024 14:26:46 +0100 Subject: [PATCH] [ci] Don't add check-all target when pstl project is enabled (#111803) Fixes #110265 Adding check-all causes us to run some tests twice if a project specific target like check-clang is also added. check-pstl is an alternative but as far as I can tell, check-all does not include this so we have not been running the tests in CI anyway. When I tried to run check-pstl locally I got a lot of compiler errors but have not found any instructions on how to setup a correct build environment. Even if such instructions exist, it's probably more than we want to do in CI. According to Louis Dionne, the project is probably not active. So if it's ever revived it'll be up to the new contributors to enable testing. --- .ci/generate-buildkite-pipeline-premerge | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.ci/generate-buildkite-pipeline-premerge b/.ci/generate-buildkite-pipeline-premerge index 53a43070bf1ca..7676ff716c418 100755 --- a/.ci/generate-buildkite-pipeline-premerge +++ b/.ci/generate-buildkite-pipeline-premerge @@ -191,6 +191,9 @@ function keep-modified-projects() { } function check-targets() { + # Do not use "check-all" here because if there is "check-all" plus a + # project specific target like "check-clang", that project's tests + # will be run twice. projects=${@} for project in ${projects}; do case ${project} in @@ -216,7 +219,7 @@ function check-targets() { echo "check-lldb" ;; pstl) - echo "check-all" + # Currently we do not run pstl tests in CI. ;; libclc) # Currently there is no testing for libclc.