chore: bump Rust and cargo update (#735)

We bump Rust to 1.78, but for the tests to pass we need to remove the UB
that we've been relying on:

1. Opaque pointers no longer rely on values on the stack (!)
2. We no longer take a `&mut` from a u64 that comes from a `&` (UB)
3. ToV8Buffer gets a RefCell for proper interior mutability

Lots of sketchiness left in serde_v8 but hopefully this fixes the major
fire.

serde_v8 is considered deprecated so we're likely not going to touch
this code much more than this band-aid.

Author: mmastrac

Cargo.lock

@@ -529,7 +529,7 @@ mod internal {
           ..
         } => {
           if !waker.will_wake(new_waker) {
-            *waker = new_waker.clone();
+            waker.clone_from(new_waker);
           }
           Ok(())
         }

core/async_cancel.rs

@@ -25,7 +25,7 @@ impl GothamState {
   /// Determines if the current value exists in `GothamState` storage.
   pub fn has<T: 'static>(&self) -> bool {
     let type_id = TypeId::of::<T>();
-    self.data.get(&type_id).is_some()
+    self.data.contains_key(&type_id)
   }
 
   /// Tries to borrow a value from the `GothamState` storage.

core/gotham_state.rs

@@ -167,7 +167,7 @@ impl MutableSleep {
         // Already have this waker
         let waker = cx.waker();
         if !external.will_wake(waker) {
-          *external = waker.clone();
+          external.clone_from(waker);
         }
         Poll::Pending
       } else {

core/web_timeout.rs

@@ -1,3 +1,3 @@
 [toolchain]
-channel = "1.77.2"
+channel = "1.78.0"
 components = ["rustfmt", "clippy"]

rust-toolchain.toml

@@ -23,7 +23,7 @@ impl_magic!(AnyValue);
 
 impl ToV8 for AnyValue {
   fn to_v8<'a>(
-    &mut self,
+    &self,
     scope: &mut v8::HandleScope<'a>,
   ) -> Result<v8::Local<'a, v8::Value>, crate::Error> {
     match self {

serde_v8/magic/any_value.rs

@@ -31,7 +31,7 @@ impl DerefMut for BigInt {
 
 impl ToV8 for BigInt {
   fn to_v8<'a>(
-    &mut self,
+    &self,
     scope: &mut v8::HandleScope<'a>,
   ) -> Result<v8::Local<'a, v8::Value>, crate::Error> {
     let (sign, words) = self.0.to_u64_digits();

serde_v8/magic/bigint.rs

@@ -1,5 +1,6 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
 
+use std::cell::RefCell;
 use std::fmt::Debug;
 use std::ops::Deref;
 use std::ops::DerefMut;
@@ -79,19 +80,19 @@ impl From<V8Slice<u8>> for JsBuffer {
 // NOTE(bartlomieju): we use Option here, because `to_v8()` uses `&mut self`
 // instead of `self` which is dictated by the `serde` API.
 #[derive(Debug)]
-pub struct ToJsBuffer(Option<Box<[u8]>>);
+pub struct ToJsBuffer(RefCell<Option<Box<[u8]>>>);
 
 impl_magic!(ToJsBuffer);
 
 impl ToJsBuffer {
   pub fn empty() -> Self {
-    ToJsBuffer(Some(vec![0_u8; 0].into_boxed_slice()))
+    ToJsBuffer(Some(vec![0_u8; 0].into_boxed_slice()).into())
   }
 }
 
 impl From<Box<[u8]>> for ToJsBuffer {
   fn from(buf: Box<[u8]>) -> Self {
-    ToJsBuffer(Some(buf))
+    ToJsBuffer(Some(buf).into())
   }
 }
 
@@ -103,10 +104,11 @@ impl From<Vec<u8>> for ToJsBuffer {
 
 impl ToV8 for ToJsBuffer {
   fn to_v8<'a>(
-    &mut self,
+    &self,
     scope: &mut v8::HandleScope<'a>,
   ) -> Result<v8::Local<'a, v8::Value>, crate::Error> {
-    let buf: Box<[u8]> = self.0.take().expect("RustToV8Buf was empty");
+    let buf: Box<[u8]> =
+      self.0.borrow_mut().take().expect("RustToV8Buf was empty");
 
     if buf.is_empty() {
       let ab = v8::ArrayBuffer::new(scope, 0);

serde_v8/magic/buffer.rs

@@ -52,7 +52,7 @@ const _: () =
 
 impl ToV8 for ByteString {
   fn to_v8<'a>(
-    &mut self,
+    &self,
     scope: &mut v8::HandleScope<'a>,
   ) -> Result<v8::Local<'a, v8::Value>, crate::Error> {
     let v =

serde_v8/magic/bytestring.rs

@@ -41,7 +41,7 @@ impl DerefMut for DetachedBuffer {
 
 impl ToV8 for DetachedBuffer {
   fn to_v8<'a>(
-    &mut self,
+    &self,
     scope: &mut v8::HandleScope<'a>,
   ) -> Result<v8::Local<'a, v8::Value>, crate::Error> {
     let buffer = v8::ArrayBuffer::with_backing_store(scope, &self.0.store);