Skip to content

Conversation

@kt3k
Copy link
Member

@kt3k kt3k commented Nov 27, 2025

We test the perf of isGlob since #6764

This case seems flaky recently. This PR relaxes the timeout to avoid the flake. (The previous implementation was extremely slow. I think this new timeout still confirms the fix of #6764 )

@kt3k kt3k requested a review from bartlomieju November 27, 2025 02:37
@github-actions github-actions bot added the path label Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.10%. Comparing base (7e8c8d2) to head (5471bfb).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6883      +/-   ##
==========================================
- Coverage   94.11%   94.10%   -0.01%     
==========================================
  Files         581      581              
  Lines       42704    42704              
  Branches     6793     6793              
==========================================
- Hits        40190    40186       -4     
- Misses       2463     2466       +3     
- Partials       51       52       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k kt3k merged commit 9b2c51d into denoland:main Nov 28, 2025
19 checks passed
@kt3k kt3k deleted the test-path-glob-relax-timeout branch November 28, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants