Magento 2 Recipe does not detect needed upgrade in all cases

[carlos-reynosa]

The magento 2 recipe only decides that an upgrade is needed if the db status is dirty. But there are other cases when an upgrade is needed. For example adding new services like message queues. It looks like this is a general known issue given the magento ticket magento/magento2#38225

deployer/recipe/magento2.php

Lines 132 to 145 in 30742fc

	set('database_upgrade_needed', function () {
	// detect if setup:upgrade is needed
	try {
	run('{{bin/php}} {{bin/magento}} setup:db:status');
	} catch (RunException $e) {
	if ($e->getExitCode() == DB_UPDATE_NEEDED_EXIT_CODE) {
	return true;
	}
	throw $e;
	}
	return false;
	});

[carlos-reynosa]

On top of that, when you deploy there are cases when you want and need to do a full upgrade. Currently the recipe only does a db data upgrade.

[carlos-reynosa]

I crated a pull request that will provide for easier maintenance now or in the future for this issue here: #4127

[carlos-reynosa]

The pull request was merged and will provide an easier way to add custom checks and officially provided checks to decide when a full upgrade should be run.

[antonmedv]

I will release a new beta.