fix #42 clash when potential first names are suffixes

Author: derek73

docs/release_log.rst

@@ -1,5 +1,8 @@
 Release Log
 ===========
+* 0.3.12 - October 17, 2015
+    - Fix first name clash with suffixes (#42)
+    - Fix encoding of constants added via the python shell
 * 0.3.11 - October 17, 2015
     - Fix bug capitalization exceptions (#39)
 * 0.3.10 - September 19, 2015

nameparser/__init__.py

@@ -1,4 +1,4 @@
-VERSION = (0, 3, 11)
+VERSION = (0, 3, 12)
 __version__ = '.'.join(map(str, VERSION))
 __author__ = "Derek Gulbranson"
 __author_email__ = '[email protected]'

nameparser/parser.py

@@ -439,10 +439,14 @@ def parse_full_name(self):
 
                 self.middle_list.append(piece)
         else:
-            if self.are_suffixes(parts[1].split(' ')):
+            # if all the end parts are suffixes and there is more than one piece in
+            # the first part. (Suffixes will never appear after last names only, and
+            # allows potential first names to be in suffixes, e.g. "Johnson, Bart"
+            if self.are_suffixes(parts[1].split(' ')) and len(parts[0].split(' ')) > 1:
 
                 # suffix comma: title first middle last [suffix], suffix [suffix] [, suffix]
                 #               parts[0],                         parts[1:...]
+               
 
                 self.suffix_list += parts[1:]
                 pieces = self.parse_pieces(parts[0].split(' '))

tests.py

@@ -1444,6 +1444,18 @@ def test_potential_suffix_that_is_also_last_name_comma(self):
         self.m(hn.first, "Jack", hn)
         self.m(hn.last, "Ma", hn)
 
+    def test_potential_suffix_that_is_also_first_name_comma(self):
+        hn = HumanName("Johnson, Bart")
+        self.m(hn.first, "Bart", hn)
+        self.m(hn.last, "Johnson", hn)
+    
+    # TODO: handle conjunctions in last names followed by first names clashing with suffixes
+    @unittest.expectedFailure
+    def test_potential_suffix_that_is_also_first_name_comma_with_conjunction(self):
+        hn = HumanName("De la Vina, Bart")
+        self.m(hn.first, "Bart", hn)
+        self.m(hn.last, "De la Vina", hn)
+    
     def test_potential_suffix_that_is_also_last_name_with_suffix(self):
         hn = HumanName("Jack Ma Jr")
         self.m(hn.first, "Jack", hn)