Skip to content

Commit c4b9792

Browse files
address comment
1 parent 2eb8118 commit c4b9792

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

src/spec-configuration/containerFeaturesConfiguration.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -532,6 +532,7 @@ export function getBackwardCompatibleFeatureId(output: Log, id: string) {
532532
deprecatedFeaturesIntoOptions.set('maven', 'java');
533533
deprecatedFeaturesIntoOptions.set('jupyterlab', 'python');
534534

535+
// TODO: add warning logs once we have context on the new location for these Features.
535536
// const deprecatedFeatures = ['fish', 'homebrew'];
536537

537538
const newFeaturePath = 'ghcr.io/devcontainers/features';
@@ -540,18 +541,18 @@ export function getBackwardCompatibleFeatureId(output: Log, id: string) {
540541

541542
// Mapping feature references (old shorthand syntax) from "microsoft/vscode-dev-containers" to "ghcr.io/devcontainers/features"
542543
if (migratedfeatures.includes(id)) {
543-
output.write(`(!) WARNING: Using the deprecated '${id}' Feature. See https://github.com/devcontainers/features/tree/main/src/${id}#example-usage for updated specification.`, LogLevel.Warning);
544+
output.write(`(!) WARNING: Using the deprecated '${id}' Feature. See https://github.com/devcontainers/features/tree/main/src/${id}#example-usage for the updated Feature.`, LogLevel.Warning);
544545
return `${newFeaturePath}/${id}:${versionBackwardComp}`;
545546
}
546547

547548
// Mapping feature references (renamed old shorthand syntax) from "microsoft/vscode-dev-containers" to "ghcr.io/devcontainers/features"
548549
if (renamedFeatures.get(id) !== undefined) {
549-
output.write(`(!) WARNING: Using the deprecated '${id}' Feature. See https://github.com/devcontainers/features/tree/main/src/${renamedFeatures.get(id)}#example-usage for updated specification.`, LogLevel.Warning);
550+
output.write(`(!) WARNING: Using the deprecated '${id}' Feature. See https://github.com/devcontainers/features/tree/main/src/${renamedFeatures.get(id)}#example-usage for the updated Feature.`, LogLevel.Warning);
550551
return `${newFeaturePath}/${renamedFeatures.get(id)}:${versionBackwardComp}`;
551552
}
552553

553554
if (deprecatedFeaturesIntoOptions.get(id) !== undefined) {
554-
output.write(`(!) WARNING: Falling back to the deprecated '${id}' Feature. It is now part of the '${deprecatedFeaturesIntoOptions.get(id)}' Feature. See https://github.com/devcontainers/features/tree/main/src/${deprecatedFeaturesIntoOptions.get(id)}#options for updated specification.`, LogLevel.Warning);
555+
output.write(`(!) WARNING: Falling back to the deprecated '${id}' Feature. It is now part of the '${deprecatedFeaturesIntoOptions.get(id)}' Feature. See https://github.com/devcontainers/features/tree/main/src/${deprecatedFeaturesIntoOptions.get(id)}#options for the updated Feature.`, LogLevel.Warning);
555556
}
556557

557558
// Deprecated and all other features references (eg. fish, ghcr.io/devcontainers/features/go, ghcr.io/owner/repo/id etc)

0 commit comments

Comments
 (0)