Skip to content

OCI push #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Aug 12, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
fd25281
First commit
edgonmsft Jul 26, 2022
f585934
Merge remote-tracking branch 'origin/main' into oci
edgonmsft Jul 29, 2022
59f31aa
After testing changes
edgonmsft Aug 1, 2022
c300705
Fix
edgonmsft Aug 1, 2022
c9220c9
Obtain a ghcr.io token for pulling.
edgonmsft Aug 1, 2022
2d73709
PR comments.
edgonmsft Aug 1, 2022
c6dcc0b
Simplify authentication
edgonmsft Aug 2, 2022
34ad4a5
Extra validation
edgonmsft Aug 2, 2022
76a3f78
generate tgz layer
joshspicer Aug 1, 2022
06d08aa
calculate content digest
joshspicer Aug 2, 2022
c6432d7
refactor auth to always pass the registry token, and accept digest in…
joshspicer Aug 2, 2022
2697aa6
uncomment tests
joshspicer Aug 2, 2022
9c7d8f3
service=${registry}
joshspicer Aug 2, 2022
58ec217
HEAD request to check existance of blobs
joshspicer Aug 2, 2022
ccff117
some codespace funniness
joshspicer Aug 2, 2022
118e5fd
fix codespace funniness
joshspicer Aug 2, 2022
66d75cf
split push into different file
joshspicer Aug 2, 2022
afa12f6
remove push for now (in oci-push branch)
joshspicer Aug 2, 2022
bfd43d7
revert new http
joshspicer Aug 2, 2022
5e1b1ca
add push work
joshspicer Aug 2, 2022
f5a72dd
merge conflicts i made for myself
joshspicer Aug 9, 2022
0f58dbe
sync tests
joshspicer Aug 9, 2022
fba508f
update test
joshspicer Aug 9, 2022
bc15caa
done and untested
joshspicer Aug 9, 2022
73bb093
it works
joshspicer Aug 9, 2022
d3a63f6
comment test code
joshspicer Aug 9, 2022
bfa5e77
Merge branch 'main' of https://github.com/devcontainers/cli into oci-…
joshspicer Aug 11, 2022
c26a212
comment
joshspicer Aug 11, 2022
c3cd1b0
package type
joshspicer Aug 11, 2022
03ed7b5
remove temporary code and registry detection
joshspicer Aug 11, 2022
88b8ea6
update test
joshspicer Aug 11, 2022
61de237
new test file to tabs
joshspicer Aug 11, 2022
b5874c6
update test names
joshspicer Aug 11, 2022
bc24f57
implement entrypoint for pushing devcontainer-collection.json
joshspicer Aug 11, 2022
7a499d0
remove test code
joshspicer Aug 11, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/spec-configuration/containerFeaturesConfiguration.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import { mkdirpLocal, readLocalFile, rmLocal, writeLocalFile, cpDirectoryLocal,
import { Log, LogLevel } from '../spec-utils/log';
import { request } from '../spec-utils/httpRequest';
import { computeFeatureInstallationOrder } from './containerFeaturesOrder';
import { fetchOCIFeature, getOCIFeatureSet, OCIFeatureRef, fetchOCIFeatureManifestIfExists, OCIManifest } from './containerFeaturesOCI';
import { fetchOCIFeature, getOCIFeatureSet, OCIFeatureRef, fetchOCIFeatureManifestIfExistsFromUserIdentifier, OCIManifest } from './containerFeaturesOCI';

// v1
const V1_ASSET_NAME = 'devcontainer-features.tgz';
Expand Down Expand Up @@ -505,7 +505,7 @@ export async function getFeatureIdType(output: Log, env: NodeJS.ProcessEnv, user
return { type: 'github-repo', manifest: undefined };
}

const manifest = await fetchOCIFeatureManifestIfExists(output, env, userFeatureId);
const manifest = await fetchOCIFeatureManifestIfExistsFromUserIdentifier(output, env, userFeatureId);
if (manifest) {
return { type: 'oci', manifest: manifest };
} else {
Expand Down Expand Up @@ -986,4 +986,3 @@ function getFeatureValueDefaults(feature: Feature) {
return defaults;
}, {} as Record<string, string | boolean | undefined>);
}

Loading