Skip to content

Commit 2817b44

Browse files
committed
Merge remote-tracking branch 'upstream/main'
# Conflicts: # test/common-utils/scenarios.json
2 parents 1ccb5eb + 72df8a5 commit 2817b44

45 files changed

Lines changed: 708 additions & 237 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/docker-in-docker-stress-test.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
run: npm install -g @devcontainers/cli
2020

2121
- name: "Generating tests for 'docker-in-docker' which validates if docker daemon is running"
22-
run: devcontainer features test --skip-scenarios -f docker-in-docker -i mcr.microsoft.com/devcontainers/base:ubuntu .
22+
run: devcontainer features test --skip-scenarios -f docker-in-docker -i mcr.microsoft.com/devcontainers/base:noble .
2323

2424
test-onCreate:
2525
strategy:
@@ -34,4 +34,4 @@ jobs:
3434
run: npm install -g @devcontainers/cli
3535

3636
- name: "Generating tests for 'docker-in-docker' which validates if docker daemon is available within 'onCreateCommand'"
37-
run: devcontainer features test -f docker-in-docker --skip-autogenerated --filter "docker_with_on_create_command"
37+
run: devcontainer features test -f docker-in-docker --skip-autogenerated --filter "docker_with_on_create_command" -i mcr.microsoft.com/devcontainers/base:noble

.github/workflows/test-pr-arm64.yaml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ on:
88
paths:
99
- "src/powershell/**"
1010
- "test/powershell/**"
11+
- "src/docker-in-docker/**"
12+
- "test/docker-in-docker/**"
1113

1214
jobs:
1315
detect-changes:
@@ -23,6 +25,7 @@ jobs:
2325
# <feature-name>: ./**/<feature-name>/**
2426
filters: |
2527
powershell: ./**/powershell/**
28+
docker-in-docker: ./**/docker-in-docker/**
2629
2730
test:
2831
needs: [detect-changes]
@@ -42,9 +45,17 @@ jobs:
4245
"mcr.microsoft.com/devcontainers/base:debian",
4346
"mcr.microsoft.com/devcontainers/base:noble"
4447
]
48+
exclude:
49+
- features: docker-in-docker
50+
baseImage: mcr.microsoft.com/devcontainers/base:debian
51+
- features: docker-in-docker
52+
baseImage: mcr.microsoft.com/devcontainers/base:ubuntu
4553
steps:
4654
- uses: actions/checkout@v6
4755

56+
- name: "Load erofs module and verify"
57+
run: sudo modprobe erofs && grep erofs /proc/filesystems
58+
4859
- name: "Install latest devcontainer CLI"
4960
run: npm install -g @devcontainers/cli
5061

.github/workflows/test-pr.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,11 @@ jobs:
6565
- features: docker-in-docker
6666
baseImage: mcr.microsoft.com/devcontainers/base:debian
6767
- features: docker-outside-of-docker
68-
baseImage: mcr.microsoft.com/devcontainers/base:debian
68+
baseImage: mcr.microsoft.com/devcontainers/base:debian
69+
- features: docker-in-docker
70+
baseImage: mcr.microsoft.com/devcontainers/base:ubuntu
71+
- features: docker-outside-of-docker
72+
baseImage: mcr.microsoft.com/devcontainers/base:ubuntu
6973
steps:
7074
- uses: actions/checkout@v6
7175

src/azure-cli/devcontainer-feature.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"id": "azure-cli",
3-
"version": "1.2.9",
3+
"version": "1.3.0",
44
"name": "Azure CLI",
55
"documentationURL": "https://github.com/devcontainers/features/tree/main/src/azure-cli",
66
"description": "Installs the Azure CLI along with needed dependencies. Useful for base Dockerfiles that often are missing required install dependencies like gpg.",

src/azure-cli/install.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ AZ_BICEPVERSION=${BICEPVERSION:-latest}
1919
INSTALL_USING_PYTHON=${INSTALLUSINGPYTHON:-false}
2020
MICROSOFT_GPG_KEYS_URI="https://packages.microsoft.com/keys/microsoft.asc"
2121
AZCLI_ARCHIVE_ARCHITECTURES="amd64 arm64"
22-
AZCLI_ARCHIVE_VERSION_CODENAMES="stretch bookworm buster bullseye bionic focal jammy noble trixie"
22+
AZCLI_ARCHIVE_VERSION_CODENAMES="stretch bookworm buster bullseye bionic focal jammy noble trixie resolute"
2323

2424
if [ "$(id -u)" -ne 0 ]; then
2525
echo -e 'Script must be run as root. Use sudo, su, or add "USER root" to your Dockerfile before running this script.'
@@ -200,6 +200,9 @@ CACHED_AZURE_VERSION="${AZ_VERSION}" # In case we need to fallback to pip and th
200200
if [ "${INSTALL_USING_PYTHON}" != "true" ]; then
201201
if [[ "${AZCLI_ARCHIVE_ARCHITECTURES}" = *"${architecture}"* ]] && [[ "${AZCLI_ARCHIVE_VERSION_CODENAMES}" = *"${VERSION_CODENAME}"* ]]; then
202202
install_using_apt || use_pip="true"
203+
else
204+
echo "(*) Codename '${VERSION_CODENAME}' or architecture '${architecture}' not in apt archive list, falling back to pip installation."
205+
use_pip="true"
203206
fi
204207
else
205208
use_pip="true"

src/common-utils/NOTES.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,13 @@
22

33
This Feature should work on recent versions of Debian/Ubuntu, RedHat Enterprise Linux, Fedora, RockyLinux, and Alpine Linux.
44

5+
## Included utilities
6+
7+
In addition to the common CLI tools (curl, wget, git, jq, nano, vim, etc.), this Feature installs:
8+
9+
- **bubblewrap** (`bwrap`) — a lightweight sandboxing tool used as a dependency by some desktop and container tooling.
10+
- **socat** — a multipurpose relay for bidirectional data transfer between two independent data channels (e.g., sockets, files, pipes).
11+
512
## Using with dev container images
613

714
This Feature is used in many of the [dev container images](https://github.com/search?q=repo%3Adevcontainers%2Fimages+%22ghcr.io%2Fdevcontainers%2Ffeatures%2Fcommon-utils%22&type=code), as a result

0 commit comments

Comments
 (0)