From b35831700dd2b97ff644b4bf1ea970e216c94f0d Mon Sep 17 00:00:00 2001 From: PrymeTyme Date: Thu, 30 Mar 2023 12:55:34 +0200 Subject: [PATCH 1/7] nav buttons fix, mobile visibilty fix,invert image fix,2x2 grid fix,signup validation feature --- src/index.html | 14 +++++++------- src/script.js | 21 ++++++++++++++++++++- src/styles.css | 6 ++++-- 3 files changed, 31 insertions(+), 10 deletions(-) diff --git a/src/index.html b/src/index.html index 04bd19e..8f8e87d 100644 --- a/src/index.html +++ b/src/index.html @@ -15,7 +15,7 @@ diff --git a/src/script.js b/src/script.js index 529f585..33cec52 100644 --- a/src/script.js +++ b/src/script.js @@ -19,11 +19,30 @@ let resetMessage = () => { document.getElementById("empty-error-message").hidden = true; }; +function pushUserToArray(usersTable,email){ + usersTable.push({username:email}) + renderSuccess() + +} + + + addEventListener("submit", (event) => { event.preventDefault(); - resetMessage(); + resetMessage() let email = document.getElementById("email").value; + + if(email === ''){ + renderEmailEmptyError() + }else{ + var index = usersTable.findIndex(x => x.username == email) + index === -1 ? pushUserToArray(usersTable,email): renderEmailTakenError() + + } + + + console.log(usersTable) // TODO: Show Correct Status Messages on Signup Form // 1. successful signup diff --git a/src/styles.css b/src/styles.css index 2cbb72e..d51f1e3 100644 --- a/src/styles.css +++ b/src/styles.css @@ -669,10 +669,12 @@ form > span { #jumbo-image { max-height: 20rem; + filter: invert(1) + /* TODO: Invert banner colors using CSS */ } -@media (max-width: 600px) { +@media (max-width: 980px) { .modal-content { margin: 0 10px; width: auto !important; @@ -877,7 +879,7 @@ form > span { #challenge-grid { display: grid; /* TODO: Fix Issue, Tiles Need to be 2x2 Grid. Change only grid-template-columns */ - grid-template-columns: none; + grid-template-columns: auto auto; grid-auto-rows: 10rem; gap: 1rem; padding-top: 2rem; From 84f869f4db1f3e83bb84a5da422d72761ecb99bd Mon Sep 17 00:00:00 2001 From: PrymeTyme Date: Thu, 30 Mar 2023 13:08:02 +0200 Subject: [PATCH 2/7] fixed navigation from onclick to href --- src/index.html | 10 +++++----- src/styles.css | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/index.html b/src/index.html index 8f8e87d..087c5ef 100644 --- a/src/index.html +++ b/src/index.html @@ -23,15 +23,15 @@ > - - Browse Challenges - Sign Up + + Browse Challenges + Sign Up
- Browse Challenges - Sign Up + Browse Challenges + Sign Up
diff --git a/src/styles.css b/src/styles.css index d51f1e3..355dcbb 100644 --- a/src/styles.css +++ b/src/styles.css @@ -879,7 +879,7 @@ form > span { #challenge-grid { display: grid; /* TODO: Fix Issue, Tiles Need to be 2x2 Grid. Change only grid-template-columns */ - grid-template-columns: auto auto; + grid-template-columns: 400px 400px; grid-auto-rows: 10rem; gap: 1rem; padding-top: 2rem; From a974b2cede108f8be8136f68bb99e3fdd5305b43 Mon Sep 17 00:00:00 2001 From: PrymeTyme Date: Fri, 31 Mar 2023 08:41:51 +0200 Subject: [PATCH 3/7] refire test From ca2724124e66453baced882a541e1516a2c4e4bb Mon Sep 17 00:00:00 2001 From: PrymeTyme Date: Fri, 31 Mar 2023 08:43:52 +0200 Subject: [PATCH 4/7] grid fix --- src/styles.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/styles.css b/src/styles.css index 355dcbb..d51f1e3 100644 --- a/src/styles.css +++ b/src/styles.css @@ -879,7 +879,7 @@ form > span { #challenge-grid { display: grid; /* TODO: Fix Issue, Tiles Need to be 2x2 Grid. Change only grid-template-columns */ - grid-template-columns: 400px 400px; + grid-template-columns: auto auto; grid-auto-rows: 10rem; gap: 1rem; padding-top: 2rem; From 0e6c38e5a936de65e416df8aeed7f7a7c7e8ea08 Mon Sep 17 00:00:00 2001 From: PrymeTyme Date: Fri, 31 Mar 2023 12:23:48 +0200 Subject: [PATCH 5/7] refire test From 4a726a467e349e620c2b432edde203971711b30c Mon Sep 17 00:00:00 2001 From: PrymeTyme Date: Fri, 31 Mar 2023 12:26:00 +0200 Subject: [PATCH 6/7] css grid --- src/styles.css | 1 - 1 file changed, 1 deletion(-) diff --git a/src/styles.css b/src/styles.css index d51f1e3..6fff854 100644 --- a/src/styles.css +++ b/src/styles.css @@ -878,7 +878,6 @@ form > span { #challenge-grid { display: grid; - /* TODO: Fix Issue, Tiles Need to be 2x2 Grid. Change only grid-template-columns */ grid-template-columns: auto auto; grid-auto-rows: 10rem; gap: 1rem; From 37bd582829d334175d5c50519c10c12654dff875 Mon Sep 17 00:00:00 2001 From: PrymeTyme Date: Sun, 2 Apr 2023 10:41:25 +0200 Subject: [PATCH 7/7] refire test