From cd82cf82a0de0f01b4cef0a3f7b78f5783e59a72 Mon Sep 17 00:00:00 2001 From: Jeff Schaefer Date: Fri, 30 May 2025 14:25:35 -0500 Subject: [PATCH 1/5] Fixed tile grid bug --- src/styles.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/styles.css b/src/styles.css index 2cbb72e..e26b3ab 100644 --- a/src/styles.css +++ b/src/styles.css @@ -877,7 +877,7 @@ form > span { #challenge-grid { display: grid; /* TODO: Fix Issue, Tiles Need to be 2x2 Grid. Change only grid-template-columns */ - grid-template-columns: none; + grid-template-columns: 1fr 1fr; grid-auto-rows: 10rem; gap: 1rem; padding-top: 2rem; From 2296e0eacb381a3ef8b4a5c66e4de9791106655f Mon Sep 17 00:00:00 2001 From: Jeff Schaefer Date: Fri, 30 May 2025 14:27:24 -0500 Subject: [PATCH 2/5] Fixed inverted banner image bug --- src/styles.css | 1 + 1 file changed, 1 insertion(+) diff --git a/src/styles.css b/src/styles.css index e26b3ab..251a2e1 100644 --- a/src/styles.css +++ b/src/styles.css @@ -670,6 +670,7 @@ form > span { #jumbo-image { max-height: 20rem; /* TODO: Invert banner colors using CSS */ + filter: invert(100%); } @media (max-width: 600px) { From cfd164be67a6d696d41b177b4d72453bf0e8d9ff Mon Sep 17 00:00:00 2001 From: Jeff Schaefer Date: Fri, 30 May 2025 14:34:46 -0500 Subject: [PATCH 3/5] Fixed desktop nav buttons showing on mobile bug --- src/index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/index.html b/src/index.html index 04bd19e..1e9d251 100644 --- a/src/index.html +++ b/src/index.html @@ -24,8 +24,8 @@ > - Browse Challenges - Sign Up + Browse Challenges + Sign Up From 3a459f5c6c82d8b8cd70676f9a740712210e93dd Mon Sep 17 00:00:00 2001 From: Jeff Schaefer Date: Fri, 30 May 2025 14:40:29 -0500 Subject: [PATCH 4/5] Fixed desktop and mobile nav buttons not working bug --- src/index.html | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/index.html b/src/index.html index 1e9d251..7bc3290 100644 --- a/src/index.html +++ b/src/index.html @@ -23,15 +23,15 @@ > - - Browse Challenges - Sign Up + + Browse Challenges + Sign Up From 4727f25de0c08a81f2ca4dfdf7175ebb6874cf00 Mon Sep 17 00:00:00 2001 From: Jeff Schaefer Date: Fri, 30 May 2025 14:52:29 -0500 Subject: [PATCH 5/5] Added improved form errors feature request --- src/script.js | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/script.js b/src/script.js index 529f585..c8ebccc 100644 --- a/src/script.js +++ b/src/script.js @@ -25,6 +25,20 @@ addEventListener("submit", (event) => { let email = document.getElementById("email").value; + if (email === '' || email === null || email === undefined) { + renderEmailEmptyError(); + return; + } + + let user = usersTable.find(user => user.username === email); + if (user) { + renderEmailTakenError(); + return; + } + + renderSuccess(); + usersTable.push({username:email}); + // TODO: Show Correct Status Messages on Signup Form // 1. successful signup // 2. empty email