Enable more ruff linters (#753)

There are still some failing lints. Tomorrow we can fix a few more but
mostly relax lints to be able to merge.

Author: kylebarron

Diff for: .github/workflows/test.yml

@@ -72,6 +72,9 @@ jobs:
         if: "${{ matrix.python-version == 3.11 }}"
         run: uv run --group docs mkdocs build --strict
 
+      # Use ruff-action so we get annotations in the Github UI
+      - uses: astral-sh/ruff-action@v3
+
       - name: Cache pre-commit virtualenvs
         uses: actions/cache@v4
         if: "${{ matrix.python-version == 3.11 }}"

Diff for: .pre-commit-config.yaml

@@ -18,7 +18,7 @@ repos:
         args: ["--maxkb=5500"]
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.3.4
+    rev: v0.9.6
     hooks:
       - id: ruff
         args: ["--fix"]

Diff for: examples/ais-movingpandas.ipynb

@@ -325,7 +325,7 @@
    "outputs": [],
    "source": [
     "traj_collection = mpd.MinTimeDeltaGeneralizer(traj_collection).generalize(\n",
-    "    tolerance=timedelta(minutes=1)\n",
+    "    tolerance=timedelta(minutes=1),\n",
     ")"
    ]
   },
@@ -430,7 +430,10 @@
    ],
    "source": [
     "trips_layer = TripsLayer.from_movingpandas(\n",
-    "    traj_collection, get_color=get_color, width_min_pixels=5, trail_length = 200\n",
+    "    traj_collection,\n",
+    "    get_color=get_color,\n",
+    "    width_min_pixels=5,\n",
+    "    trail_length=200,\n",
     ")"
    ]
   },
@@ -515,7 +518,10 @@
    "outputs": [],
    "source": [
     "linestring_layer = PathLayer(\n",
-    "    table=trips_layer.table, get_color=get_color, width_min_pixels=1, opacity=0.005\n",
+    "    table=trips_layer.table,\n",
+    "    get_color=get_color,\n",
+    "    width_min_pixels=1,\n",
+    "    opacity=0.005,\n",
     ")"
    ]
   },

Diff for: examples/clicked-point.ipynb

@@ -28,18 +28,23 @@
     "clicked_x_display = widgets.FloatText(description=\"last clicked x:\")\n",
     "clicked_y_display = widgets.FloatText(description=\"last clicked y:\")\n",
     "\n",
-    "def on_map_click(coordinate:Tuple[float, float]) -> None:\n",
-    "    x,y = coordinate\n",
+    "\n",
+    "def on_map_click(coordinate: Tuple[float, float]) -> None:\n",
+    "    x, y = coordinate\n",
     "    clicked_x_display.value = x\n",
     "    clicked_y_display.value = y\n",
+    "\n",
+    "\n",
     "m.on_click(on_map_click)\n",
     "\n",
     "## show the widgets\n",
-    "widgets.VBox([\n",
-    "    m,\n",
-    "    clicked_x_display,\n",
-    "    clicked_y_display\n",
-    "])"
+    "widgets.VBox(\n",
+    "    [\n",
+    "        m,\n",
+    "        clicked_x_display,\n",
+    "        clicked_y_display,\n",
+    "    ],\n",
+    ")"
    ]
   }
  ],

Diff for: examples/column-layer.ipynb

@@ -47,7 +47,8 @@
    "outputs": [],
    "source": [
     "import geopandas as gpd\n",
-    "from lonboard import Map, ColumnLayer"
+    "\n",
+    "from lonboard import ColumnLayer, Map"
    ]
   },
   {
@@ -57,7 +58,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "DATA_URL = 'https://data.source.coop/cboettig/conservation-policy/Inflation_Reduction_Act_Projects.geojson'"
+    "DATA_URL = \"https://data.source.coop/cboettig/conservation-policy/Inflation_Reduction_Act_Projects.geojson\""
    ]
   },
   {
@@ -78,10 +79,10 @@
    "outputs": [],
    "source": [
     "layer = ColumnLayer.from_geopandas(\n",
-    "    df, \n",
-    "    get_elevation=df[\"FUNDING_NUMERIC\"], \n",
-    "    get_fill_color = [255, 255, 0, 140],\n",
-    "    elevation_scale=.01,\n",
+    "    df,\n",
+    "    get_elevation=df[\"FUNDING_NUMERIC\"],\n",
+    "    get_fill_color=[255, 255, 0, 140],\n",
+    "    elevation_scale=0.01,\n",
     "    radius=10000,\n",
     "    pickable=True,\n",
     "    auto_highlight=True,\n",
@@ -97,7 +98,13 @@
    "source": [
     "m = Map(\n",
     "    layer,\n",
-    "    view_state={\"longitude\": -100, \"latitude\": 35, \"zoom\": 4, \"pitch\": 45, \"bearing\": 0},\n",
+    "    view_state={\n",
+    "        \"longitude\": -100,\n",
+    "        \"latitude\": 35,\n",
+    "        \"zoom\": 4,\n",
+    "        \"pitch\": 45,\n",
+    "        \"bearing\": 0,\n",
+    "    },\n",
     ")\n",
     "m"
    ]

Diff for: examples/data-filter-extension.ipynb

@@ -96,7 +96,11 @@
     "    tile_geometries = shapely.from_wkt(df[\"tile\"])\n",
     "    tile_centroids = shapely.centroid(tile_geometries)\n",
     "    non_geom_columns = [col for col in columns if col != \"tile\"]\n",
-    "    gdf = gpd.GeoDataFrame(df[non_geom_columns], geometry=tile_centroids, crs=\"EPSG:4326\")\n",
+    "    gdf = gpd.GeoDataFrame(\n",
+    "        df[non_geom_columns],\n",
+    "        geometry=tile_centroids,\n",
+    "        crs=\"EPSG:4326\",\n",
+    "    )\n",
     "    gdf.to_parquet(local_path)"
    ]
   },
@@ -325,7 +329,7 @@
    "outputs": [],
    "source": [
     "filter_values = np.column_stack(\n",
-    "    [gdf[\"avg_d_kbps\"], gdf[\"avg_u_kbps\"], gdf[\"avg_lat_ms\"]]\n",
+    "    [gdf[\"avg_d_kbps\"], gdf[\"avg_u_kbps\"], gdf[\"avg_lat_ms\"]],\n",
     ")\n",
     "initial_filter_range = [\n",
     "    [10_000, 50_000],\n",
@@ -408,9 +412,27 @@
     }
    ],
    "source": [
-    "download_slider = FloatRangeSlider(value=initial_filter_range[0], min=0, max=70_000, step=0.1, description=\"Download: \")\n",
-    "upload_slider = FloatRangeSlider(value=initial_filter_range[1], min=0, max=50_000, step=1, description=\"Upload: \")\n",
-    "latency_slider = FloatRangeSlider(value=initial_filter_range[2], min=0, max=500, step=1, description=\"Latency: \")\n",
+    "download_slider = FloatRangeSlider(\n",
+    "    value=initial_filter_range[0],\n",
+    "    min=0,\n",
+    "    max=70_000,\n",
+    "    step=0.1,\n",
+    "    description=\"Download: \",\n",
+    ")\n",
+    "upload_slider = FloatRangeSlider(\n",
+    "    value=initial_filter_range[1],\n",
+    "    min=0,\n",
+    "    max=50_000,\n",
+    "    step=1,\n",
+    "    description=\"Upload: \",\n",
+    ")\n",
+    "latency_slider = FloatRangeSlider(\n",
+    "    value=initial_filter_range[2],\n",
+    "    min=0,\n",
+    "    max=500,\n",
+    "    step=1,\n",
+    "    description=\"Latency: \",\n",
+    ")\n",
     "multi_slider = MultiRangeSlider([download_slider, upload_slider, latency_slider])\n",
     "multi_slider"
    ]

Diff for: examples/duckdb.ipynb

@@ -7,9 +7,9 @@
    "source": [
     "# DuckDB Spatial\n",
     "\n",
-    "This is a short example notebook to show how to use [DuckDB Spatial](https://duckdb.org/docs/extensions/spatial.html) with Lonboard. We'll create a [HeatmapLayer](https://developmentseed.org/lonboard/latest/api/layers/heatmap-layer/) with NYC Taxi data. \n",
+    "This is a short example notebook to show how to use [DuckDB Spatial](https://duckdb.org/docs/extensions/spatial.html) with Lonboard. We'll create a [HeatmapLayer](https://developmentseed.org/lonboard/latest/api/layers/heatmap-layer/) with NYC Taxi data.\n",
     "\n",
-    "For full information on how to use DuckDB with Lonboard, [refer to the documentation](https://developmentseed.org/lonboard/latest/ecosystem/duckdb/)."
+    "For full information on how to use DuckDB with Lonboard, [refer to the documentation](https://developmentseed.org/lonboard/latest/ecosystem/duckdb/).\n"
    ]
   },
   {
@@ -22,7 +22,7 @@
    "id": "453b95d2-cb02-4507-bd4a-57ef30278298",
    "metadata": {},
    "source": [
-    "![Screenshot 2024-05-06 at 12.55.26 PM.png](attachment:c90edb21-2f4c-4ca4-be23-e289fde13e6e.png)"
+    "![Screenshot 2024-05-06 at 12.55.26 PM.png](attachment:c90edb21-2f4c-4ca4-be23-e289fde13e6e.png)\n"
    ]
   },
   {
@@ -33,6 +33,7 @@
    "outputs": [],
    "source": [
     "import duckdb\n",
+    "\n",
     "from lonboard import HeatmapLayer, Map"
    ]
   },
@@ -41,7 +42,7 @@
    "id": "e89f04b2-0b22-4d8a-a7cd-9d37d4ac6323",
    "metadata": {},
    "source": [
-    "Create a database connection and install and load the Spatial extension:"
+    "Create a database connection and install and load the Spatial extension:\n"
    ]
   },
   {
@@ -65,7 +66,7 @@
     "\n",
     "There are a few incorrect location values in this dataset with longitude/latitude near \"null island\" at (0, 0), so we pass in bounding-box filtering around the New York City region.\n",
     "\n",
-    "Then we execute this query in our connection."
+    "Then we execute this query in our connection.\n"
    ]
   },
   {
@@ -77,10 +78,10 @@
    "source": [
     "sql = \"\"\"\n",
     "CREATE TABLE rides AS\n",
-    "SELECT \n",
+    "SELECT\n",
     "    *,\n",
     "    ST_Point(dropoff_longitude, dropoff_latitude) as geometry\n",
-    "FROM \"https://d37ci6vzurychx.cloudfront.net/trip-data/yellow_tripdata_2010-03.parquet\" \n",
+    "FROM \"https://d37ci6vzurychx.cloudfront.net/trip-data/yellow_tripdata_2010-03.parquet\"\n",
     "WHERE\n",
     "    dropoff_longitude >= -74.6087 AND\n",
     "    dropoff_latitude >= 40.2738 AND\n",
@@ -97,7 +98,7 @@
    "id": "53b67335-4560-41a7-8329-1cef2d952c84",
    "metadata": {},
    "source": [
-    "Inspecting this table, we can see a variety of columns, plus our `geometry` column:"
+    "Inspecting this table, we can see a variety of columns, plus our `geometry` column:\n"
    ]
   },
   {
@@ -115,7 +116,7 @@
    "id": "85f78761-b1b8-49a1-be25-b13f104b6071",
    "metadata": {},
    "source": [
-    "To pass this data into Lonboard, we can pass a string query or \"relation object\" into the `from_duckdb` class method, plus a reference to our connection. Here the `con.table(\"rides\")` call creates a relation that refers to the entire `rides` table."
+    "To pass this data into Lonboard, we can pass a string query or \"relation object\" into the `from_duckdb` class method, plus a reference to our connection. Here the `con.table(\"rides\")` call creates a relation that refers to the entire `rides` table.\n"
    ]
   },
   {
@@ -144,7 +145,7 @@
    "id": "9fbce4ad-02ce-406c-9003-93f084e5a5c3",
    "metadata": {},
    "source": [
-    "DuckDB Spatial does not currently export coordinate reference system information, but in this case we know the data is already in the EPSG:4326 (WGS84) coordinate system, so we can ignore the generated warning."
+    "DuckDB Spatial does not currently export coordinate reference system information, but in this case we know the data is already in the EPSG:4326 (WGS84) coordinate system, so we can ignore the generated warning.\n"
    ]
   },
   {
@@ -154,7 +155,7 @@
    "source": [
     "The heatmap by default assigns a weight of 1 to each row, so the heatmap shows the unweighted density of rides. We can change this by modifying the [`get_weight`](https://developmentseed.org/lonboard/latest/api/layers/heatmap-layer/#lonboard.HeatmapLayer.get_weight) attribute.\n",
     "\n",
-    "Let's weight the heatmap by the cost of the ride. We can do this by passing in a column from `total_amount`. We can access this column by selecting a table with only that data:"
+    "Let's weight the heatmap by the cost of the ride. We can do this by passing in a column from `total_amount`. We can access this column by selecting a table with only that data:\n"
    ]
   },
   {
@@ -172,7 +173,7 @@
    "id": "1d011e61-b82c-474f-972c-9c4bbb654895",
    "metadata": {},
    "source": [
-    "We want a single column to pass in to the layer, so we select the `total_amount` column:"
+    "We want a single column to pass in to the layer, so we select the `total_amount` column:\n"
    ]
   },
   {
@@ -190,7 +191,7 @@
    "id": "c6483078-c296-40ff-ac5f-534cac768dee",
    "metadata": {},
    "source": [
-    "Then we assign this onto the `get_weight` accessor"
+    "Then we assign this onto the `get_weight` accessor\n"
    ]
   },
   {
@@ -208,7 +209,7 @@
    "id": "1a9c8255-17ee-4f71-84a7-b33dd86c94dd",
    "metadata": {},
    "source": [
-    "Note that the heatmap around airports such as LaGuardia is now darker. There are fewer total rides dropping off at the airport, but each one is expensive!"
+    "Note that the heatmap around airports such as LaGuardia is now darker. There are fewer total rides dropping off at the airport, but each one is expensive!\n"
    ]
   }
  ],
@@ -228,7 +229,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.11.4"
+   "version": "3.11.8"
   },
   "widgets": {
    "application/vnd.jupyter.widget-state+json": {

Diff for: examples/global-boundaries.ipynb

@@ -101,7 +101,7 @@
   },
   {
    "cell_type": "code",
-   "execution_count": 4,
+   "execution_count": null,
    "id": "510879f3-b6b3-475e-9e59-7eef526dbf25",
    "metadata": {
     "scrolled": true
@@ -117,13 +117,15 @@
     "    total_size = int(response.headers.get(\"content-length\", 0))\n",
     "    block_size = 1024\n",
     "\n",
-    "    with tqdm(total=total_size, unit=\"B\", unit_scale=True) as progress_bar:\n",
-    "        with open(filepath, \"wb\") as file:\n",
-    "            for data in response.iter_content(block_size):\n",
-    "                progress_bar.update(len(data))\n",
-    "                file.write(data)\n",
+    "    with (\n",
+    "        tqdm(total=total_size, unit=\"B\", unit_scale=True) as progress_bar,\n",
+    "        open(filepath, \"wb\") as file,\n",
+    "    ):\n",
+    "        for data in response.iter_content(block_size):\n",
+    "            progress_bar.update(len(data))\n",
+    "            file.write(data)\n",
     "\n",
-    "    if total_size != 0 and progress_bar.n != total_size:\n",
+    "    if total_size not in (0, progress_bar.n):\n",
     "        raise RuntimeError(\"Could not download file\")"
    ]
   },

Diff for: examples/integrations/color-picker.ipynb

@@ -232,8 +232,8 @@
    ],
    "source": [
     "ipywidgets.dlink(\n",
-    "    (color_picker, 'value'),\n",
-    "    (layer, 'get_fill_color')\n",
+    "    (color_picker, \"value\"),\n",
+    "    (layer, \"get_fill_color\"),\n",
     ")"
    ]
   },