Skip to content

Commit 3813862

Browse files
author
Tiexin Guo
authored
Merge pull request #573 from merico-dev/chore-fix-release-scripts
chore: update release version related bug
2 parents 1d52db0 + 304a3c3 commit 3813862

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

.github/workflows/automated-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
- name: upload core
4646
run: bash -e ./hack/release/upload_assets.sh ${{ secrets.GITHUB_TOKEN }} ${{ env.TAG }} ${{ env.GOOS }} ${{ env.GOARCH }}
4747
- name: upload plugin
48-
run: aws s3 cp .devstream/ s3://download.devstream.io/${{ env.TAG }}/ --recursive --acl public-read
48+
run: aws s3 cp .devstream/ s3://download.devstream.io/${{ env.TAG }}/ --recursive --acl public-read
4949

5050
# release for darwin-amd64
5151
build-and-release-on-darwin-amd64:

Makefile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,9 @@ ROOT_DIR := $(abspath $(shell cd $(SELF_DIR) && pwd -P))
2424
endif
2525

2626
ifeq ($(origin VERSION), undefined)
27-
VERSION := $(shell git describe --tags --always --match='v*')
27+
# the VERSION is a number, like 0.6.0
28+
# it doesn't contain the prefix v, not v0.6.0, but 0.6.0
29+
VERSION := $(shell git describe --tags --always --match='v*' | cut -c 2-)
2830
endif
2931

3032
ifeq ($(origin PLUGINS_DIR),undefined)

hack/release/auto-release-darwin-arm64.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ while getopts "t:" opt; do
1818
done
1919

2020
if [ "${tag}" == "invalid" ]; then
21-
echo "Maybe you forgot to use -t flag. E.g. sh auto-release-darwin-arm64.sh -t v0.6.0"
21+
echo "Maybe you forgot to use -t flag. E.g. sh auto-release-darwin-arm64.sh -t 0.6.0"
2222
exit 1
2323
fi
2424
echo "tag: ${tag}"

0 commit comments

Comments
 (0)