Skip to content

Commit 06a1e93

Browse files
committed
fix: add conditional rendering on optional property
apparently appGroupListData.createdBy can be undefined
1 parent f330de6 commit 06a1e93

File tree

1 file changed

+21
-20
lines changed

1 file changed

+21
-20
lines changed

Diff for: src/components/ApplicationGroup/Details/EnvironmentOverview/EnvironmentOverview.tsx

+21-20
Original file line numberDiff line numberDiff line change
@@ -184,16 +184,14 @@ export default function EnvironmentOverview({
184184
return (
185185
<div
186186
key={`${item.application}-${index}`}
187-
className={`app-deployments-info-row dc__w-fit-inherit display-grid dc__align-items-center ${
188-
isHovered === index ? 'bc-n50' : 'bcn-0'
189-
} ${lastDeployedClassName}`}
187+
className={`app-deployments-info-row dc__w-fit-inherit display-grid dc__align-items-center ${isHovered === index ? 'bc-n50' : 'bcn-0'
188+
} ${lastDeployedClassName}`}
190189
onMouseEnter={() => setIsHovered(index)}
191190
onMouseLeave={() => setIsHovered(null)}
192191
>
193192
<div
194-
className={`pl-16 pr-16 app-deployment-info-row-leftsection h-100 dc__border-right-n1 dc__align-items-center display-grid dc__position-sticky sticky-column ${
195-
isHovered === index ? 'bc-n50' : 'bcn-0'
196-
}`}
193+
className={`pl-16 pr-16 app-deployment-info-row-leftsection h-100 dc__border-right-n1 dc__align-items-center display-grid dc__position-sticky sticky-column ${isHovered === index ? 'bc-n50' : 'bcn-0'
194+
}`}
197195
>
198196
{isHovered !== index && !isSelected ? (
199197
<DevtronIcon className="icon-dim-20" />
@@ -264,6 +262,7 @@ export default function EnvironmentOverview({
264262
}
265263

266264
const renderSideInfoColumn = () => {
265+
if (!appGroupListData) return null
267266
return (
268267
<aside className="flexbox-col dc__gap-16">
269268
<div className="flexbox-col dc__gap-12">
@@ -323,15 +322,18 @@ export default function EnvironmentOverview({
323322
</div>
324323
<div>
325324
<div className="fs-13 fw-4 lh-20 cn-7 mb-4">Created by</div>
326-
<div className="fs-13 fw-6 lh-20 cn-9 dc__word-break flexbox flex-align-center dc__gap-8">
327-
<div
328-
className="icon-dim-20 mw-20 flexbox flex-justify-center flex-align-center dc__border-radius-50-per dc__uppercase cn-0 fw-4"
329-
style={{ backgroundColor: getRandomColor(appGroupListData.createdBy) }}
330-
>
331-
{appGroupListData.createdBy[0]}
332-
</div>
333-
{appGroupListData.createdBy}
334-
</div>
325+
{appGroupListData.createdBy
326+
? (
327+
<div className="fs-13 fw-6 lh-20 cn-9 dc__word-break flexbox flex-align-center dc__gap-8">
328+
<div
329+
className="icon-dim-20 mw-20 flexbox flex-justify-center flex-align-center dc__border-radius-50-per dc__uppercase cn-0 fw-4"
330+
style={{ backgroundColor: getRandomColor(appGroupListData.createdBy) }}
331+
>
332+
{appGroupListData.createdBy[0]}
333+
</div>
334+
{appGroupListData.createdBy}
335+
</div>
336+
) : '-'}
335337
</div>
336338
</div>
337339
</aside>
@@ -380,13 +382,12 @@ export default function EnvironmentOverview({
380382
checked={selectedAppIds.length === appListData.appInfoList.length}
381383
/>
382384
<span
383-
className={`form__checkbox-container ${
384-
selectedAppIds.length === appListData.appInfoList.length
385+
className={`form__checkbox-container ${selectedAppIds.length === appListData.appInfoList.length
385386
? 'tick-icon'
386387
: selectedAppIds.length > 0
387-
? 'any-selected'
388-
: ''
389-
}`}
388+
? 'any-selected'
389+
: ''
390+
}`}
390391
/>
391392
</label>
392393
{!isVirtualEnv && <ActivityIcon className="icon-dim-16" />}

0 commit comments

Comments
 (0)