fix(compilers/openapi): add explicit type args to resolveRef calls (#98)

PR: #98

Author: OmarAlJarrah

compilers/openapi/auth.go

@@ -23,7 +23,7 @@ func (l *lowerer) lowerSecuritySchemes() {
 	}
 	out := make(map[ir.AuthID]ir.AuthScheme, schemes.Len())
 	for name, rs := range schemes.All() {
-		ss := resolveRef(rs)
+		ss := resolveRef[soa.SecurityScheme](rs)
 		if ss == nil {
 			continue
 		}

compilers/openapi/content.go

@@ -139,7 +139,7 @@ func (l *lowerer) lowerHeaders(headers *sequencedmap.Map[string, *soa.Referenced
 	}
 	out := make([]ir.Property, 0, headers.Len())
 	for name, rh := range headers.All() {
-		h := resolveRef(rh)
+		h := resolveRef[soa.Header](rh)
 		if h == nil {
 			continue
 		}
@@ -174,7 +174,7 @@ func (l *lowerer) exampleList(single *yaml.Node, plural *sequencedmap.Map[string
 		return out
 	}
 	for _, re := range plural.All() {
-		ex := resolveRef(re)
+		ex := resolveRef[soa.Example](re)
 		if ex == nil {
 			continue
 		}
@@ -194,7 +194,7 @@ func (l *lowerer) exampleList(single *yaml.Node, plural *sequencedmap.Map[string
 // so a non-required body stays present with its optionality preserved under
 // Extensions plus one info diagnostic (ir-design §7.2 clarification).
 func (l *lowerer) lowerRequestBody(op *ir.Operation, hb *ir.HTTPBinding, src *soa.Operation, opPointer string) {
-	rb := resolveRef(src.GetRequestBody())
+	rb := resolveRef[soa.RequestBody](src.GetRequestBody())
 	if rb == nil {
 		return
 	}

compilers/openapi/operations.go

@@ -82,7 +82,7 @@ func (l *lowerer) lowerPaths(groups *serviceGroups) {
 		return
 	}
 	for path, rp := range paths.All() {
-		pi := resolveRef(rp)
+		pi := resolveRef[soa.PathItem](rp)
 		if pi == nil {
 			continue
 		}
@@ -122,7 +122,7 @@ func (l *lowerer) lowerWebhooks(groups *serviceGroups) {
 		return
 	}
 	for name, rp := range hooks.All() {
-		pi := resolveRef(rp)
+		pi := resolveRef[soa.PathItem](rp)
 		if pi == nil {
 			continue
 		}
@@ -277,7 +277,7 @@ func (l *lowerer) lowerResponses(src *soa.Operation, opPointer string) ([]ir.Res
 	var responses []ir.Response
 	var errs []ir.ErrorCase
 	for code, rr := range resps.All() {
-		r := resolveRef(rr)
+		r := resolveRef[soa.Response](rr)
 		if r == nil {
 			continue
 		}
@@ -289,7 +289,7 @@ func (l *lowerer) lowerResponses(src *soa.Operation, opPointer string) ([]ir.Res
 			responses = append(responses, l.lowerResponse(r, rng, rptr))
 		}
 	}
-	if def := resolveRef(resps.GetDefault()); def != nil {
+	if def := resolveRef[soa.Response](resps.GetDefault()); def != nil {
 		errs = append(errs, l.lowerErrorCase(def, ir.StatusRange{}, opPointer+ptr("responses", "default")))
 	}
 	return responses, errs
@@ -382,12 +382,12 @@ func (l *lowerer) lowerCallbacks(src *soa.Operation, opPointer, inferred string)
 	var callbacks []ir.Callback
 	var ops []ir.Operation
 	for cbName, rcb := range cbMap.All() {
-		cb := resolveRef(rcb)
+		cb := resolveRef[soa.Callback](rcb)
 		if cb == nil {
 			continue
 		}
 		for expr, rp := range cb.All() {
-			pi := resolveRef(rp)
+			pi := resolveRef[soa.PathItem](rp)
 			if pi == nil {
 				continue
 			}
@@ -450,7 +450,7 @@ func mergeParameters(pathParams, opParams []*soa.ReferencedParameter) []*soa.Ref
 
 // paramKey builds the (in, name) identity of a parameter for merge dedup.
 func paramKey(rp *soa.ReferencedParameter) (string, bool) {
-	p := resolveRef(rp)
+	p := resolveRef[soa.Parameter](rp)
 	if p == nil {
 		return "", false
 	}

compilers/openapi/operations_test.go

@@ -231,7 +231,7 @@ func TestParameters_PathItemMergeOverride(t *testing.T) {
 	require.NotNil(t, loadedDoc)
 	var pi *soa.PathItem
 	for _, rp := range loadedDoc.Doc.GetPaths().All() {
-		pi = resolveRef(rp)
+		pi = resolveRef[soa.PathItem](rp)
 	}
 	require.NotNil(t, pi)
 	op := pi.Get()
@@ -241,7 +241,7 @@ func TestParameters_PathItemMergeOverride(t *testing.T) {
 	assert.Same(t, op.GetParameters()[0], merged[0], "operation parameter overrides the path-item one")
 	names := map[string]bool{}
 	for _, p := range merged {
-		names[resolveRef(p).GetName()] = true
+		names[resolveRef[soa.Parameter](p).GetName()] = true
 	}
 	assert.True(t, names["id"])
 	assert.True(t, names["trace"])
@@ -539,14 +539,14 @@ func TestResolvers_NilInputs(t *testing.T) {
 		re  *soa.ReferencedExample
 		rss *soa.ReferencedSecurityScheme
 	)
-	assert.Nil(t, resolveRef(rpi))
-	assert.Nil(t, resolveRef(rr))
-	assert.Nil(t, resolveRef(rh))
-	assert.Nil(t, resolveRef(rcb))
-	assert.Nil(t, resolveRef(rp))
-	assert.Nil(t, resolveRef(rrb))
-	assert.Nil(t, resolveRef(re))
-	assert.Nil(t, resolveRef(rss))
+	assert.Nil(t, resolveRef[soa.PathItem](rpi))
+	assert.Nil(t, resolveRef[soa.Response](rr))
+	assert.Nil(t, resolveRef[soa.Header](rh))
+	assert.Nil(t, resolveRef[soa.Callback](rcb))
+	assert.Nil(t, resolveRef[soa.Parameter](rp))
+	assert.Nil(t, resolveRef[soa.RequestBody](rrb))
+	assert.Nil(t, resolveRef[soa.Example](re))
+	assert.Nil(t, resolveRef[soa.SecurityScheme](rss))
 	_, ok := paramKey(nil)
 	assert.False(t, ok)
 }

compilers/openapi/params.go

@@ -20,7 +20,7 @@ func (l *lowerer) lowerParameters(params []*soa.ReferencedParameter, opPointer s
 	logical := make([]ir.Parameter, 0, len(params))
 	bindings := make([]ir.HTTPParamBinding, 0, len(params))
 	for i, rp := range params {
-		p := resolveRef(rp)
+		p := resolveRef[soa.Parameter](rp)
 		if p == nil {
 			continue
 		}