Skip to content

Commit 4d7bb48

Browse files
marc0oloclaude
andcommitted
ci: bump dev-env image to v1.2.0
Bump the pinned icp-dev-env image from 1.1.0 to the v-prefixed v1.2.0 tag in the two source-of-truth locations, and document the v-prefix convention in AGENTS.md. The registry publishes both `v1.2.0` and `1.2.0` tags (from type=ref,event=tag and type=semver respectively); we pin the v-prefixed form. dev-env-version-check.yml keeps devcontainer.json and _run-example.yml in sync. Awaiting dfinity/icp-dev-env#43 (the v1.2.0 release); CI will be red until that image is published. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 315dbbb commit 4d7bb48

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

.devcontainer/devcontainer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "ICP Examples (Motoko + Rust)",
3-
"image": "ghcr.io/dfinity/icp-dev-env-all:1.1.0",
3+
"image": "ghcr.io/dfinity/icp-dev-env-all:v1.2.0",
44
"forwardPorts": [8000, 5173],
55
"portsAttributes": {
66
"8000": {

.github/workflows/_run-example.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ on:
5050
jobs:
5151
run:
5252
runs-on: ubuntu-24.04
53-
container: ghcr.io/dfinity/icp-dev-env-${{ inputs.language }}:1.1.0
53+
container: ghcr.io/dfinity/icp-dev-env-${{ inputs.language }}:v1.2.0
5454
env:
5555
ICP_CLI_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
5656
steps:

AGENTS.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -491,9 +491,11 @@ Rust: `icp build backend && candid-extractor target/wasm32-unknown-unknown/relea
491491
## Pending items (do not resolve prematurely)
492492

493493
### Container images
494-
Images are published at `ghcr.io/dfinity/icp-dev-env-{motoko,rust,all}`. Current pinned version: **`1.0.1`**. All devcontainer configs and CI workflows reference the pinned tag. When a new release is cut, update the tag in:
494+
Images are published at `ghcr.io/dfinity/icp-dev-env-{motoko,rust,all}`. Current pinned version: **`v1.2.0`**. Releases are tagged with a `v` prefix (e.g. `v1.2.0`); the registry publishes both `v1.2.0` and `1.2.0` tags, and we pin the `v`-prefixed form. When a new release is cut, update the tag in:
495495
- `.devcontainer/devcontainer.json`
496-
- `.github/workflows/*.yml`
496+
- `.github/workflows/_run-example.yml` (the single source of truth for the CI image version)
497+
498+
`dev-env-version-check.yml` guards that these two stay in sync.
497499

498500
Source: https://github.com/dfinity/icp-dev-env
499501

0 commit comments

Comments
 (0)