Skip to content

Commit c2aa907

Browse files
authored
chore: migrate hosting/oisy-signer-demo to icp-cli (#1431)
* chore: migrate hosting/oisy-signer-demo to icp-cli
1 parent db1de63 commit c2aa907

6 files changed

Lines changed: 30 additions & 47 deletions

File tree

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
name: oisy_signer_demo
2+
on:
3+
push:
4+
branches: [master]
5+
pull_request:
6+
paths:
7+
- hosting/oisy-signer-demo/**
8+
- .github/workflows/oisy_signer_demo.yml
9+
concurrency:
10+
group: ${{ github.workflow }}-${{ github.ref }}
11+
cancel-in-progress: true
12+
jobs:
13+
oisy_signer_demo:
14+
runs-on: ubuntu-24.04
15+
container: ghcr.io/dfinity/icp-dev-env-motoko:1.0.1
16+
env:
17+
ICP_CLI_GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
18+
steps:
19+
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4.3.1
20+
- name: Deploy
21+
working-directory: hosting/oisy-signer-demo
22+
run: |
23+
icp network start -d
24+
icp deploy

hosting/oisy-signer-demo/.gitignore

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,3 @@ dist-ssr
2222
*.njsproj
2323
*.sln
2424
*.sw?
25-
26-
# dfx
27-
.dfx

hosting/oisy-signer-demo/BUILD.md

Lines changed: 0 additions & 28 deletions
This file was deleted.

hosting/oisy-signer-demo/README.md

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,20 +12,18 @@ Testnet tokens can be obtained for free using the [ICP Faucet](https://faucet.in
1212

1313
The `/frontend` folder contains the web assets for the application's user interface, built with React, Vite, and Tailwind CSS.
1414

15-
## Deploying from ICP Ninja
15+
<!-- ## Deploying from ICP Ninja
1616
17-
This example can be deployed directly from [ICP Ninja](https://icp.ninja), a browser-based IDE for ICP. To continue developing locally after deploying from ICP Ninja, see [BUILD.md](BUILD.md).
17+
This example can be deployed directly from [ICP Ninja](https://icp.ninja), a browser-based IDE for ICP.
1818
19-
[![Open in ICP Ninja](https://icp.ninja/assets/open.svg)](https://icp.ninja/i?g=https://github.com/dfinity/examples/hosting/oisy-signer-demo)
20-
21-
> **Note:** ICP Ninja currently uses `dfx` under the hood, which is why this example includes a `dfx.json` configuration file. `dfx` is the legacy CLI, being superseded by [icp-cli](https://cli.icp.build), which is what developers should use for local development.
19+
[![Open in ICP Ninja](https://icp.ninja/assets/open.svg)](https://icp.ninja/i?g=https://github.com/dfinity/examples/hosting/oisy-signer-demo) -->
2220

2321
## Build and deploy from the command line
2422

2523
### Prerequisites
2624

27-
- [x] Install [Node.js](https://nodejs.org/en/download/)
28-
- [x] Install [icp-cli](https://cli.icp.build): `npm install -g @icp-sdk/icp-cli @icp-sdk/ic-wasm`
25+
- [Node.js](https://nodejs.org/) v18+
26+
- [icp-cli](https://cli.internetcomputer.org/): `npm install -g @icp-sdk/icp-cli @icp-sdk/ic-wasm`
2927

3028
### Install
3129

hosting/oisy-signer-demo/dfx.json

Lines changed: 0 additions & 9 deletions
This file was deleted.

hosting/oisy-signer-demo/icp.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@ canisters:
55
configuration:
66
dir: frontend/dist
77
build:
8+
- npm install --prefix frontend
89
- npm run build --prefix frontend

0 commit comments

Comments
 (0)