From 4e27d6bcf292659bcb35cff3c6b8a4fc8b2265b5 Mon Sep 17 00:00:00 2001 From: mraszyk <31483726+mraszyk@users.noreply.github.com> Date: Wed, 8 Jul 2026 14:59:28 +0200 Subject: [PATCH 01/13] chore: bump rustc to v1.95.0 (#10390) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This PR bumps the Rust version to v1.95.0. ## Canbench summary =================================================================================== ## ckBTC minter target: //rs/bitcoin/ckbtc/minter:ckbtc_minter_canbench results file: rs/bitcoin/ckbtc/minter/canbench/results.yml =================================================================================== Summary: instructions: status: Improvements detected 🟢 counts: [total 7 | regressed 0 | improved 7 | new 0 | unchanged 0] change: [max -163.50K | p75 -163.64K | median -163.68K | p25 -163.68K | min -164.78K] change %: [max -38.39% | p75 -38.72% | median -38.78% | p25 -38.81% | min -38.99%] heap_increase: status: No significant changes 👍 counts: [total 7 | regressed 0 | improved 0 | new 0 | unchanged 7] change: [max 0 | p75 0 | median 0 | p25 0 | min 0] change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%] stable_memory_increase: status: No significant changes 👍 counts: [total 7 | regressed 0 | improved 0 | new 0 | unchanged 7] change: [max 0 | p75 0 | median 0 | p25 0 | min 0] change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%] --------------------------------------------------- Only significant changes: | status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% | |--------|------------------------------------------------------------------------------------|-------|---------|---------|----|--------|-----|---------| | - | build_estimate_retrieve_btc_fee_1_50k_sats::build_unsigned_transaction_from_inputs | 1 | 3.26K | -3.03% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_1_50k_sats::build_unsigned_transaction_from_inputs | 1 | 3.26K | -3.03% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_2_100k_sats::build_unsigned_transaction_from_inputs | 1 | 3.26K | -3.03% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_3_1m_sats::build_unsigned_transaction_from_inputs | 1 | 3.26K | -3.03% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_4_10m_sats::build_unsigned_transaction_from_inputs | 1 | 3.26K | -3.03% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_5_1_btc::build_unsigned_transaction_from_inputs | 1 | 3.26K | -3.03% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_6_10_btc::build_unsigned_transaction_from_inputs | 1 | 3.70K | -3.50% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_3_1m_sats::greedy | 1 | 3.06K | -13.00% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_2_100k_sats::greedy | 1 | 4.43K | -13.30% | 0 | 0.00% | 0 | 0.00% | | - | build_estimate_retrieve_btc_fee_1_50k_sats::greedy | 1 | 4.38K | -13.42% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_1_50k_sats::greedy | 1 | 4.38K | -13.42% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_4_10m_sats::greedy | 1 | 4.08K | -14.15% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_5_1_btc::greedy | 1 | 4.08K | -14.15% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_6_10_btc::greedy | 1 | 11.85K | -14.40% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_6_10_btc | | 264.48K | -38.39% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_6_10_btc::build_unsigned_transaction | 1 | 261.93K | -38.61% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_4_10m_sats | | 259.10K | -38.72% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_5_1_btc | | 259.10K | -38.72% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_3_1m_sats | | 258.14K | -38.78% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_2_100k_sats | | 258.06K | -38.81% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_1_50k_sats | | 258.02K | -38.81% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_4_10m_sats::build_unsigned_transaction | 1 | 256.56K | -38.94% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_5_1_btc::build_unsigned_transaction | 1 | 256.56K | -38.94% | 0 | 0.00% | 0 | 0.00% | | - | build_estimate_retrieve_btc_fee_1_50k_sats | | 255.97K | -38.99% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_3_1m_sats::build_unsigned_transaction | 1 | 255.59K | -39.01% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_2_100k_sats::build_unsigned_transaction | 1 | 255.52K | -39.04% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_1_50k_sats::build_unsigned_transaction | 1 | 255.47K | -39.04% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_6_10_btc::utxos_selection | 1 | 256.06K | -39.12% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_4_10m_sats::utxos_selection | 1 | 251.12K | -39.43% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_5_1_btc::utxos_selection | 1 | 251.12K | -39.43% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_3_1m_sats::utxos_selection | 1 | 250.16K | -39.50% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_2_100k_sats::utxos_selection | 1 | 250.08K | -39.53% | 0 | 0.00% | 0 | 0.00% | | - | build_estimate_retrieve_btc_fee_1_50k_sats::utxos_selection | 1 | 250.03K | -39.53% | 0 | 0.00% | 0 | 0.00% | | - | build_unsigned_transaction_1_50k_sats::utxos_selection | 1 | 250.03K | -39.53% | 0 | 0.00% | 0 | 0.00% | ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change =================================================================================== ## ckETH minter target: //rs/ethereum/cketh/minter:cketh_minter_canbench results file: rs/ethereum/cketh/minter/canbench/results.yml =================================================================================== Summary: instructions: status: Improvements detected 🟢 counts: [total 1 | regressed 0 | improved 1 | new 0 | unchanged 0] change: [max -108.95M | p75 -108.95M | median -108.95M | p25 -108.95M | min -108.95M] change %: [max -11.11% | p75 -11.11% | median -11.11% | p25 -11.11% | min -11.11%] heap_increase: status: No significant changes 👍 counts: [total 1 | regressed 0 | improved 0 | new 0 | unchanged 1] change: [max 0 | p75 0 | median 0 | p25 0 | min 0] change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%] stable_memory_increase: status: No significant changes 👍 counts: [total 1 | regressed 0 | improved 0 | new 0 | unchanged 1] change: [max 0 | p75 0 | median 0 | p25 0 | min 0] change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%] --------------------------------------------------- Only significant changes: | status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% | |--------|--------------------|-------|---------|---------|-----|--------|-----|---------| | - | bench_post_upgrade | | 871.40M | -11.11% | 222 | 0.00% | 0 | 0.00% | ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change =================================================================================== ## ICP ledger target: //rs/ledger_suite/icp/ledger:ledger_canbench results file: rs/ledger_suite/icp/ledger/canbench_results/canbench.yml =================================================================================== Summary: instructions: status: Improvements detected 🟢 counts: [total 1 | regressed 0 | improved 1 | new 0 | unchanged 0] change: [max -308.62M | p75 -308.62M | median -308.62M | p25 -308.62M | min -308.62M] change %: [max -2.14% | p75 -2.14% | median -2.14% | p25 -2.14% | min -2.14%] heap_increase: status: No significant changes 👍 counts: [total 1 | regressed 0 | improved 0 | new 0 | unchanged 1] change: [max 0 | p75 0 | median 0 | p25 0 | min 0] change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%] stable_memory_increase: status: No significant changes 👍 counts: [total 1 | regressed 0 | improved 0 | new 0 | unchanged 1] change: [max 0 | p75 0 | median 0 | p25 0 | min 0] change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%] --------------------------------------------------- Only significant changes: | status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% | |--------|---------------------------------------|-------|--------|---------|----|--------|-----|---------| | - | bench_endpoints | | 14.08B | -2.14% | 62 | 0.00% | 256 | 0.00% | | - | bench_endpoints::icrc2_transfer_from | 1 | 6.65B | -2.71% | 2 | 0.00% | 128 | 0.00% | | - | bench_endpoints::query_blocks | 1 | 36.75M | -3.49% | 13 | 0.00% | 0 | 0.00% | | - | bench_endpoints::query_encoded_blocks | 1 | 6.91M | -6.45% | 0 | 0.00% | 0 | 0.00% | ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change =================================================================================== ## ICRC-1 ledger (u256) target: //rs/ledger_suite/icrc1/ledger:canbench_u256 results file: rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u256.yml =================================================================================== Summary: instructions: status: Improvements detected 🟢 counts: [total 2 | regressed 0 | improved 1 | new 0 | unchanged 1] change: [max -21.14K | p75 -883.02M | median -1.77B | p25 -2.65B | min -3.53B] change %: [max -0.24% | p75 -1.82% | median -3.39% | p25 -4.97% | min -6.54%] heap_increase: status: No significant changes 👍 counts: [total 2 | regressed 0 | improved 0 | new 0 | unchanged 2] change: [max 0 | p75 0 | median 0 | p25 0 | min 0] change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%] stable_memory_increase: status: No significant changes 👍 counts: [total 2 | regressed 0 | improved 0 | new 0 | unchanged 2] change: [max 0 | p75 0 | median 0 | p25 0 | min 0] change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%] --------------------------------------------------- Only significant changes: | status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% | |--------|-----------------------------------------------|-------|---------|---------|-----|--------|-----|---------| | + | bench_icrc1_transfers::post_upgrade | 1 | 379.28M | +7.98% | 71 | 0.00% | 0 | 0.00% | | + | bench_icrc1_transfers::upgrade | 1 | 529.25M | +5.87% | 200 | 0.00% | 128 | 0.00% | | - | bench_icrc1_transfers::icrc1_transfer | 1 | 12.31B | -4.16% | 31 | 0.00% | 0 | 0.00% | | - | bench_icrc1_transfers::get_blocks | 1 | 7.39M | -5.27% | 0 | 0.00% | 0 | 0.00% | | - | bench_icrc1_transfers::icrc3_get_blocks | 1 | 8.50M | -5.79% | 0 | 0.00% | 0 | 0.00% | | - | bench_icrc1_transfers | | 50.46B | -6.54% | 262 | 0.00% | 256 | 0.00% | | - | bench_icrc1_transfers::icrc2_transfer_from | 1 | 19.66B | -7.40% | 3 | 0.00% | 0 | 0.00% | | - | bench_icrc1_transfers::icrc2_approve | 1 | 17.76B | -7.49% | 28 | 0.00% | 128 | 0.00% | | - | bench_icrc1_transfers::icrc103_get_allowances | 1 | 5.25M | -19.06% | 0 | 0.00% | 0 | 0.00% | ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change =================================================================================== ## ICRC-1 ledger (u64) target: //rs/ledger_suite/icrc1/ledger:canbench_u64 results file: rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u64.yml =================================================================================== Summary: instructions: status: Improvements detected 🟢 counts: [total 2 | regressed 0 | improved 1 | new 0 | unchanged 1] change: [max -20.83K | p75 -871.90M | median -1.74B | p25 -2.62B | min -3.49B] change %: [max -0.24% | p75 -1.84% | median -3.45% | p25 -5.05% | min -6.65%] heap_increase: status: No significant changes 👍 counts: [total 2 | regressed 0 | improved 0 | new 0 | unchanged 2] change: [max 0 | p75 0 | median 0 | p25 0 | min 0] change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%] stable_memory_increase: status: No significant changes 👍 counts: [total 2 | regressed 0 | improved 0 | new 0 | unchanged 2] change: [max 0 | p75 0 | median 0 | p25 0 | min 0] change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%] --------------------------------------------------- Only significant changes: | status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% | |--------|-----------------------------------------------|-------|---------|---------|-----|--------|-----|---------| | + | bench_icrc1_transfers::post_upgrade | 1 | 379.10M | +8.02% | 73 | 0.00% | 0 | 0.00% | | + | bench_icrc1_transfers::upgrade | 1 | 528.83M | +5.85% | 202 | 0.00% | 128 | 0.00% | | - | bench_icrc1_transfers::icrc1_transfer | 1 | 11.77B | -4.25% | 31 | 0.00% | 0 | 0.00% | | - | bench_icrc1_transfers::get_blocks | 1 | 6.81M | -5.80% | 0 | 0.00% | 0 | 0.00% | | - | bench_icrc1_transfers::icrc3_get_blocks | 1 | 7.89M | -6.32% | 0 | 0.00% | 0 | 0.00% | | - | bench_icrc1_transfers | | 48.92B | -6.65% | 264 | 0.00% | 256 | 0.00% | | - | bench_icrc1_transfers::icrc2_transfer_from | 1 | 19.21B | -7.49% | 3 | 0.00% | 0 | 0.00% | | - | bench_icrc1_transfers::icrc2_approve | 1 | 17.22B | -7.62% | 28 | 0.00% | 128 | 0.00% | | - | bench_icrc1_transfers::icrc103_get_allowances | 1 | 4.42M | -21.76% | 0 | 0.00% | 0 | 0.00% | ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change =================================================================================== ## NNS governance target: //rs/nns/governance:governance-canbench results file: rs/nns/governance/canbench/canbench_results.yml =================================================================================== Summary: instructions: status: Improvements detected 🟢 counts: [total 28 | regressed 0 | improved 3 | new 0 | unchanged 25] change: [max +924.98K | p75 -852 | median -60.22K | p25 -465.20K | min -3.14M] change %: [max +1.62% | p75 -0.76% | median -2.24% | p25 -2.78% | min -7.58%] heap_increase: status: No significant changes 👍 counts: [total 28 | regressed 0 | improved 0 | new 0 | unchanged 28] change: [max 0 | p75 0 | median 0 | p25 0 | min 0] change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%] stable_memory_increase: status: No significant changes 👍 counts: [total 28 | regressed 0 | improved 0 | new 0 | unchanged 28] change: [max 0 | p75 0 | median 0 | p25 0 | min 0] change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%] --------------------------------------------------- Only significant changes: | status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% | |--------|--------------------------------------------------------|-------|--------|---------|----|--------|-----|---------| | - | unstake_maturity_of_dissolved_neurons::list_neuron_ids | 1 | 37.65M | -5.56% | 0 | 0.00% | 0 | 0.00% | | - | list_ready_to_spawn_neuron_ids | | 36.31M | -5.59% | 0 | 0.00% | 0 | 0.00% | | - | compute_ballots_for_new_proposal_with_stable_neurons | | 2.30M | -6.16% | 0 | 0.00% | 256 | 0.00% | | - | neuron_metrics_calculation | | 3.35M | -7.58% | 0 | 0.00% | 0 | 0.00% | ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change =================================================================================== ## Registry canister target: //rs/registry/canister:registry-canbench results file: rs/registry/canister/canbench/canbench_results.yml =================================================================================== Summary: instructions: status: Improvements detected 🟢 counts: [total 14 | regressed 0 | improved 10 | new 0 | unchanged 4] change: [max -5 | p75 -1.15M | median -10.78M | p25 -32.86M | min -1.30B] change %: [max -0.00% | p75 -0.63% | median -3.09% | p25 -9.71% | min -13.80%] heap_increase: status: No significant changes 👍 counts: [total 14 | regressed 0 | improved 0 | new 0 | unchanged 14] change: [max 0 | p75 0 | median 0 | p25 0 | min 0] change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%] stable_memory_increase: status: No significant changes 👍 counts: [total 14 | regressed 0 | improved 0 | new 0 | unchanged 14] change: [max 0 | p75 0 | median 0 | p25 0 | min 0] change %: [max 0.00% | p75 0.00% | median 0.00% | p25 0.00% | min 0.00%] --------------------------------------------------- Only significant changes: | status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% | |--------|-------------------------------------------------------------|-------|---------|---------|-----|--------|-----|---------| | - | get_subnet_for_canister_100_times_10k | | 685.74M | -2.43% | 0 | 0.00% | 0 | 0.00% | | - | upgrade_with_routing_table_10k | | 5.46B | -2.98% | 342 | 0.00% | 0 | 0.00% | | - | upgrade_with_routing_table_10k::post_upgrade | 1 | 5.43B | -2.99% | 217 | 0.00% | 0 | 0.00% | | - | upgrade_with_routing_table_1k | | 669.20M | -3.02% | 40 | 0.00% | 0 | 0.00% | | - | upgrade_with_routing_table_1k::post_upgrade | 1 | 666.33M | -3.04% | 25 | 0.00% | 0 | 0.00% | | - | upgrade_with_routing_table_100 | | 184.18M | -3.16% | 7 | 0.00% | 0 | 0.00% | | - | upgrade_with_routing_table_100::post_upgrade | 1 | 183.30M | -3.17% | 4 | 0.00% | 0 | 0.00% | | - | get_subnet_for_canister_100_times_1k | | 87.92M | -4.23% | 0 | 0.00% | 0 | 0.00% | | - | get_subnet_for_canister_100_times_100 | | 28.45M | -8.38% | 0 | 0.00% | 0 | 0.00% | | - | migrate_canisters_10_times_100 | | 137.68M | -10.15% | 0 | 0.00% | 0 | 0.00% | | - | migrate_canisters_10_times_1k | | 902.16M | -11.78% | 3 | 0.00% | 0 | 0.00% | | - | migrate_canisters_10_times_10k | | 8.98B | -12.68% | 0 | 0.00% | 0 | 0.00% | | - | measure_routing_table_invariant_checks_shards_and_unsharded | | 230.35M | -13.80% | 138 | 0.00% | 0 | 0.00% | ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change --------- Co-authored-by: IDX GitHub Automation <> Co-authored-by: Claude Opus 4.8 (1M context) --- .devcontainer/devcontainer.json | 4 +- .github/workflows/api-bn-recovery-test.yml | 2 +- .github/workflows/ci-main.yml | 8 +-- .github/workflows/ci-pr-only.yml | 2 +- .../workflows/container-api-bn-recovery.yml | 2 +- .github/workflows/container-scan-nightly.yml | 2 +- .github/workflows/local-system-tests.yml | 2 +- .github/workflows/pocket-ic-tests-windows.yml | 2 +- .../workflows/rate-limits-backend-release.yml | 2 +- .github/workflows/release-testing.yml | 2 +- .github/workflows/rosetta-release.yml | 2 +- .../salt-sharing-canister-release.yml | 2 +- .github/workflows/schedule-daily.yml | 2 +- .github/workflows/schedule-rust-bench.yml | 2 +- .../system-tests-benchmarks-nightly.yml | 2 +- .../update-mainnet-canister-revisions.yaml | 2 +- bazel/rust.MODULE.bazel | 2 +- ci/container/TAG | 2 +- rs/bitcoin/ckbtc/minter/canbench/results.yml | 68 +++++++++---------- rs/ethereum/cketh/minter/canbench/results.yml | 4 +- .../icp/ledger/canbench_results/canbench.yml | 15 ++-- .../ledger/canbench_results/canbench_u256.yml | 28 ++++---- .../ledger/canbench_results/canbench_u64.yml | 28 ++++---- .../governance/canbench/canbench_results.yml | 62 ++++++++--------- .../canister/canbench/canbench_results.yml | 42 ++++++------ rust-toolchain.toml | 2 +- 26 files changed, 147 insertions(+), 146 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index ac2ddc4cf69c..490ad501d404 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,5 +1,5 @@ { - "image": "ghcr.io/dfinity/ic-dev@sha256:5b05362c9cfe6838603c8b9315dd5d78934b7631f76508e008258cb723fee6cd", + "image": "ghcr.io/dfinity/ic-dev@sha256:87894a45bc67db8f923c4ea8f7a194d982d5c514f205451fba1f65d8f745d97d", "remoteUser": "ubuntu", "privileged": true, "runArgs": [ @@ -82,4 +82,4 @@ } } } -} \ No newline at end of file +} diff --git a/.github/workflows/api-bn-recovery-test.yml b/.github/workflows/api-bn-recovery-test.yml index b896f9cbeea5..53cf4b97b1fa 100644 --- a/.github/workflows/api-bn-recovery-test.yml +++ b/.github/workflows/api-bn-recovery-test.yml @@ -22,7 +22,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:8bafa91b3865839610cb81c58b3af5bfbb9e975ae5d8d68e609ee95c0b33b9ec + image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/home/buildifier/.local/share/containers" diff --git a/.github/workflows/ci-main.yml b/.github/workflows/ci-main.yml index ead014027b6c..21b329f62388 100644 --- a/.github/workflows/ci-main.yml +++ b/.github/workflows/ci-main.yml @@ -33,7 +33,7 @@ jobs: runs-on: &dind-large-setup labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:8bafa91b3865839610cb81c58b3af5bfbb9e975ae5d8d68e609ee95c0b33b9ec + image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 90 @@ -296,9 +296,9 @@ jobs: bazel_args='${{ steps.infer-bazel-args.outputs.bazel-args }}' test_targets="$HOME/.cache/bazel-targets/test-targets" - if [ -s "$test_targets" ]; then # bazel errors out if no test targets are listed - eval "bazel test $bazel_args --target_pattern_file=$test_targets" - fi + #if [ -s "$test_targets" ]; then # bazel errors out if no test targets are listed + # eval "bazel test $bazel_args --target_pattern_file=$test_targets" + #fi # Build & upload arm64-{linux,darwin} binaries, # build the entire codebase on arm64-darwin, diff --git a/.github/workflows/ci-pr-only.yml b/.github/workflows/ci-pr-only.yml index 147504da4ec4..f016092c4325 100644 --- a/.github/workflows/ci-pr-only.yml +++ b/.github/workflows/ci-pr-only.yml @@ -37,7 +37,7 @@ jobs: runs-on: &dind-small-setup labels: dind-small container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:8bafa91b3865839610cb81c58b3af5bfbb9e975ae5d8d68e609ee95c0b33b9ec + image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a options: >- -e NODE_NAME --mount type=tmpfs,target="/tmp/containers" steps: diff --git a/.github/workflows/container-api-bn-recovery.yml b/.github/workflows/container-api-bn-recovery.yml index cde299903fa4..4ad9c73b8343 100644 --- a/.github/workflows/container-api-bn-recovery.yml +++ b/.github/workflows/container-api-bn-recovery.yml @@ -28,7 +28,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:8bafa91b3865839610cb81c58b3af5bfbb9e975ae5d8d68e609ee95c0b33b9ec + image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/home/buildifier/.local/share/containers" diff --git a/.github/workflows/container-scan-nightly.yml b/.github/workflows/container-scan-nightly.yml index 9e315ae0f1e2..5dfc4fc33fc4 100644 --- a/.github/workflows/container-scan-nightly.yml +++ b/.github/workflows/container-scan-nightly.yml @@ -12,7 +12,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:8bafa91b3865839610cb81c58b3af5bfbb9e975ae5d8d68e609ee95c0b33b9ec + image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 60 diff --git a/.github/workflows/local-system-tests.yml b/.github/workflows/local-system-tests.yml index d4e320682c49..6d603ec48244 100644 --- a/.github/workflows/local-system-tests.yml +++ b/.github/workflows/local-system-tests.yml @@ -19,7 +19,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:8bafa91b3865839610cb81c58b3af5bfbb9e975ae5d8d68e609ee95c0b33b9ec + image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 600 diff --git a/.github/workflows/pocket-ic-tests-windows.yml b/.github/workflows/pocket-ic-tests-windows.yml index 3c66382fa88d..dca3df25745c 100644 --- a/.github/workflows/pocket-ic-tests-windows.yml +++ b/.github/workflows/pocket-ic-tests-windows.yml @@ -45,7 +45,7 @@ jobs: bazel-build-pocket-ic: name: Bazel Build PocketIC container: - image: ghcr.io/dfinity/ic-build@sha256:8bafa91b3865839610cb81c58b3af5bfbb9e975ae5d8d68e609ee95c0b33b9ec + image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 90 diff --git a/.github/workflows/rate-limits-backend-release.yml b/.github/workflows/rate-limits-backend-release.yml index abd98b9cbd36..98051c49f519 100644 --- a/.github/workflows/rate-limits-backend-release.yml +++ b/.github/workflows/rate-limits-backend-release.yml @@ -32,7 +32,7 @@ jobs: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:8bafa91b3865839610cb81c58b3af5bfbb9e975ae5d8d68e609ee95c0b33b9ec + image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" diff --git a/.github/workflows/release-testing.yml b/.github/workflows/release-testing.yml index 861a96fbcb38..bbf002803d9d 100644 --- a/.github/workflows/release-testing.yml +++ b/.github/workflows/release-testing.yml @@ -35,7 +35,7 @@ jobs: group: dm1 labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:8bafa91b3865839610cb81c58b3af5bfbb9e975ae5d8d68e609ee95c0b33b9ec + image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 180 diff --git a/.github/workflows/rosetta-release.yml b/.github/workflows/rosetta-release.yml index 731d107e87c6..0e75e9ae0279 100644 --- a/.github/workflows/rosetta-release.yml +++ b/.github/workflows/rosetta-release.yml @@ -22,7 +22,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:8bafa91b3865839610cb81c58b3af5bfbb9e975ae5d8d68e609ee95c0b33b9ec + image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" environment: DockerHub diff --git a/.github/workflows/salt-sharing-canister-release.yml b/.github/workflows/salt-sharing-canister-release.yml index 25e8889184b0..d3704bb67dff 100644 --- a/.github/workflows/salt-sharing-canister-release.yml +++ b/.github/workflows/salt-sharing-canister-release.yml @@ -32,7 +32,7 @@ jobs: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:8bafa91b3865839610cb81c58b3af5bfbb9e975ae5d8d68e609ee95c0b33b9ec + image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" diff --git a/.github/workflows/schedule-daily.yml b/.github/workflows/schedule-daily.yml index a74a9885fff6..bb75cfd01b04 100644 --- a/.github/workflows/schedule-daily.yml +++ b/.github/workflows/schedule-daily.yml @@ -14,7 +14,7 @@ jobs: runs-on: &dind-large-setup labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:8bafa91b3865839610cb81c58b3af5bfbb9e975ae5d8d68e609ee95c0b33b9ec + image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 720 # 12 hours diff --git a/.github/workflows/schedule-rust-bench.yml b/.github/workflows/schedule-rust-bench.yml index ff1307bcae09..6dc927d98a16 100644 --- a/.github/workflows/schedule-rust-bench.yml +++ b/.github/workflows/schedule-rust-bench.yml @@ -24,7 +24,7 @@ jobs: # see linux-x86-64 runner group labels: rust-benchmarks container: - image: ghcr.io/dfinity/ic-build@sha256:8bafa91b3865839610cb81c58b3af5bfbb9e975ae5d8d68e609ee95c0b33b9ec + image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a # running on bare metal machine using ubuntu user options: --user ubuntu --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 720 # 12 hours diff --git a/.github/workflows/system-tests-benchmarks-nightly.yml b/.github/workflows/system-tests-benchmarks-nightly.yml index 1d2a37959ed6..2a4293d1b26e 100644 --- a/.github/workflows/system-tests-benchmarks-nightly.yml +++ b/.github/workflows/system-tests-benchmarks-nightly.yml @@ -17,7 +17,7 @@ jobs: group: dm1 labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:8bafa91b3865839610cb81c58b3af5bfbb9e975ae5d8d68e609ee95c0b33b9ec + image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 480 diff --git a/.github/workflows/update-mainnet-canister-revisions.yaml b/.github/workflows/update-mainnet-canister-revisions.yaml index 16418d2e3174..7069154717c6 100644 --- a/.github/workflows/update-mainnet-canister-revisions.yaml +++ b/.github/workflows/update-mainnet-canister-revisions.yaml @@ -25,7 +25,7 @@ jobs: labels: dind-small environment: CREATE_PR container: - image: ghcr.io/dfinity/ic-build@sha256:8bafa91b3865839610cb81c58b3af5bfbb9e975ae5d8d68e609ee95c0b33b9ec + image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" env: diff --git a/bazel/rust.MODULE.bazel b/bazel/rust.MODULE.bazel index 16e3c81d8c5e..d06e40afbcf6 100644 --- a/bazel/rust.MODULE.bazel +++ b/bazel/rust.MODULE.bazel @@ -22,7 +22,7 @@ archive_override( rust = use_extension("@rules_rust//rust:extensions.bzl", "rust") rust.toolchain( edition = "2024", - versions = ["1.93.1"], + versions = ["1.95.0"], ) # Repin with `CARGO_BAZEL_REPIN=true bazel build @crate_index//...` diff --git a/ci/container/TAG b/ci/container/TAG index 106afb8050d5..e7769bd66da0 100644 --- a/ci/container/TAG +++ b/ci/container/TAG @@ -1 +1 @@ -8daf75b044f16ab4395e9746071e3d091157dac66460efb58bd61345c7a376cd +89a837aa8518f5ee070ef24f8e0c0197a9a5b0c3545ef1477f7b71c863030d51 diff --git a/rs/bitcoin/ckbtc/minter/canbench/results.yml b/rs/bitcoin/ckbtc/minter/canbench/results.yml index 053472f25193..458aeaa84c15 100644 --- a/rs/bitcoin/ckbtc/minter/canbench/results.yml +++ b/rs/bitcoin/ckbtc/minter/canbench/results.yml @@ -2,185 +2,185 @@ benches: build_estimate_retrieve_btc_fee_1_50k_sats: total: calls: 1 - instructions: 419577 + instructions: 255972 heap_increase: 0 stable_memory_increase: 0 scopes: build_unsigned_transaction_from_inputs: calls: 1 - instructions: 3363 + instructions: 3261 heap_increase: 0 stable_memory_increase: 0 greedy: calls: 1 - instructions: 5061 + instructions: 4382 heap_increase: 0 stable_memory_increase: 0 utxos_selection: calls: 1 - instructions: 413516 + instructions: 250033 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_1_50k_sats: total: calls: 1 - instructions: 421693 + instructions: 258016 heap_increase: 0 stable_memory_increase: 0 scopes: build_unsigned_transaction: calls: 1 - instructions: 419110 + instructions: 255471 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_from_inputs: calls: 1 - instructions: 3363 + instructions: 3261 heap_increase: 0 stable_memory_increase: 0 greedy: calls: 1 - instructions: 5061 + instructions: 4382 heap_increase: 0 stable_memory_increase: 0 utxos_selection: calls: 1 - instructions: 413516 + instructions: 250033 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_2_100k_sats: total: calls: 1 - instructions: 421739 + instructions: 258062 heap_increase: 0 stable_memory_increase: 0 scopes: build_unsigned_transaction: calls: 1 - instructions: 419156 + instructions: 255517 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_from_inputs: calls: 1 - instructions: 3363 + instructions: 3261 heap_increase: 0 stable_memory_increase: 0 greedy: calls: 1 - instructions: 5107 + instructions: 4428 heap_increase: 0 stable_memory_increase: 0 utxos_selection: calls: 1 - instructions: 413562 + instructions: 250079 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_3_1m_sats: total: calls: 1 - instructions: 421642 + instructions: 258138 heap_increase: 0 stable_memory_increase: 0 scopes: build_unsigned_transaction: calls: 1 - instructions: 419059 + instructions: 255593 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_from_inputs: calls: 1 - instructions: 3363 + instructions: 3261 heap_increase: 0 stable_memory_increase: 0 greedy: calls: 1 - instructions: 3523 + instructions: 3065 heap_increase: 0 stable_memory_increase: 0 utxos_selection: calls: 1 - instructions: 413465 + instructions: 250155 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_4_10m_sats: total: calls: 1 - instructions: 422782 + instructions: 259101 heap_increase: 0 stable_memory_increase: 0 scopes: build_unsigned_transaction: calls: 1 - instructions: 420199 + instructions: 256556 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_from_inputs: calls: 1 - instructions: 3363 + instructions: 3261 heap_increase: 0 stable_memory_increase: 0 greedy: calls: 1 - instructions: 4750 + instructions: 4078 heap_increase: 0 stable_memory_increase: 0 utxos_selection: calls: 1 - instructions: 414605 + instructions: 251118 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_5_1_btc: total: calls: 1 - instructions: 422782 + instructions: 259101 heap_increase: 0 stable_memory_increase: 0 scopes: build_unsigned_transaction: calls: 1 - instructions: 420199 + instructions: 256556 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_from_inputs: calls: 1 - instructions: 3363 + instructions: 3261 heap_increase: 0 stable_memory_increase: 0 greedy: calls: 1 - instructions: 4750 + instructions: 4078 heap_increase: 0 stable_memory_increase: 0 utxos_selection: calls: 1 - instructions: 414605 + instructions: 251118 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_6_10_btc: total: calls: 1 - instructions: 429262 + instructions: 264477 heap_increase: 0 stable_memory_increase: 0 scopes: build_unsigned_transaction: calls: 1 - instructions: 426679 + instructions: 261932 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_from_inputs: calls: 1 - instructions: 3830 + instructions: 3696 heap_increase: 0 stable_memory_increase: 0 greedy: calls: 1 - instructions: 13841 + instructions: 11848 heap_increase: 0 stable_memory_increase: 0 utxos_selection: calls: 1 - instructions: 420618 + instructions: 256059 heap_increase: 0 stable_memory_increase: 0 version: 0.6.0 diff --git a/rs/ethereum/cketh/minter/canbench/results.yml b/rs/ethereum/cketh/minter/canbench/results.yml index 40941a6ee58d..56cdb37e4c6f 100644 --- a/rs/ethereum/cketh/minter/canbench/results.yml +++ b/rs/ethereum/cketh/minter/canbench/results.yml @@ -2,8 +2,8 @@ benches: bench_post_upgrade: total: calls: 1 - instructions: 980351922 + instructions: 871401291 heap_increase: 222 stable_memory_increase: 0 scopes: {} -version: 0.4.0 +version: 0.6.0 diff --git a/rs/ledger_suite/icp/ledger/canbench_results/canbench.yml b/rs/ledger_suite/icp/ledger/canbench_results/canbench.yml index 2204a6abfc72..7981f13badfc 100644 --- a/rs/ledger_suite/icp/ledger/canbench_results/canbench.yml +++ b/rs/ledger_suite/icp/ledger/canbench_results/canbench.yml @@ -1,33 +1,34 @@ benches: bench_endpoints: total: - instructions: 14389105242 + calls: 1 + instructions: 14080482024 heap_increase: 62 stable_memory_increase: 256 scopes: icrc1_transfer: calls: 1 - instructions: 3067348446 + instructions: 3021096598 heap_increase: 24 stable_memory_increase: 0 icrc2_approve: calls: 1 - instructions: 4443523495 + instructions: 4368314342 heap_increase: 23 stable_memory_increase: 128 icrc2_transfer_from: calls: 1 - instructions: 6832774956 + instructions: 6647415101 heap_increase: 2 stable_memory_increase: 128 query_blocks: calls: 1 - instructions: 38072806 + instructions: 36745380 heap_increase: 13 stable_memory_increase: 0 query_encoded_blocks: calls: 1 - instructions: 7382133 + instructions: 6906203 heap_increase: 0 stable_memory_increase: 0 -version: 0.1.9 +version: 0.6.0 diff --git a/rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u256.yml b/rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u256.yml index df222fed930b..bf0697223bee 100644 --- a/rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u256.yml +++ b/rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u256.yml @@ -2,75 +2,75 @@ benches: bench_icrc1_transfers: total: calls: 1 - instructions: 53993760660 + instructions: 50461758453 heap_increase: 262 stable_memory_increase: 256 scopes: get_blocks: calls: 1 - instructions: 7797400 + instructions: 7386795 heap_increase: 0 stable_memory_increase: 0 icrc103_get_allowances: calls: 1 - instructions: 6489820 + instructions: 5253086 heap_increase: 0 stable_memory_increase: 0 icrc1_transfer: calls: 1 - instructions: 12848826453 + instructions: 12314243954 heap_increase: 31 stable_memory_increase: 0 icrc2_approve: calls: 1 - instructions: 19198042463 + instructions: 17759306752 heap_increase: 28 stable_memory_increase: 128 icrc2_transfer_from: calls: 1 - instructions: 21229878251 + instructions: 19659112629 heap_increase: 3 stable_memory_increase: 0 icrc3_get_blocks: calls: 1 - instructions: 9024197 + instructions: 8501965 heap_increase: 0 stable_memory_increase: 0 post_upgrade: calls: 1 - instructions: 351264419 + instructions: 379278521 heap_increase: 71 stable_memory_increase: 0 pre_upgrade: calls: 1 - instructions: 148654858 + instructions: 149965226 heap_increase: 129 stable_memory_increase: 128 upgrade: calls: 1 - instructions: 499922102 + instructions: 529246564 heap_increase: 200 stable_memory_increase: 128 bench_upgrade_baseline: total: calls: 1 - instructions: 8697316 + instructions: 8676171 heap_increase: 258 stable_memory_increase: 128 scopes: post_upgrade: calls: 1 - instructions: 8615796 + instructions: 8594612 heap_increase: 129 stable_memory_increase: 0 pre_upgrade: calls: 1 - instructions: 78596 + instructions: 78649 heap_increase: 129 stable_memory_increase: 128 upgrade: calls: 1 - instructions: 8696408 + instructions: 8675267 heap_increase: 258 stable_memory_increase: 128 version: 0.6.0 diff --git a/rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u64.yml b/rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u64.yml index b59ed6c94a80..ab212b11247b 100644 --- a/rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u64.yml +++ b/rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u64.yml @@ -2,75 +2,75 @@ benches: bench_icrc1_transfers: total: calls: 1 - instructions: 52409524630 + instructions: 48921992128 heap_increase: 264 stable_memory_increase: 256 scopes: get_blocks: calls: 1 - instructions: 7229189 + instructions: 6809877 heap_increase: 0 stable_memory_increase: 0 icrc103_get_allowances: calls: 1 - instructions: 5652189 + instructions: 4422093 heap_increase: 0 stable_memory_increase: 0 icrc1_transfer: calls: 1 - instructions: 12292977370 + instructions: 11770549225 heap_increase: 31 stable_memory_increase: 0 icrc2_approve: calls: 1 - instructions: 18636479096 + instructions: 17215599489 heap_increase: 28 stable_memory_increase: 128 icrc2_transfer_from: calls: 1 - instructions: 20771259711 + instructions: 19214930843 heap_increase: 3 stable_memory_increase: 0 icrc3_get_blocks: calls: 1 - instructions: 8418764 + instructions: 7886600 heap_increase: 0 stable_memory_increase: 0 post_upgrade: calls: 1 - instructions: 350951327 + instructions: 379101403 heap_increase: 73 stable_memory_increase: 0 pre_upgrade: calls: 1 - instructions: 148656482 + instructions: 149725949 heap_increase: 129 stable_memory_increase: 128 upgrade: calls: 1 - instructions: 499610706 + instructions: 528830239 heap_increase: 202 stable_memory_increase: 128 bench_upgrade_baseline: total: calls: 1 - instructions: 8698404 + instructions: 8677574 heap_increase: 258 stable_memory_increase: 128 scopes: post_upgrade: calls: 1 - instructions: 8615932 + instructions: 8595034 heap_increase: 129 stable_memory_increase: 0 pre_upgrade: calls: 1 - instructions: 79548 + instructions: 79630 heap_increase: 129 stable_memory_increase: 128 upgrade: calls: 1 - instructions: 8697496 + instructions: 8676670 heap_increase: 258 stable_memory_increase: 128 version: 0.6.0 diff --git a/rs/nns/governance/canbench/canbench_results.yml b/rs/nns/governance/canbench/canbench_results.yml index b5b3ab9b13ef..d5a00af6fe95 100644 --- a/rs/nns/governance/canbench/canbench_results.yml +++ b/rs/nns/governance/canbench/canbench_results.yml @@ -2,207 +2,207 @@ benches: add_neuron_active_maximum: total: calls: 1 - instructions: 65146334 + instructions: 66071308 heap_increase: 0 stable_memory_increase: 0 scopes: {} add_neuron_active_typical: total: calls: 1 - instructions: 4587403 + instructions: 4661728 heap_increase: 0 stable_memory_increase: 0 scopes: {} add_neuron_inactive_maximum: total: calls: 1 - instructions: 65146464 + instructions: 66071442 heap_increase: 0 stable_memory_increase: 0 scopes: {} add_neuron_inactive_typical: total: calls: 1 - instructions: 4587533 + instructions: 4661862 heap_increase: 0 stable_memory_increase: 0 scopes: {} cascading_vote_stable_everything: total: calls: 1 - instructions: 109049086 + instructions: 105925711 heap_increase: 0 stable_memory_increase: 128 scopes: {} centralized_following_all: total: calls: 1 - instructions: 42874726 + instructions: 42440190 heap_increase: 0 stable_memory_increase: 128 scopes: {} compute_ballots_for_new_proposal_with_stable_neurons: total: calls: 1 - instructions: 2450000 + instructions: 2298981 heap_increase: 0 stable_memory_increase: 256 scopes: {} distribute_rewards_with_stable_neurons: total: calls: 1 - instructions: 2867879 + instructions: 2802557 heap_increase: 0 stable_memory_increase: 256 scopes: {} draw_maturity_from_neurons_fund: total: calls: 1 - instructions: 7721586 + instructions: 7660543 heap_increase: 0 stable_memory_increase: 0 scopes: {} list_active_neurons_fund_neurons: total: calls: 1 - instructions: 2250175 + instructions: 2151873 heap_increase: 0 stable_memory_increase: 0 scopes: {} list_neurons: total: calls: 1 - instructions: 33996786 + instructions: 33226924 heap_increase: 4 stable_memory_increase: 0 scopes: {} list_neurons_by_subaccount: total: calls: 1 - instructions: 32708281 + instructions: 32151101 heap_increase: 0 stable_memory_increase: 0 scopes: {} list_proposals: total: calls: 1 - instructions: 78755 + instructions: 77018 heap_increase: 0 stable_memory_increase: 0 scopes: {} list_ready_to_spawn_neuron_ids: total: calls: 1 - instructions: 38460336 + instructions: 36311677 heap_increase: 0 stable_memory_increase: 0 scopes: {} neuron_data_validation: total: calls: 1 - instructions: 207683722 + instructions: 204545489 heap_increase: 0 stable_memory_increase: 0 scopes: {} neuron_metrics_calculation: total: calls: 1 - instructions: 3620000 + instructions: 3345556 heap_increase: 0 stable_memory_increase: 0 scopes: {} range_neurons_performance: total: calls: 1 - instructions: 50665169 + instructions: 49359273 heap_increase: 0 stable_memory_increase: 0 scopes: {} record_known_neuron_vote: total: calls: 1 - instructions: 185445 + instructions: 184487 heap_increase: 0 stable_memory_increase: 128 scopes: {} record_neuron_vote_known_neuron_voting_history: total: calls: 1 - instructions: 145092 + instructions: 144463 heap_increase: 0 stable_memory_increase: 0 scopes: {} single_vote_all: total: calls: 1 - instructions: 282284 + instructions: 280384 heap_increase: 0 stable_memory_increase: 128 scopes: {} unstake_maturity_of_dissolved_neurons: total: calls: 1 - instructions: 65734183 + instructions: 62918458 heap_increase: 0 stable_memory_increase: 0 scopes: list_neuron_ids: calls: 1 - instructions: 39871097 + instructions: 37654405 heap_increase: 0 stable_memory_increase: 0 unstake_maturity: calls: 1 - instructions: 25860900 + instructions: 25261877 heap_increase: 0 stable_memory_increase: 0 voting_power_snapshots_is_latest_snapshot_a_spike_false: total: calls: 1 - instructions: 30926 + instructions: 30074 heap_increase: 0 stable_memory_increase: 0 scopes: {} voting_power_snapshots_is_latest_snapshot_a_spike_true: total: calls: 1 - instructions: 30937 + instructions: 30085 heap_increase: 0 stable_memory_increase: 0 scopes: {} voting_power_snapshots_latest_snapshot_timestamp_seconds: total: calls: 1 - instructions: 7734 + instructions: 7605 heap_increase: 0 stable_memory_increase: 0 scopes: {} with_neuron_mut_all_sections_maximum: total: calls: 1 - instructions: 4254197 + instructions: 4121078 heap_increase: 0 stable_memory_increase: 0 scopes: {} with_neuron_mut_all_sections_typical: total: calls: 1 - instructions: 856844 + instructions: 849920 heap_increase: 0 stable_memory_increase: 0 scopes: {} with_neuron_mut_main_section_maximum: total: calls: 1 - instructions: 2300114 + instructions: 2240724 heap_increase: 0 stable_memory_increase: 0 scopes: {} with_neuron_mut_main_section_typical: total: calls: 1 - instructions: 396234 + instructions: 386753 heap_increase: 0 stable_memory_increase: 0 scopes: {} -version: 0.4.1 +version: 0.6.0 diff --git a/rs/registry/canister/canbench/canbench_results.yml b/rs/registry/canister/canbench/canbench_results.yml index 0d98987e3eef..d4c0f989bf5c 100644 --- a/rs/registry/canister/canbench/canbench_results.yml +++ b/rs/registry/canister/canbench/canbench_results.yml @@ -2,129 +2,129 @@ benches: get_subnet_for_canister_100_times_100: total: calls: 1 - instructions: 31052919 + instructions: 28451333 heap_increase: 0 stable_memory_increase: 0 scopes: {} get_subnet_for_canister_100_times_10k: total: calls: 1 - instructions: 702793228 + instructions: 685738099 heap_increase: 0 stable_memory_increase: 0 scopes: {} get_subnet_for_canister_100_times_1k: total: calls: 1 - instructions: 91803671 + instructions: 87917147 heap_increase: 0 stable_memory_increase: 0 scopes: {} measure_routing_table_invariant_checks_shards_and_unsharded: total: calls: 1 - instructions: 267213620 + instructions: 230349805 heap_increase: 138 stable_memory_increase: 0 scopes: {} measure_snapshot_creation_with_1000_individual_entries: total: calls: 1 - instructions: 20682680 + instructions: 20676123 heap_increase: 2 stable_memory_increase: 0 scopes: {} measure_snapshot_creation_with_100_000_individual_entries: total: calls: 1 - instructions: 3581447939 + instructions: 3580780342 heap_increase: 177 stable_memory_increase: 0 scopes: {} measure_snapshot_creation_with_100_segments_of_1000_entries: total: calls: 1 - instructions: 6435424 + instructions: 6435358 heap_increase: 30 stable_memory_increase: 0 scopes: {} measure_snapshot_creation_with_1_segment_of_1000_entries: total: calls: 1 - instructions: 53952 + instructions: 53947 heap_increase: 0 stable_memory_increase: 0 scopes: {} migrate_canisters_10_times_100: total: calls: 1 - instructions: 153239653 + instructions: 137681900 heap_increase: 0 stable_memory_increase: 0 scopes: {} migrate_canisters_10_times_10k: total: calls: 1 - instructions: 10287033153 + instructions: 8982572872 heap_increase: 0 stable_memory_increase: 0 scopes: {} migrate_canisters_10_times_1k: total: calls: 1 - instructions: 1022669560 + instructions: 902162224 heap_increase: 3 stable_memory_increase: 0 scopes: {} upgrade_with_routing_table_100: total: calls: 1 - instructions: 190189040 + instructions: 184182162 heap_increase: 7 stable_memory_increase: 0 scopes: post_upgrade: calls: 1 - instructions: 189307066 + instructions: 183301295 heap_increase: 4 stable_memory_increase: 0 pre_upgrade: calls: 1 - instructions: 671039 + instructions: 669950 heap_increase: 3 stable_memory_increase: 0 upgrade_with_routing_table_10k: total: calls: 1 - instructions: 5624394843 + instructions: 5456990652 heap_increase: 342 stable_memory_increase: 0 scopes: post_upgrade: calls: 1 - instructions: 5602274973 + instructions: 5434870234 heap_increase: 217 stable_memory_increase: 0 pre_upgrade: calls: 1 - instructions: 16604363 + instructions: 16605582 heap_increase: 125 stable_memory_increase: 0 upgrade_with_routing_table_1k: total: calls: 1 - instructions: 690060016 + instructions: 669202923 heap_increase: 40 stable_memory_increase: 0 scopes: post_upgrade: calls: 1 - instructions: 687183232 + instructions: 666327168 heap_increase: 25 stable_memory_increase: 0 pre_upgrade: calls: 1 - instructions: 2202916 + instructions: 2201963 heap_increase: 15 stable_memory_increase: 0 -version: 0.4.1 +version: 0.6.0 diff --git a/rust-toolchain.toml b/rust-toolchain.toml index 33843c895e62..9a2610db55d0 100644 --- a/rust-toolchain.toml +++ b/rust-toolchain.toml @@ -1,5 +1,5 @@ [toolchain] -channel = "1.93.1" +channel = "1.95.0" targets = ["wasm32-unknown-unknown"] profile = "default" components = [] From 84b928cc780f391a0b8e31b08487942e1a6b6812 Mon Sep 17 00:00:00 2001 From: Martin Raszyk Date: Wed, 8 Jul 2026 14:01:20 +0000 Subject: [PATCH 02/13] enable bazel test all --- .github/workflows/ci-main.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci-main.yml b/.github/workflows/ci-main.yml index 21b329f62388..45a7a638387a 100644 --- a/.github/workflows/ci-main.yml +++ b/.github/workflows/ci-main.yml @@ -296,9 +296,9 @@ jobs: bazel_args='${{ steps.infer-bazel-args.outputs.bazel-args }}' test_targets="$HOME/.cache/bazel-targets/test-targets" - #if [ -s "$test_targets" ]; then # bazel errors out if no test targets are listed - # eval "bazel test $bazel_args --target_pattern_file=$test_targets" - #fi + if [ -s "$test_targets" ]; then # bazel errors out if no test targets are listed + eval "bazel test $bazel_args --target_pattern_file=$test_targets" + fi # Build & upload arm64-{linux,darwin} binaries, # build the entire codebase on arm64-darwin, From 8f0a57340295d966d8849fe7a0d111ccfb682516 Mon Sep 17 00:00:00 2001 From: Martin Raszyk Date: Wed, 8 Jul 2026 15:31:53 +0000 Subject: [PATCH 03/13] test: adjust wasm size limits and subnet-splitting estimates for rustc 1.95.0 The rustc 1.95.0 bump produces slightly larger wasm binaries and shifts deterministic execution estimates. Bump the compressed wasm size limits for ic-ckbtc-minter, sns-governance, and sns-swap, and update the hard-coded post-split load estimates in the subnet_splitting integration test. Co-Authored-By: Claude Opus 4.8 (1M context) --- publish/canisters/BUILD.bazel | 3 ++- .../tests/integration_tests.rs | 20 +++++++++---------- rs/sns/sns.bzl | 6 +++--- 3 files changed, 15 insertions(+), 14 deletions(-) diff --git a/publish/canisters/BUILD.bazel b/publish/canisters/BUILD.bazel index b00fdbcc961d..130388e23198 100644 --- a/publish/canisters/BUILD.bazel +++ b/publish/canisters/BUILD.bazel @@ -86,7 +86,8 @@ CANISTERS_MAX_SIZE_COMPRESSED_E5_BYTES = { # Size when constraint addded: 447_593 bytes "ic-btc-checker.wasm.gz": 6, # Size when constraint addded: 802_894 bytes - "ic-ckbtc-minter.wasm.gz": 9, + # Size is currently at 923_414 bytes. + "ic-ckbtc-minter.wasm.gz": 10, # Size when constraint addded: 1_230_630 bytes "ic-cketh-minter.wasm.gz": 13, # The orchestrator needs to embed 3 wasms at compile time diff --git a/rs/recovery/subnet_splitting/tests/integration_tests.rs b/rs/recovery/subnet_splitting/tests/integration_tests.rs index 6c98280e3ae0..20577e79ce8b 100644 --- a/rs/recovery/subnet_splitting/tests/integration_tests.rs +++ b/rs/recovery/subnet_splitting/tests/integration_tests.rs @@ -175,15 +175,15 @@ fn load_metrics_e2e_test() { // Accept up to 10% error. The precise values are not important here and they're very sensitive // to the changes to the replicated state / execution. It's mostly a sanity check that the // returned values are not too ridiculous and they might have to be updated once in a while. - assert_near!(states_sizes_bytes.source, 4626905, 0.1); - assert_near!(states_sizes_bytes.destination, 4626909, 0.1); - assert_near!(instructions_executed.source, 8330575, 0.1); - assert_near!(instructions_executed.destination, 8336259, 0.1); + assert_near!(states_sizes_bytes.source, 4607286, 0.1); + assert_near!(states_sizes_bytes.destination, 4607278, 0.1); + assert_near!(instructions_executed.source, 8290024, 0.1); + assert_near!(instructions_executed.destination, 8296082, 0.1); assert_eq!( ingress_messages_executed, Estimates { - source: 20, - destination: 19, + source: 19, + destination: 20, } ); assert_eq!( @@ -196,8 +196,8 @@ fn load_metrics_e2e_test() { assert_eq!( local_subnet_messages_executed_upper_bound, Estimates { - source: 15, - destination: 13, + source: 13, + destination: 15, } ); assert_eq!( @@ -210,8 +210,8 @@ fn load_metrics_e2e_test() { assert_eq!( heartbeats_and_global_timers_executed, Estimates { - source: 315, - destination: 379, + source: 366, + destination: 328, } ); // Check if the split finder found a split satisfying the load constraints diff --git a/rs/sns/sns.bzl b/rs/sns/sns.bzl index a2c277a61a19..ed5e5af6e78f 100644 --- a/rs/sns/sns.bzl +++ b/rs/sns/sns.bzl @@ -14,8 +14,8 @@ but other things could be added here later. # amount of growth happens. CANISTER_NAME_TO_MAX_COMPRESSED_WASM_SIZE_E5_BYTES = { - "sns-governance-canister.wasm.gz": 19, - "sns-governance-canister_test.wasm.gz": 20, + "sns-governance-canister.wasm.gz": 23, + "sns-governance-canister_test.wasm.gz": 24, "sns-root-canister.wasm.gz": 5, - "sns-swap-canister.wasm.gz": 8, + "sns-swap-canister.wasm.gz": 10, } From 11e20bc463efd1f588beca7a295325ea10407659 Mon Sep 17 00:00:00 2001 From: IDX GitHub Automation <> Date: Wed, 8 Jul 2026 19:53:33 +0000 Subject: [PATCH 04/13] Updating container images to tag: 0b686a486b72ba188d46146139fce699140be7f49b5528e73804be39740cfe5f ic-build: sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 ic-dev: sha256:60cf67322e87bd9a6ce425ec73811014f9a6280d84db6e256c1eda720790a491 --- .devcontainer/devcontainer.json | 2 +- .github/workflows/api-bn-recovery-test.yml | 2 +- .github/workflows/ci-main.yml | 2 +- .github/workflows/ci-pr-only.yml | 2 +- .github/workflows/container-api-bn-recovery.yml | 2 +- .github/workflows/container-scan-nightly.yml | 2 +- .github/workflows/local-system-tests.yml | 2 +- .github/workflows/pocket-ic-tests-windows.yml | 2 +- .github/workflows/rate-limits-backend-release.yml | 2 +- .github/workflows/release-testing.yml | 2 +- .github/workflows/rosetta-release.yml | 2 +- .github/workflows/salt-sharing-canister-release.yml | 2 +- .github/workflows/schedule-daily.yml | 2 +- .github/workflows/schedule-rust-bench.yml | 2 +- .github/workflows/system-tests-benchmarks-nightly.yml | 2 +- .github/workflows/update-mainnet-canister-revisions.yaml | 2 +- ci/container/TAG | 2 +- 17 files changed, 17 insertions(+), 17 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 490ad501d404..4d31994fb2af 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,5 +1,5 @@ { - "image": "ghcr.io/dfinity/ic-dev@sha256:87894a45bc67db8f923c4ea8f7a194d982d5c514f205451fba1f65d8f745d97d", + "image": "ghcr.io/dfinity/ic-dev@sha256:60cf67322e87bd9a6ce425ec73811014f9a6280d84db6e256c1eda720790a491", "remoteUser": "ubuntu", "privileged": true, "runArgs": [ diff --git a/.github/workflows/api-bn-recovery-test.yml b/.github/workflows/api-bn-recovery-test.yml index 53cf4b97b1fa..4694f881bf2b 100644 --- a/.github/workflows/api-bn-recovery-test.yml +++ b/.github/workflows/api-bn-recovery-test.yml @@ -22,7 +22,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a + image: ghcr.io/dfinity/ic-build@sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/home/buildifier/.local/share/containers" diff --git a/.github/workflows/ci-main.yml b/.github/workflows/ci-main.yml index 45a7a638387a..c051a5c35309 100644 --- a/.github/workflows/ci-main.yml +++ b/.github/workflows/ci-main.yml @@ -33,7 +33,7 @@ jobs: runs-on: &dind-large-setup labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a + image: ghcr.io/dfinity/ic-build@sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 90 diff --git a/.github/workflows/ci-pr-only.yml b/.github/workflows/ci-pr-only.yml index f016092c4325..0fd562220a7d 100644 --- a/.github/workflows/ci-pr-only.yml +++ b/.github/workflows/ci-pr-only.yml @@ -37,7 +37,7 @@ jobs: runs-on: &dind-small-setup labels: dind-small container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a + image: ghcr.io/dfinity/ic-build@sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 options: >- -e NODE_NAME --mount type=tmpfs,target="/tmp/containers" steps: diff --git a/.github/workflows/container-api-bn-recovery.yml b/.github/workflows/container-api-bn-recovery.yml index 4ad9c73b8343..39709d14cfca 100644 --- a/.github/workflows/container-api-bn-recovery.yml +++ b/.github/workflows/container-api-bn-recovery.yml @@ -28,7 +28,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a + image: ghcr.io/dfinity/ic-build@sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/home/buildifier/.local/share/containers" diff --git a/.github/workflows/container-scan-nightly.yml b/.github/workflows/container-scan-nightly.yml index 5dfc4fc33fc4..c9e0f9579da8 100644 --- a/.github/workflows/container-scan-nightly.yml +++ b/.github/workflows/container-scan-nightly.yml @@ -12,7 +12,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a + image: ghcr.io/dfinity/ic-build@sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 60 diff --git a/.github/workflows/local-system-tests.yml b/.github/workflows/local-system-tests.yml index 6d603ec48244..0bed35c06462 100644 --- a/.github/workflows/local-system-tests.yml +++ b/.github/workflows/local-system-tests.yml @@ -19,7 +19,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a + image: ghcr.io/dfinity/ic-build@sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 600 diff --git a/.github/workflows/pocket-ic-tests-windows.yml b/.github/workflows/pocket-ic-tests-windows.yml index dca3df25745c..d709b7045841 100644 --- a/.github/workflows/pocket-ic-tests-windows.yml +++ b/.github/workflows/pocket-ic-tests-windows.yml @@ -45,7 +45,7 @@ jobs: bazel-build-pocket-ic: name: Bazel Build PocketIC container: - image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a + image: ghcr.io/dfinity/ic-build@sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 90 diff --git a/.github/workflows/rate-limits-backend-release.yml b/.github/workflows/rate-limits-backend-release.yml index 98051c49f519..7c8e702f6a46 100644 --- a/.github/workflows/rate-limits-backend-release.yml +++ b/.github/workflows/rate-limits-backend-release.yml @@ -32,7 +32,7 @@ jobs: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a + image: ghcr.io/dfinity/ic-build@sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" diff --git a/.github/workflows/release-testing.yml b/.github/workflows/release-testing.yml index bbf002803d9d..9c621da42e07 100644 --- a/.github/workflows/release-testing.yml +++ b/.github/workflows/release-testing.yml @@ -35,7 +35,7 @@ jobs: group: dm1 labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a + image: ghcr.io/dfinity/ic-build@sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 180 diff --git a/.github/workflows/rosetta-release.yml b/.github/workflows/rosetta-release.yml index 0e75e9ae0279..4e85f7350ab7 100644 --- a/.github/workflows/rosetta-release.yml +++ b/.github/workflows/rosetta-release.yml @@ -22,7 +22,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a + image: ghcr.io/dfinity/ic-build@sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" environment: DockerHub diff --git a/.github/workflows/salt-sharing-canister-release.yml b/.github/workflows/salt-sharing-canister-release.yml index d3704bb67dff..6d58eaedf3f1 100644 --- a/.github/workflows/salt-sharing-canister-release.yml +++ b/.github/workflows/salt-sharing-canister-release.yml @@ -32,7 +32,7 @@ jobs: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a + image: ghcr.io/dfinity/ic-build@sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" diff --git a/.github/workflows/schedule-daily.yml b/.github/workflows/schedule-daily.yml index bb75cfd01b04..4cd358a8a596 100644 --- a/.github/workflows/schedule-daily.yml +++ b/.github/workflows/schedule-daily.yml @@ -14,7 +14,7 @@ jobs: runs-on: &dind-large-setup labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a + image: ghcr.io/dfinity/ic-build@sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 720 # 12 hours diff --git a/.github/workflows/schedule-rust-bench.yml b/.github/workflows/schedule-rust-bench.yml index 6dc927d98a16..6561f4949b53 100644 --- a/.github/workflows/schedule-rust-bench.yml +++ b/.github/workflows/schedule-rust-bench.yml @@ -24,7 +24,7 @@ jobs: # see linux-x86-64 runner group labels: rust-benchmarks container: - image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a + image: ghcr.io/dfinity/ic-build@sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 # running on bare metal machine using ubuntu user options: --user ubuntu --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 720 # 12 hours diff --git a/.github/workflows/system-tests-benchmarks-nightly.yml b/.github/workflows/system-tests-benchmarks-nightly.yml index 2a4293d1b26e..86a2f8201069 100644 --- a/.github/workflows/system-tests-benchmarks-nightly.yml +++ b/.github/workflows/system-tests-benchmarks-nightly.yml @@ -17,7 +17,7 @@ jobs: group: dm1 labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a + image: ghcr.io/dfinity/ic-build@sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 480 diff --git a/.github/workflows/update-mainnet-canister-revisions.yaml b/.github/workflows/update-mainnet-canister-revisions.yaml index 7069154717c6..ec96b4953087 100644 --- a/.github/workflows/update-mainnet-canister-revisions.yaml +++ b/.github/workflows/update-mainnet-canister-revisions.yaml @@ -25,7 +25,7 @@ jobs: labels: dind-small environment: CREATE_PR container: - image: ghcr.io/dfinity/ic-build@sha256:775c24bd4e8273d08b15cee62d9beb2d888a63b8b20fe5c58dcd18e87f44ef1a + image: ghcr.io/dfinity/ic-build@sha256:83e2d52e2b6b990ecd81fc27d26312c456867220f7e0667022dd7999718ab534 options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" env: diff --git a/ci/container/TAG b/ci/container/TAG index e7769bd66da0..4bb9a1db85c6 100644 --- a/ci/container/TAG +++ b/ci/container/TAG @@ -1 +1 @@ -89a837aa8518f5ee070ef24f8e0c0197a9a5b0c3545ef1477f7b71c863030d51 +0b686a486b72ba188d46146139fce699140be7f49b5528e73804be39740cfe5f From 912e8bb8a6052fae7dc43b63b7ad40c3dec1c4f5 Mon Sep 17 00:00:00 2001 From: Martin Raszyk Date: Thu, 9 Jul 2026 05:15:17 +0000 Subject: [PATCH 05/13] chore: refresh canbench results Re-run all canbench suites whose results files changed on this branch, persisting fresh benchmark numbers. Co-Authored-By: Claude Opus 4.8 (1M context) --- rs/bitcoin/ckbtc/minter/canbench/results.yml | 40 +++++++------- rs/ethereum/cketh/minter/canbench/results.yml | 2 +- .../icp/ledger/canbench_results/canbench.yml | 8 +-- .../ledger/canbench_results/canbench_u256.yml | 20 +++---- .../ledger/canbench_results/canbench_u64.yml | 26 ++++----- .../governance/canbench/canbench_results.yml | 54 +++++++++---------- 6 files changed, 75 insertions(+), 75 deletions(-) diff --git a/rs/bitcoin/ckbtc/minter/canbench/results.yml b/rs/bitcoin/ckbtc/minter/canbench/results.yml index 458aeaa84c15..3edff5204bef 100644 --- a/rs/bitcoin/ckbtc/minter/canbench/results.yml +++ b/rs/bitcoin/ckbtc/minter/canbench/results.yml @@ -2,13 +2,13 @@ benches: build_estimate_retrieve_btc_fee_1_50k_sats: total: calls: 1 - instructions: 255972 + instructions: 255974 heap_increase: 0 stable_memory_increase: 0 scopes: build_unsigned_transaction_from_inputs: calls: 1 - instructions: 3261 + instructions: 3263 heap_increase: 0 stable_memory_increase: 0 greedy: @@ -24,18 +24,18 @@ benches: build_unsigned_transaction_1_50k_sats: total: calls: 1 - instructions: 258016 + instructions: 258018 heap_increase: 0 stable_memory_increase: 0 scopes: build_unsigned_transaction: calls: 1 - instructions: 255471 + instructions: 255473 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_from_inputs: calls: 1 - instructions: 3261 + instructions: 3263 heap_increase: 0 stable_memory_increase: 0 greedy: @@ -51,18 +51,18 @@ benches: build_unsigned_transaction_2_100k_sats: total: calls: 1 - instructions: 258062 + instructions: 258064 heap_increase: 0 stable_memory_increase: 0 scopes: build_unsigned_transaction: calls: 1 - instructions: 255517 + instructions: 255519 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_from_inputs: calls: 1 - instructions: 3261 + instructions: 3263 heap_increase: 0 stable_memory_increase: 0 greedy: @@ -78,18 +78,18 @@ benches: build_unsigned_transaction_3_1m_sats: total: calls: 1 - instructions: 258138 + instructions: 258140 heap_increase: 0 stable_memory_increase: 0 scopes: build_unsigned_transaction: calls: 1 - instructions: 255593 + instructions: 255595 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_from_inputs: calls: 1 - instructions: 3261 + instructions: 3263 heap_increase: 0 stable_memory_increase: 0 greedy: @@ -105,18 +105,18 @@ benches: build_unsigned_transaction_4_10m_sats: total: calls: 1 - instructions: 259101 + instructions: 259103 heap_increase: 0 stable_memory_increase: 0 scopes: build_unsigned_transaction: calls: 1 - instructions: 256556 + instructions: 256558 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_from_inputs: calls: 1 - instructions: 3261 + instructions: 3263 heap_increase: 0 stable_memory_increase: 0 greedy: @@ -132,18 +132,18 @@ benches: build_unsigned_transaction_5_1_btc: total: calls: 1 - instructions: 259101 + instructions: 259103 heap_increase: 0 stable_memory_increase: 0 scopes: build_unsigned_transaction: calls: 1 - instructions: 256556 + instructions: 256558 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_from_inputs: calls: 1 - instructions: 3261 + instructions: 3263 heap_increase: 0 stable_memory_increase: 0 greedy: @@ -159,18 +159,18 @@ benches: build_unsigned_transaction_6_10_btc: total: calls: 1 - instructions: 264477 + instructions: 264479 heap_increase: 0 stable_memory_increase: 0 scopes: build_unsigned_transaction: calls: 1 - instructions: 261932 + instructions: 261934 heap_increase: 0 stable_memory_increase: 0 build_unsigned_transaction_from_inputs: calls: 1 - instructions: 3696 + instructions: 3698 heap_increase: 0 stable_memory_increase: 0 greedy: diff --git a/rs/ethereum/cketh/minter/canbench/results.yml b/rs/ethereum/cketh/minter/canbench/results.yml index 56cdb37e4c6f..bc7fbf6a3543 100644 --- a/rs/ethereum/cketh/minter/canbench/results.yml +++ b/rs/ethereum/cketh/minter/canbench/results.yml @@ -2,7 +2,7 @@ benches: bench_post_upgrade: total: calls: 1 - instructions: 871401291 + instructions: 871462631 heap_increase: 222 stable_memory_increase: 0 scopes: {} diff --git a/rs/ledger_suite/icp/ledger/canbench_results/canbench.yml b/rs/ledger_suite/icp/ledger/canbench_results/canbench.yml index 7981f13badfc..d2b8ee7a80ad 100644 --- a/rs/ledger_suite/icp/ledger/canbench_results/canbench.yml +++ b/rs/ledger_suite/icp/ledger/canbench_results/canbench.yml @@ -2,7 +2,7 @@ benches: bench_endpoints: total: calls: 1 - instructions: 14080482024 + instructions: 14080682018 heap_increase: 62 stable_memory_increase: 256 scopes: @@ -13,7 +13,7 @@ benches: stable_memory_increase: 0 icrc2_approve: calls: 1 - instructions: 4368314342 + instructions: 4368514342 heap_increase: 23 stable_memory_increase: 128 icrc2_transfer_from: @@ -23,12 +23,12 @@ benches: stable_memory_increase: 128 query_blocks: calls: 1 - instructions: 36745380 + instructions: 36745377 heap_increase: 13 stable_memory_increase: 0 query_encoded_blocks: calls: 1 - instructions: 6906203 + instructions: 6906200 heap_increase: 0 stable_memory_increase: 0 version: 0.6.0 diff --git a/rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u256.yml b/rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u256.yml index bf0697223bee..2e572b965dba 100644 --- a/rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u256.yml +++ b/rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u256.yml @@ -2,13 +2,13 @@ benches: bench_icrc1_transfers: total: calls: 1 - instructions: 50461758453 + instructions: 50461758467 heap_increase: 262 stable_memory_increase: 256 scopes: get_blocks: calls: 1 - instructions: 7386795 + instructions: 7386792 heap_increase: 0 stable_memory_increase: 0 icrc103_get_allowances: @@ -33,44 +33,44 @@ benches: stable_memory_increase: 0 icrc3_get_blocks: calls: 1 - instructions: 8501965 + instructions: 8501968 heap_increase: 0 stable_memory_increase: 0 post_upgrade: calls: 1 - instructions: 379278521 + instructions: 379278527 heap_increase: 71 stable_memory_increase: 0 pre_upgrade: calls: 1 - instructions: 149965226 + instructions: 149965234 heap_increase: 129 stable_memory_increase: 128 upgrade: calls: 1 - instructions: 529246564 + instructions: 529246578 heap_increase: 200 stable_memory_increase: 128 bench_upgrade_baseline: total: calls: 1 - instructions: 8676171 + instructions: 8676185 heap_increase: 258 stable_memory_increase: 128 scopes: post_upgrade: calls: 1 - instructions: 8594612 + instructions: 8594618 heap_increase: 129 stable_memory_increase: 0 pre_upgrade: calls: 1 - instructions: 78649 + instructions: 78657 heap_increase: 129 stable_memory_increase: 128 upgrade: calls: 1 - instructions: 8675267 + instructions: 8675281 heap_increase: 258 stable_memory_increase: 128 version: 0.6.0 diff --git a/rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u64.yml b/rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u64.yml index ab212b11247b..8f7fc234a29a 100644 --- a/rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u64.yml +++ b/rs/ledger_suite/icrc1/ledger/canbench_results/canbench_u64.yml @@ -2,13 +2,13 @@ benches: bench_icrc1_transfers: total: calls: 1 - instructions: 48921992128 + instructions: 48922082364 heap_increase: 264 stable_memory_increase: 256 scopes: get_blocks: calls: 1 - instructions: 6809877 + instructions: 6809874 heap_increase: 0 stable_memory_increase: 0 icrc103_get_allowances: @@ -18,59 +18,59 @@ benches: stable_memory_increase: 0 icrc1_transfer: calls: 1 - instructions: 11770549225 + instructions: 11770579222 heap_increase: 31 stable_memory_increase: 0 icrc2_approve: calls: 1 - instructions: 17215599489 + instructions: 17215629489 heap_increase: 28 stable_memory_increase: 128 icrc2_transfer_from: calls: 1 - instructions: 19214930843 + instructions: 19214960843 heap_increase: 3 stable_memory_increase: 0 icrc3_get_blocks: calls: 1 - instructions: 7886600 + instructions: 7886603 heap_increase: 0 stable_memory_increase: 0 post_upgrade: calls: 1 - instructions: 379101403 + instructions: 379101409 heap_increase: 73 stable_memory_increase: 0 pre_upgrade: calls: 1 - instructions: 149725949 + instructions: 149725882 heap_increase: 129 stable_memory_increase: 128 upgrade: calls: 1 - instructions: 528830239 + instructions: 528830178 heap_increase: 202 stable_memory_increase: 128 bench_upgrade_baseline: total: calls: 1 - instructions: 8677574 + instructions: 8677513 heap_increase: 258 stable_memory_increase: 128 scopes: post_upgrade: calls: 1 - instructions: 8595034 + instructions: 8595040 heap_increase: 129 stable_memory_increase: 0 pre_upgrade: calls: 1 - instructions: 79630 + instructions: 79563 heap_increase: 129 stable_memory_increase: 128 upgrade: calls: 1 - instructions: 8676670 + instructions: 8676609 heap_increase: 258 stable_memory_increase: 128 version: 0.6.0 diff --git a/rs/nns/governance/canbench/canbench_results.yml b/rs/nns/governance/canbench/canbench_results.yml index d5a00af6fe95..5eae6d9acd7f 100644 --- a/rs/nns/governance/canbench/canbench_results.yml +++ b/rs/nns/governance/canbench/canbench_results.yml @@ -2,158 +2,158 @@ benches: add_neuron_active_maximum: total: calls: 1 - instructions: 66071308 + instructions: 65532881 heap_increase: 0 stable_memory_increase: 0 scopes: {} add_neuron_active_typical: total: calls: 1 - instructions: 4661728 + instructions: 4622795 heap_increase: 0 stable_memory_increase: 0 scopes: {} add_neuron_inactive_maximum: total: calls: 1 - instructions: 66071442 + instructions: 65533015 heap_increase: 0 stable_memory_increase: 0 scopes: {} add_neuron_inactive_typical: total: calls: 1 - instructions: 4661862 + instructions: 4622929 heap_increase: 0 stable_memory_increase: 0 scopes: {} cascading_vote_stable_everything: total: calls: 1 - instructions: 105925711 + instructions: 105468504 heap_increase: 0 stable_memory_increase: 128 scopes: {} centralized_following_all: total: calls: 1 - instructions: 42440190 + instructions: 42268514 heap_increase: 0 stable_memory_increase: 128 scopes: {} compute_ballots_for_new_proposal_with_stable_neurons: total: calls: 1 - instructions: 2298981 + instructions: 2351436 heap_increase: 0 stable_memory_increase: 256 scopes: {} distribute_rewards_with_stable_neurons: total: calls: 1 - instructions: 2802557 + instructions: 2802357 heap_increase: 0 stable_memory_increase: 256 scopes: {} draw_maturity_from_neurons_fund: total: calls: 1 - instructions: 7660543 + instructions: 7608871 heap_increase: 0 stable_memory_increase: 0 scopes: {} list_active_neurons_fund_neurons: total: calls: 1 - instructions: 2151873 + instructions: 2144873 heap_increase: 0 stable_memory_increase: 0 scopes: {} list_neurons: total: calls: 1 - instructions: 33226924 + instructions: 33022690 heap_increase: 4 stable_memory_increase: 0 scopes: {} list_neurons_by_subaccount: total: calls: 1 - instructions: 32151101 + instructions: 31951401 heap_increase: 0 stable_memory_increase: 0 scopes: {} list_proposals: total: calls: 1 - instructions: 77018 + instructions: 77179 heap_increase: 0 stable_memory_increase: 0 scopes: {} list_ready_to_spawn_neuron_ids: total: calls: 1 - instructions: 36311677 + instructions: 36203641 heap_increase: 0 stable_memory_increase: 0 scopes: {} neuron_data_validation: total: calls: 1 - instructions: 204545489 + instructions: 204368649 heap_increase: 0 stable_memory_increase: 0 scopes: {} neuron_metrics_calculation: total: calls: 1 - instructions: 3345556 + instructions: 3341956 heap_increase: 0 stable_memory_increase: 0 scopes: {} range_neurons_performance: total: calls: 1 - instructions: 49359273 + instructions: 48971073 heap_increase: 0 stable_memory_increase: 0 scopes: {} record_known_neuron_vote: total: calls: 1 - instructions: 184487 + instructions: 183667 heap_increase: 0 stable_memory_increase: 128 scopes: {} record_neuron_vote_known_neuron_voting_history: total: calls: 1 - instructions: 144463 + instructions: 143711 heap_increase: 0 stable_memory_increase: 0 scopes: {} single_vote_all: total: calls: 1 - instructions: 280384 + instructions: 279073 heap_increase: 0 stable_memory_increase: 128 scopes: {} unstake_maturity_of_dissolved_neurons: total: calls: 1 - instructions: 62918458 + instructions: 62759802 heap_increase: 0 stable_memory_increase: 0 scopes: list_neuron_ids: calls: 1 - instructions: 37654405 + instructions: 37542877 heap_increase: 0 stable_memory_increase: 0 unstake_maturity: calls: 1 - instructions: 25261877 + instructions: 25214749 heap_increase: 0 stable_memory_increase: 0 voting_power_snapshots_is_latest_snapshot_a_spike_false: @@ -180,28 +180,28 @@ benches: with_neuron_mut_all_sections_maximum: total: calls: 1 - instructions: 4121078 + instructions: 4094115 heap_increase: 0 stable_memory_increase: 0 scopes: {} with_neuron_mut_all_sections_typical: total: calls: 1 - instructions: 849920 + instructions: 845075 heap_increase: 0 stable_memory_increase: 0 scopes: {} with_neuron_mut_main_section_maximum: total: calls: 1 - instructions: 2240724 + instructions: 2227323 heap_increase: 0 stable_memory_increase: 0 scopes: {} with_neuron_mut_main_section_typical: total: calls: 1 - instructions: 386753 + instructions: 385032 heap_increase: 0 stable_memory_increase: 0 scopes: {} From 6325c0d19cd3da552912ed9adeb2e739e7e41857 Mon Sep 17 00:00:00 2001 From: IDX GitHub Automation <> Date: Thu, 9 Jul 2026 17:58:17 +0000 Subject: [PATCH 06/13] Updating container images to tag: baf0cbe760d16c66c8294e2c5b8edc59a9527967070fea70acf17115b4be8a34 ic-build: sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b ic-dev: sha256:ef4e171fcb98170f24d4163a3a3cefff11a380a603388f467add619c45f610a4 --- .devcontainer/devcontainer.json | 2 +- .github/workflows/api-bn-recovery-test.yml | 2 +- .github/workflows/ci-main.yml | 2 +- .github/workflows/ci-pr-only.yml | 2 +- .github/workflows/container-api-bn-recovery.yml | 2 +- .github/workflows/container-scan-nightly.yml | 2 +- .github/workflows/local-system-tests.yml | 2 +- .github/workflows/pocket-ic-tests-windows.yml | 2 +- .github/workflows/rate-limits-backend-release.yml | 2 +- .github/workflows/release-testing.yml | 2 +- .github/workflows/rosetta-release.yml | 2 +- .github/workflows/salt-sharing-canister-release.yml | 2 +- .github/workflows/schedule-daily-bare-metal.yml | 2 +- .github/workflows/schedule-daily.yml | 2 +- .github/workflows/schedule-rust-bench.yml | 2 +- .github/workflows/system-tests-benchmarks-nightly.yml | 2 +- .github/workflows/update-mainnet-canister-revisions.yaml | 2 +- ci/container/TAG | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 91fbc82c17e1..e83018808063 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,5 +1,5 @@ { - "image": "ghcr.io/dfinity/ic-dev@sha256:877c1e0c4426d9542f6ff88b419be78fd9d7d235d51c2996246d012b9e4a43dc", + "image": "ghcr.io/dfinity/ic-dev@sha256:ef4e171fcb98170f24d4163a3a3cefff11a380a603388f467add619c45f610a4", "remoteUser": "ubuntu", "privileged": true, "runArgs": [ diff --git a/.github/workflows/api-bn-recovery-test.yml b/.github/workflows/api-bn-recovery-test.yml index 30c54a3f3822..7f49f0b50030 100644 --- a/.github/workflows/api-bn-recovery-test.yml +++ b/.github/workflows/api-bn-recovery-test.yml @@ -22,7 +22,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:d760427d72cf6420c84f7558af39e9eb3d8a0d26a15892fa1500c4f592a478ae + image: ghcr.io/dfinity/ic-build@sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/home/buildifier/.local/share/containers" diff --git a/.github/workflows/ci-main.yml b/.github/workflows/ci-main.yml index 85e40ad557ca..015a29bd52f8 100644 --- a/.github/workflows/ci-main.yml +++ b/.github/workflows/ci-main.yml @@ -33,7 +33,7 @@ jobs: runs-on: &dind-large-setup labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:d760427d72cf6420c84f7558af39e9eb3d8a0d26a15892fa1500c4f592a478ae + image: ghcr.io/dfinity/ic-build@sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 90 diff --git a/.github/workflows/ci-pr-only.yml b/.github/workflows/ci-pr-only.yml index 66fd1760eb7a..c6756ec7c20e 100644 --- a/.github/workflows/ci-pr-only.yml +++ b/.github/workflows/ci-pr-only.yml @@ -37,7 +37,7 @@ jobs: runs-on: &dind-small-setup labels: dind-small container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:d760427d72cf6420c84f7558af39e9eb3d8a0d26a15892fa1500c4f592a478ae + image: ghcr.io/dfinity/ic-build@sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b options: >- -e NODE_NAME --mount type=tmpfs,target="/tmp/containers" steps: diff --git a/.github/workflows/container-api-bn-recovery.yml b/.github/workflows/container-api-bn-recovery.yml index 1a12ea4d8b31..42f092a359e5 100644 --- a/.github/workflows/container-api-bn-recovery.yml +++ b/.github/workflows/container-api-bn-recovery.yml @@ -28,7 +28,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:d760427d72cf6420c84f7558af39e9eb3d8a0d26a15892fa1500c4f592a478ae + image: ghcr.io/dfinity/ic-build@sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/home/buildifier/.local/share/containers" diff --git a/.github/workflows/container-scan-nightly.yml b/.github/workflows/container-scan-nightly.yml index fe57cc3d64df..4e555deeb201 100644 --- a/.github/workflows/container-scan-nightly.yml +++ b/.github/workflows/container-scan-nightly.yml @@ -12,7 +12,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:d760427d72cf6420c84f7558af39e9eb3d8a0d26a15892fa1500c4f592a478ae + image: ghcr.io/dfinity/ic-build@sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 60 diff --git a/.github/workflows/local-system-tests.yml b/.github/workflows/local-system-tests.yml index c27bde719a72..6a34fa8f3621 100644 --- a/.github/workflows/local-system-tests.yml +++ b/.github/workflows/local-system-tests.yml @@ -19,7 +19,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:d760427d72cf6420c84f7558af39e9eb3d8a0d26a15892fa1500c4f592a478ae + image: ghcr.io/dfinity/ic-build@sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 600 diff --git a/.github/workflows/pocket-ic-tests-windows.yml b/.github/workflows/pocket-ic-tests-windows.yml index fd5b17204c18..c739aa740613 100644 --- a/.github/workflows/pocket-ic-tests-windows.yml +++ b/.github/workflows/pocket-ic-tests-windows.yml @@ -45,7 +45,7 @@ jobs: bazel-build-pocket-ic: name: Bazel Build PocketIC container: - image: ghcr.io/dfinity/ic-build@sha256:d760427d72cf6420c84f7558af39e9eb3d8a0d26a15892fa1500c4f592a478ae + image: ghcr.io/dfinity/ic-build@sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 90 diff --git a/.github/workflows/rate-limits-backend-release.yml b/.github/workflows/rate-limits-backend-release.yml index 00fd524675f3..ce0e9acb43fa 100644 --- a/.github/workflows/rate-limits-backend-release.yml +++ b/.github/workflows/rate-limits-backend-release.yml @@ -32,7 +32,7 @@ jobs: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:d760427d72cf6420c84f7558af39e9eb3d8a0d26a15892fa1500c4f592a478ae + image: ghcr.io/dfinity/ic-build@sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" diff --git a/.github/workflows/release-testing.yml b/.github/workflows/release-testing.yml index 922eae85bf14..07a9dac6c352 100644 --- a/.github/workflows/release-testing.yml +++ b/.github/workflows/release-testing.yml @@ -35,7 +35,7 @@ jobs: group: dm1 labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:d760427d72cf6420c84f7558af39e9eb3d8a0d26a15892fa1500c4f592a478ae + image: ghcr.io/dfinity/ic-build@sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 180 diff --git a/.github/workflows/rosetta-release.yml b/.github/workflows/rosetta-release.yml index 53b912fb485e..d66059b6f856 100644 --- a/.github/workflows/rosetta-release.yml +++ b/.github/workflows/rosetta-release.yml @@ -22,7 +22,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:d760427d72cf6420c84f7558af39e9eb3d8a0d26a15892fa1500c4f592a478ae + image: ghcr.io/dfinity/ic-build@sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" environment: DockerHub diff --git a/.github/workflows/salt-sharing-canister-release.yml b/.github/workflows/salt-sharing-canister-release.yml index ca869576bcb6..331577a6d4ce 100644 --- a/.github/workflows/salt-sharing-canister-release.yml +++ b/.github/workflows/salt-sharing-canister-release.yml @@ -32,7 +32,7 @@ jobs: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:d760427d72cf6420c84f7558af39e9eb3d8a0d26a15892fa1500c4f592a478ae + image: ghcr.io/dfinity/ic-build@sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" diff --git a/.github/workflows/schedule-daily-bare-metal.yml b/.github/workflows/schedule-daily-bare-metal.yml index 22897de34bd5..7b1cc2be0cc0 100644 --- a/.github/workflows/schedule-daily-bare-metal.yml +++ b/.github/workflows/schedule-daily-bare-metal.yml @@ -14,7 +14,7 @@ jobs: runs-on: &dind-large-setup labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:0ed93dc568f53cce56042a86b31f98cd1bbb9cd3ea8e649532c366494b9c160a + image: ghcr.io/dfinity/ic-build@sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" environment: Bare Metal Tests diff --git a/.github/workflows/schedule-daily.yml b/.github/workflows/schedule-daily.yml index d855910e79ef..91d96314ecbf 100644 --- a/.github/workflows/schedule-daily.yml +++ b/.github/workflows/schedule-daily.yml @@ -14,7 +14,7 @@ jobs: runs-on: &dind-large-setup labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:d760427d72cf6420c84f7558af39e9eb3d8a0d26a15892fa1500c4f592a478ae + image: ghcr.io/dfinity/ic-build@sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 720 # 12 hours diff --git a/.github/workflows/schedule-rust-bench.yml b/.github/workflows/schedule-rust-bench.yml index 6b977cc701fa..3f31aea064c8 100644 --- a/.github/workflows/schedule-rust-bench.yml +++ b/.github/workflows/schedule-rust-bench.yml @@ -24,7 +24,7 @@ jobs: # see linux-x86-64 runner group labels: rust-benchmarks container: - image: ghcr.io/dfinity/ic-build@sha256:d760427d72cf6420c84f7558af39e9eb3d8a0d26a15892fa1500c4f592a478ae + image: ghcr.io/dfinity/ic-build@sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b # running on bare metal machine using ubuntu user options: --user ubuntu --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 720 # 12 hours diff --git a/.github/workflows/system-tests-benchmarks-nightly.yml b/.github/workflows/system-tests-benchmarks-nightly.yml index 8dfd0b2b008e..ee0f6187cb55 100644 --- a/.github/workflows/system-tests-benchmarks-nightly.yml +++ b/.github/workflows/system-tests-benchmarks-nightly.yml @@ -17,7 +17,7 @@ jobs: group: dm1 labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:d760427d72cf6420c84f7558af39e9eb3d8a0d26a15892fa1500c4f592a478ae + image: ghcr.io/dfinity/ic-build@sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 480 diff --git a/.github/workflows/update-mainnet-canister-revisions.yaml b/.github/workflows/update-mainnet-canister-revisions.yaml index 51c24343f439..d79f1043c8fc 100644 --- a/.github/workflows/update-mainnet-canister-revisions.yaml +++ b/.github/workflows/update-mainnet-canister-revisions.yaml @@ -25,7 +25,7 @@ jobs: labels: dind-small environment: CREATE_PR container: - image: ghcr.io/dfinity/ic-build@sha256:d760427d72cf6420c84f7558af39e9eb3d8a0d26a15892fa1500c4f592a478ae + image: ghcr.io/dfinity/ic-build@sha256:d08fbbbea0f740fcf057a5951271a9a69e85ec76393626e75ffa2693fe7f3c4b options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" env: diff --git a/ci/container/TAG b/ci/container/TAG index 5d1549232c9b..ddf7e6f2d8aa 100644 --- a/ci/container/TAG +++ b/ci/container/TAG @@ -1 +1 @@ -abbba8fa906b3d98553d787112d7ce0041af806f8758e28bbbe0ea5084a5abe3 +baf0cbe760d16c66c8294e2c5b8edc59a9527967070fea70acf17115b4be8a34 From 8864ac691fcdf5ca5505273f62d07b46c8e6a61f Mon Sep 17 00:00:00 2001 From: IDX GitHub Automation <> Date: Fri, 10 Jul 2026 12:01:59 +0000 Subject: [PATCH 07/13] Updating container images to tag: 10a13e88a32ba0930ec494327b5e413df2c4e0847d7be43124022d7e6d24919d ic-build: sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 ic-dev: sha256:d80def17941e0208e13f994cce628e0e370a59f40086cb3a0a7cdadaeb382dfc --- .devcontainer/devcontainer.json | 2 +- .github/workflows/api-bn-recovery-test.yml | 2 +- .github/workflows/ci-main.yml | 2 +- .github/workflows/ci-pr-only.yml | 2 +- .github/workflows/container-api-bn-recovery.yml | 2 +- .github/workflows/container-scan-nightly.yml | 2 +- .github/workflows/local-system-tests.yml | 2 +- .github/workflows/pocket-ic-tests-windows.yml | 2 +- .github/workflows/rate-limits-backend-release.yml | 2 +- .github/workflows/release-testing.yml | 2 +- .github/workflows/rosetta-release.yml | 2 +- .github/workflows/salt-sharing-canister-release.yml | 2 +- .github/workflows/schedule-daily-bare-metal.yml | 2 +- .github/workflows/schedule-daily.yml | 2 +- .github/workflows/schedule-rust-bench.yml | 2 +- .github/workflows/system-tests-benchmarks-nightly.yml | 2 +- .github/workflows/update-mainnet-canister-revisions.yaml | 2 +- ci/container/TAG | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 5d1029df49a6..344b72f51a0c 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,5 +1,5 @@ { - "image": "ghcr.io/dfinity/ic-dev@sha256:653f20872ae14fcf3e662d2afe4d848866ffd94c5e06b9ecdef6f89c40e28098", + "image": "ghcr.io/dfinity/ic-dev@sha256:d80def17941e0208e13f994cce628e0e370a59f40086cb3a0a7cdadaeb382dfc", "remoteUser": "ubuntu", "privileged": true, "runArgs": [ diff --git a/.github/workflows/api-bn-recovery-test.yml b/.github/workflows/api-bn-recovery-test.yml index c163bb578b78..a4365b071c03 100644 --- a/.github/workflows/api-bn-recovery-test.yml +++ b/.github/workflows/api-bn-recovery-test.yml @@ -22,7 +22,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:bb3f774cda0d65c858e6e636883422a337d9c3c8457941c63bf9577a69f7466a + image: ghcr.io/dfinity/ic-build@sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/home/buildifier/.local/share/containers" diff --git a/.github/workflows/ci-main.yml b/.github/workflows/ci-main.yml index 69a86df50d06..e66ae0cebfac 100644 --- a/.github/workflows/ci-main.yml +++ b/.github/workflows/ci-main.yml @@ -33,7 +33,7 @@ jobs: runs-on: &dind-large-setup labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:bb3f774cda0d65c858e6e636883422a337d9c3c8457941c63bf9577a69f7466a + image: ghcr.io/dfinity/ic-build@sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 90 diff --git a/.github/workflows/ci-pr-only.yml b/.github/workflows/ci-pr-only.yml index 1c61db9a50be..d60d04bf5794 100644 --- a/.github/workflows/ci-pr-only.yml +++ b/.github/workflows/ci-pr-only.yml @@ -37,7 +37,7 @@ jobs: runs-on: &dind-small-setup labels: dind-small container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:bb3f774cda0d65c858e6e636883422a337d9c3c8457941c63bf9577a69f7466a + image: ghcr.io/dfinity/ic-build@sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 options: >- -e NODE_NAME --mount type=tmpfs,target="/tmp/containers" steps: diff --git a/.github/workflows/container-api-bn-recovery.yml b/.github/workflows/container-api-bn-recovery.yml index 67ee4a27dbaf..0a0a3775d14e 100644 --- a/.github/workflows/container-api-bn-recovery.yml +++ b/.github/workflows/container-api-bn-recovery.yml @@ -28,7 +28,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:bb3f774cda0d65c858e6e636883422a337d9c3c8457941c63bf9577a69f7466a + image: ghcr.io/dfinity/ic-build@sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/home/buildifier/.local/share/containers" diff --git a/.github/workflows/container-scan-nightly.yml b/.github/workflows/container-scan-nightly.yml index 83a66bc3566e..326b700cdf0c 100644 --- a/.github/workflows/container-scan-nightly.yml +++ b/.github/workflows/container-scan-nightly.yml @@ -12,7 +12,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:bb3f774cda0d65c858e6e636883422a337d9c3c8457941c63bf9577a69f7466a + image: ghcr.io/dfinity/ic-build@sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 60 diff --git a/.github/workflows/local-system-tests.yml b/.github/workflows/local-system-tests.yml index 11dc0fe42dbe..57df9aa3a840 100644 --- a/.github/workflows/local-system-tests.yml +++ b/.github/workflows/local-system-tests.yml @@ -19,7 +19,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:bb3f774cda0d65c858e6e636883422a337d9c3c8457941c63bf9577a69f7466a + image: ghcr.io/dfinity/ic-build@sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 600 diff --git a/.github/workflows/pocket-ic-tests-windows.yml b/.github/workflows/pocket-ic-tests-windows.yml index 85dcf7dbb787..8882d2067b88 100644 --- a/.github/workflows/pocket-ic-tests-windows.yml +++ b/.github/workflows/pocket-ic-tests-windows.yml @@ -45,7 +45,7 @@ jobs: bazel-build-pocket-ic: name: Bazel Build PocketIC container: - image: ghcr.io/dfinity/ic-build@sha256:bb3f774cda0d65c858e6e636883422a337d9c3c8457941c63bf9577a69f7466a + image: ghcr.io/dfinity/ic-build@sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 90 diff --git a/.github/workflows/rate-limits-backend-release.yml b/.github/workflows/rate-limits-backend-release.yml index a01c2c5bff5d..1d9ec44f7c71 100644 --- a/.github/workflows/rate-limits-backend-release.yml +++ b/.github/workflows/rate-limits-backend-release.yml @@ -32,7 +32,7 @@ jobs: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:bb3f774cda0d65c858e6e636883422a337d9c3c8457941c63bf9577a69f7466a + image: ghcr.io/dfinity/ic-build@sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" diff --git a/.github/workflows/release-testing.yml b/.github/workflows/release-testing.yml index 08926f9a6b9c..fbcc1a6f6fe1 100644 --- a/.github/workflows/release-testing.yml +++ b/.github/workflows/release-testing.yml @@ -35,7 +35,7 @@ jobs: group: dm1 labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:bb3f774cda0d65c858e6e636883422a337d9c3c8457941c63bf9577a69f7466a + image: ghcr.io/dfinity/ic-build@sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 180 diff --git a/.github/workflows/rosetta-release.yml b/.github/workflows/rosetta-release.yml index 0f85f7a9a1f3..5a605d8b040d 100644 --- a/.github/workflows/rosetta-release.yml +++ b/.github/workflows/rosetta-release.yml @@ -22,7 +22,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:bb3f774cda0d65c858e6e636883422a337d9c3c8457941c63bf9577a69f7466a + image: ghcr.io/dfinity/ic-build@sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" environment: DockerHub diff --git a/.github/workflows/salt-sharing-canister-release.yml b/.github/workflows/salt-sharing-canister-release.yml index 58b73eaa0871..dd3b6d11c59e 100644 --- a/.github/workflows/salt-sharing-canister-release.yml +++ b/.github/workflows/salt-sharing-canister-release.yml @@ -32,7 +32,7 @@ jobs: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:bb3f774cda0d65c858e6e636883422a337d9c3c8457941c63bf9577a69f7466a + image: ghcr.io/dfinity/ic-build@sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" diff --git a/.github/workflows/schedule-daily-bare-metal.yml b/.github/workflows/schedule-daily-bare-metal.yml index 2ed9373d1dce..1c1934e63179 100644 --- a/.github/workflows/schedule-daily-bare-metal.yml +++ b/.github/workflows/schedule-daily-bare-metal.yml @@ -14,7 +14,7 @@ jobs: runs-on: &dind-large-setup labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:bb3f774cda0d65c858e6e636883422a337d9c3c8457941c63bf9577a69f7466a + image: ghcr.io/dfinity/ic-build@sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" environment: Bare Metal Tests diff --git a/.github/workflows/schedule-daily.yml b/.github/workflows/schedule-daily.yml index baa5933b97c2..dd71f2eb2f7b 100644 --- a/.github/workflows/schedule-daily.yml +++ b/.github/workflows/schedule-daily.yml @@ -14,7 +14,7 @@ jobs: runs-on: &dind-large-setup labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:bb3f774cda0d65c858e6e636883422a337d9c3c8457941c63bf9577a69f7466a + image: ghcr.io/dfinity/ic-build@sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 720 # 12 hours diff --git a/.github/workflows/schedule-rust-bench.yml b/.github/workflows/schedule-rust-bench.yml index cc504f00acf9..2664899d5afb 100644 --- a/.github/workflows/schedule-rust-bench.yml +++ b/.github/workflows/schedule-rust-bench.yml @@ -24,7 +24,7 @@ jobs: # see linux-x86-64 runner group labels: rust-benchmarks container: - image: ghcr.io/dfinity/ic-build@sha256:bb3f774cda0d65c858e6e636883422a337d9c3c8457941c63bf9577a69f7466a + image: ghcr.io/dfinity/ic-build@sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 # running on bare metal machine using ubuntu user options: --user ubuntu --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 720 # 12 hours diff --git a/.github/workflows/system-tests-benchmarks-nightly.yml b/.github/workflows/system-tests-benchmarks-nightly.yml index feb7bd7a073f..0977dd177de8 100644 --- a/.github/workflows/system-tests-benchmarks-nightly.yml +++ b/.github/workflows/system-tests-benchmarks-nightly.yml @@ -17,7 +17,7 @@ jobs: group: dm1 labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:bb3f774cda0d65c858e6e636883422a337d9c3c8457941c63bf9577a69f7466a + image: ghcr.io/dfinity/ic-build@sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 480 diff --git a/.github/workflows/update-mainnet-canister-revisions.yaml b/.github/workflows/update-mainnet-canister-revisions.yaml index 42b01e72d550..836856bdaa5c 100644 --- a/.github/workflows/update-mainnet-canister-revisions.yaml +++ b/.github/workflows/update-mainnet-canister-revisions.yaml @@ -25,7 +25,7 @@ jobs: labels: dind-small environment: CREATE_PR container: - image: ghcr.io/dfinity/ic-build@sha256:bb3f774cda0d65c858e6e636883422a337d9c3c8457941c63bf9577a69f7466a + image: ghcr.io/dfinity/ic-build@sha256:0d2e7465c8aa6723b96743011fcdc0e1eb15ead88639ca74aacf96ada92d30a9 options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" env: diff --git a/ci/container/TAG b/ci/container/TAG index cc95d80cc331..449fe7d440c5 100644 --- a/ci/container/TAG +++ b/ci/container/TAG @@ -1 +1 @@ -d6256361e7396874e20ee8297fb09b166a350ed722ca611dab05ef6605cecd4e +10a13e88a32ba0930ec494327b5e413df2c4e0847d7be43124022d7e6d24919d From 1a237c948674bb41471a68b8bab5f75edabc17b2 Mon Sep 17 00:00:00 2001 From: IDX GitHub Automation <> Date: Fri, 10 Jul 2026 19:29:06 +0000 Subject: [PATCH 08/13] Updating container images to tag: 285e2d5f1b7bc3735765c70b70504aad04c171c7ee7ebae00c03f24d608cd688 ic-build: sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 ic-dev: sha256:eae27468101cff14340905c9b6d1fc6caebe339c7ed474d8fee6d35015c04d61 --- .devcontainer/devcontainer.json | 2 +- .github/workflows/api-bn-recovery-test.yml | 2 +- .github/workflows/ci-main.yml | 2 +- .github/workflows/ci-pr-only.yml | 2 +- .github/workflows/container-api-bn-recovery.yml | 2 +- .github/workflows/container-scan-nightly.yml | 2 +- .github/workflows/local-system-tests.yml | 2 +- .github/workflows/pocket-ic-tests-windows.yml | 2 +- .github/workflows/rate-limits-backend-release.yml | 2 +- .github/workflows/release-testing.yml | 2 +- .github/workflows/rosetta-release.yml | 2 +- .github/workflows/salt-sharing-canister-release.yml | 2 +- .github/workflows/schedule-daily-bare-metal.yml | 2 +- .github/workflows/schedule-daily.yml | 2 +- .github/workflows/schedule-rust-bench.yml | 2 +- .github/workflows/system-tests-benchmarks-nightly.yml | 2 +- .github/workflows/update-mainnet-canister-revisions.yaml | 2 +- ci/container/TAG | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 60adab1175fc..0f81258b32d5 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,5 +1,5 @@ { - "image": "ghcr.io/dfinity/ic-dev@sha256:747899e6056d14d4d6bc3c22feb1a259d197f86066efb6721dc93ee6311fadeb", + "image": "ghcr.io/dfinity/ic-dev@sha256:eae27468101cff14340905c9b6d1fc6caebe339c7ed474d8fee6d35015c04d61", "remoteUser": "ubuntu", "privileged": true, "runArgs": [ diff --git a/.github/workflows/api-bn-recovery-test.yml b/.github/workflows/api-bn-recovery-test.yml index f223c49ccaec..9958adc1a7cc 100644 --- a/.github/workflows/api-bn-recovery-test.yml +++ b/.github/workflows/api-bn-recovery-test.yml @@ -22,7 +22,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:b938ef3de01009a54225ca400aa4bd0a637440c755c32acd4c8a2f8f563b7951 + image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/home/buildifier/.local/share/containers" diff --git a/.github/workflows/ci-main.yml b/.github/workflows/ci-main.yml index 5e9ad6c0524d..5a629d1598d0 100644 --- a/.github/workflows/ci-main.yml +++ b/.github/workflows/ci-main.yml @@ -33,7 +33,7 @@ jobs: runs-on: &dind-large-setup labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:b938ef3de01009a54225ca400aa4bd0a637440c755c32acd4c8a2f8f563b7951 + image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 90 diff --git a/.github/workflows/ci-pr-only.yml b/.github/workflows/ci-pr-only.yml index 357cc87676e7..0f0db8ef8ee4 100644 --- a/.github/workflows/ci-pr-only.yml +++ b/.github/workflows/ci-pr-only.yml @@ -37,7 +37,7 @@ jobs: runs-on: &dind-small-setup labels: dind-small container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:b938ef3de01009a54225ca400aa4bd0a637440c755c32acd4c8a2f8f563b7951 + image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 options: >- -e NODE_NAME --mount type=tmpfs,target="/tmp/containers" steps: diff --git a/.github/workflows/container-api-bn-recovery.yml b/.github/workflows/container-api-bn-recovery.yml index a48fdbc5947d..e013d3f86cb7 100644 --- a/.github/workflows/container-api-bn-recovery.yml +++ b/.github/workflows/container-api-bn-recovery.yml @@ -28,7 +28,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:b938ef3de01009a54225ca400aa4bd0a637440c755c32acd4c8a2f8f563b7951 + image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/home/buildifier/.local/share/containers" diff --git a/.github/workflows/container-scan-nightly.yml b/.github/workflows/container-scan-nightly.yml index 6736eca8d673..4fd4a96d91eb 100644 --- a/.github/workflows/container-scan-nightly.yml +++ b/.github/workflows/container-scan-nightly.yml @@ -12,7 +12,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:b938ef3de01009a54225ca400aa4bd0a637440c755c32acd4c8a2f8f563b7951 + image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 60 diff --git a/.github/workflows/local-system-tests.yml b/.github/workflows/local-system-tests.yml index 8fa141dbc031..ec1e967f56f1 100644 --- a/.github/workflows/local-system-tests.yml +++ b/.github/workflows/local-system-tests.yml @@ -19,7 +19,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:b938ef3de01009a54225ca400aa4bd0a637440c755c32acd4c8a2f8f563b7951 + image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 600 diff --git a/.github/workflows/pocket-ic-tests-windows.yml b/.github/workflows/pocket-ic-tests-windows.yml index b2f68da259f6..16cf5bf00b5f 100644 --- a/.github/workflows/pocket-ic-tests-windows.yml +++ b/.github/workflows/pocket-ic-tests-windows.yml @@ -45,7 +45,7 @@ jobs: bazel-build-pocket-ic: name: Bazel Build PocketIC container: - image: ghcr.io/dfinity/ic-build@sha256:b938ef3de01009a54225ca400aa4bd0a637440c755c32acd4c8a2f8f563b7951 + image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 90 diff --git a/.github/workflows/rate-limits-backend-release.yml b/.github/workflows/rate-limits-backend-release.yml index d2a114aab540..b5affa8e9824 100644 --- a/.github/workflows/rate-limits-backend-release.yml +++ b/.github/workflows/rate-limits-backend-release.yml @@ -32,7 +32,7 @@ jobs: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:b938ef3de01009a54225ca400aa4bd0a637440c755c32acd4c8a2f8f563b7951 + image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" diff --git a/.github/workflows/release-testing.yml b/.github/workflows/release-testing.yml index df127ccebcab..dc6886034edc 100644 --- a/.github/workflows/release-testing.yml +++ b/.github/workflows/release-testing.yml @@ -35,7 +35,7 @@ jobs: group: dm1 labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:b938ef3de01009a54225ca400aa4bd0a637440c755c32acd4c8a2f8f563b7951 + image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 180 diff --git a/.github/workflows/rosetta-release.yml b/.github/workflows/rosetta-release.yml index f16898390dbd..06634d20871d 100644 --- a/.github/workflows/rosetta-release.yml +++ b/.github/workflows/rosetta-release.yml @@ -22,7 +22,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:b938ef3de01009a54225ca400aa4bd0a637440c755c32acd4c8a2f8f563b7951 + image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" environment: DockerHub diff --git a/.github/workflows/salt-sharing-canister-release.yml b/.github/workflows/salt-sharing-canister-release.yml index b4fe89c08acb..a326e1c30ced 100644 --- a/.github/workflows/salt-sharing-canister-release.yml +++ b/.github/workflows/salt-sharing-canister-release.yml @@ -32,7 +32,7 @@ jobs: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:b938ef3de01009a54225ca400aa4bd0a637440c755c32acd4c8a2f8f563b7951 + image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" diff --git a/.github/workflows/schedule-daily-bare-metal.yml b/.github/workflows/schedule-daily-bare-metal.yml index 6bcb49717589..90a71e5de198 100644 --- a/.github/workflows/schedule-daily-bare-metal.yml +++ b/.github/workflows/schedule-daily-bare-metal.yml @@ -14,7 +14,7 @@ jobs: runs-on: &dind-large-setup labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:b938ef3de01009a54225ca400aa4bd0a637440c755c32acd4c8a2f8f563b7951 + image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" environment: Bare Metal Tests diff --git a/.github/workflows/schedule-daily.yml b/.github/workflows/schedule-daily.yml index ad8f9033fe30..c329a6f752b0 100644 --- a/.github/workflows/schedule-daily.yml +++ b/.github/workflows/schedule-daily.yml @@ -14,7 +14,7 @@ jobs: runs-on: &dind-large-setup labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:b938ef3de01009a54225ca400aa4bd0a637440c755c32acd4c8a2f8f563b7951 + image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 720 # 12 hours diff --git a/.github/workflows/schedule-rust-bench.yml b/.github/workflows/schedule-rust-bench.yml index 4795bfdd6ddc..759f4c6e2106 100644 --- a/.github/workflows/schedule-rust-bench.yml +++ b/.github/workflows/schedule-rust-bench.yml @@ -24,7 +24,7 @@ jobs: # see linux-x86-64 runner group labels: rust-benchmarks container: - image: ghcr.io/dfinity/ic-build@sha256:b938ef3de01009a54225ca400aa4bd0a637440c755c32acd4c8a2f8f563b7951 + image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 # running on bare metal machine using ubuntu user options: --user ubuntu --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 720 # 12 hours diff --git a/.github/workflows/system-tests-benchmarks-nightly.yml b/.github/workflows/system-tests-benchmarks-nightly.yml index a51436ee51fb..cb9efbf84ad8 100644 --- a/.github/workflows/system-tests-benchmarks-nightly.yml +++ b/.github/workflows/system-tests-benchmarks-nightly.yml @@ -17,7 +17,7 @@ jobs: group: dm1 labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:b938ef3de01009a54225ca400aa4bd0a637440c755c32acd4c8a2f8f563b7951 + image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 480 diff --git a/.github/workflows/update-mainnet-canister-revisions.yaml b/.github/workflows/update-mainnet-canister-revisions.yaml index 20287ca8a048..41a81eebb7a4 100644 --- a/.github/workflows/update-mainnet-canister-revisions.yaml +++ b/.github/workflows/update-mainnet-canister-revisions.yaml @@ -25,7 +25,7 @@ jobs: labels: dind-small environment: CREATE_PR container: - image: ghcr.io/dfinity/ic-build@sha256:b938ef3de01009a54225ca400aa4bd0a637440c755c32acd4c8a2f8f563b7951 + image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" env: diff --git a/ci/container/TAG b/ci/container/TAG index dd09e480c2e9..1bc94839cfef 100644 --- a/ci/container/TAG +++ b/ci/container/TAG @@ -1 +1 @@ -90f50a9529f78a97ad0c37055d15a93cbf4c66723b18406efe603046ec20c956 +285e2d5f1b7bc3735765c70b70504aad04c171c7ee7ebae00c03f24d608cd688 From e20e6a3eeb27c4ecb5d2c1c1acbe35a7164050eb Mon Sep 17 00:00:00 2001 From: Bas van Dijk Date: Fri, 10 Jul 2026 20:03:48 +0000 Subject: [PATCH 09/13] chore: upgrade rustc: 1.95.0 -> 1.97.0 --- bazel/rust.MODULE.bazel | 2 +- rust-toolchain.toml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/bazel/rust.MODULE.bazel b/bazel/rust.MODULE.bazel index 0898e7c44199..91a584fc060e 100644 --- a/bazel/rust.MODULE.bazel +++ b/bazel/rust.MODULE.bazel @@ -22,7 +22,7 @@ archive_override( rust = use_extension("@rules_rust//rust:extensions.bzl", "rust") rust.toolchain( edition = "2024", - versions = ["1.95.0"], + versions = ["1.97.0"], ) # Repin with `CARGO_BAZEL_REPIN=true bazel build @crate_index//...` diff --git a/rust-toolchain.toml b/rust-toolchain.toml index 9a2610db55d0..f15ccd107d66 100644 --- a/rust-toolchain.toml +++ b/rust-toolchain.toml @@ -1,5 +1,5 @@ [toolchain] -channel = "1.95.0" +channel = "1.97.0" targets = ["wasm32-unknown-unknown"] profile = "default" components = [] From 3522b768de6b805a2b8267715952be809094e626 Mon Sep 17 00:00:00 2001 From: IDX GitHub Automation <> Date: Fri, 10 Jul 2026 20:09:33 +0000 Subject: [PATCH 10/13] Updating container images to tag: 180b7a18c045f013033db88ee52d44c4c9f1b7f3f51ba132ab53ded517d492da ic-build: sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e ic-dev: sha256:7f4e0bb317291ee52f3a74e7228590582222e29f7ccd6adc353678a90a8549f4 --- .devcontainer/devcontainer.json | 2 +- .github/workflows/api-bn-recovery-test.yml | 2 +- .github/workflows/ci-main.yml | 2 +- .github/workflows/ci-pr-only.yml | 2 +- .github/workflows/container-api-bn-recovery.yml | 2 +- .github/workflows/container-scan-nightly.yml | 2 +- .github/workflows/local-system-tests.yml | 2 +- .github/workflows/pocket-ic-tests-windows.yml | 2 +- .github/workflows/rate-limits-backend-release.yml | 2 +- .github/workflows/release-testing.yml | 2 +- .github/workflows/rosetta-release.yml | 2 +- .github/workflows/salt-sharing-canister-release.yml | 2 +- .github/workflows/schedule-daily-bare-metal.yml | 2 +- .github/workflows/schedule-daily.yml | 2 +- .github/workflows/schedule-rust-bench.yml | 2 +- .github/workflows/system-tests-benchmarks-nightly.yml | 2 +- .github/workflows/update-mainnet-canister-revisions.yaml | 2 +- ci/container/TAG | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index 0f81258b32d5..59a2fa1affb7 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -1,5 +1,5 @@ { - "image": "ghcr.io/dfinity/ic-dev@sha256:eae27468101cff14340905c9b6d1fc6caebe339c7ed474d8fee6d35015c04d61", + "image": "ghcr.io/dfinity/ic-dev@sha256:7f4e0bb317291ee52f3a74e7228590582222e29f7ccd6adc353678a90a8549f4", "remoteUser": "ubuntu", "privileged": true, "runArgs": [ diff --git a/.github/workflows/api-bn-recovery-test.yml b/.github/workflows/api-bn-recovery-test.yml index 9958adc1a7cc..b594f28ce312 100644 --- a/.github/workflows/api-bn-recovery-test.yml +++ b/.github/workflows/api-bn-recovery-test.yml @@ -22,7 +22,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 + image: ghcr.io/dfinity/ic-build@sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/home/buildifier/.local/share/containers" diff --git a/.github/workflows/ci-main.yml b/.github/workflows/ci-main.yml index 5a629d1598d0..63addf45f701 100644 --- a/.github/workflows/ci-main.yml +++ b/.github/workflows/ci-main.yml @@ -33,7 +33,7 @@ jobs: runs-on: &dind-large-setup labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 + image: ghcr.io/dfinity/ic-build@sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 90 diff --git a/.github/workflows/ci-pr-only.yml b/.github/workflows/ci-pr-only.yml index 0f0db8ef8ee4..3d518c51b0ae 100644 --- a/.github/workflows/ci-pr-only.yml +++ b/.github/workflows/ci-pr-only.yml @@ -37,7 +37,7 @@ jobs: runs-on: &dind-small-setup labels: dind-small container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 + image: ghcr.io/dfinity/ic-build@sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e options: >- -e NODE_NAME --mount type=tmpfs,target="/tmp/containers" steps: diff --git a/.github/workflows/container-api-bn-recovery.yml b/.github/workflows/container-api-bn-recovery.yml index e013d3f86cb7..9ba6cd787509 100644 --- a/.github/workflows/container-api-bn-recovery.yml +++ b/.github/workflows/container-api-bn-recovery.yml @@ -28,7 +28,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 + image: ghcr.io/dfinity/ic-build@sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/home/buildifier/.local/share/containers" diff --git a/.github/workflows/container-scan-nightly.yml b/.github/workflows/container-scan-nightly.yml index 4fd4a96d91eb..d0b372f1fdd0 100644 --- a/.github/workflows/container-scan-nightly.yml +++ b/.github/workflows/container-scan-nightly.yml @@ -12,7 +12,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 + image: ghcr.io/dfinity/ic-build@sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 60 diff --git a/.github/workflows/local-system-tests.yml b/.github/workflows/local-system-tests.yml index ec1e967f56f1..f93815b54a0f 100644 --- a/.github/workflows/local-system-tests.yml +++ b/.github/workflows/local-system-tests.yml @@ -19,7 +19,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 + image: ghcr.io/dfinity/ic-build@sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 600 diff --git a/.github/workflows/pocket-ic-tests-windows.yml b/.github/workflows/pocket-ic-tests-windows.yml index 16cf5bf00b5f..d9af426f859f 100644 --- a/.github/workflows/pocket-ic-tests-windows.yml +++ b/.github/workflows/pocket-ic-tests-windows.yml @@ -45,7 +45,7 @@ jobs: bazel-build-pocket-ic: name: Bazel Build PocketIC container: - image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 + image: ghcr.io/dfinity/ic-build@sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 90 diff --git a/.github/workflows/rate-limits-backend-release.yml b/.github/workflows/rate-limits-backend-release.yml index b5affa8e9824..a59a1dd8bb22 100644 --- a/.github/workflows/rate-limits-backend-release.yml +++ b/.github/workflows/rate-limits-backend-release.yml @@ -32,7 +32,7 @@ jobs: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 + image: ghcr.io/dfinity/ic-build@sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" diff --git a/.github/workflows/release-testing.yml b/.github/workflows/release-testing.yml index dc6886034edc..c8009e7aa10e 100644 --- a/.github/workflows/release-testing.yml +++ b/.github/workflows/release-testing.yml @@ -35,7 +35,7 @@ jobs: group: dm1 labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 + image: ghcr.io/dfinity/ic-build@sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 180 diff --git a/.github/workflows/rosetta-release.yml b/.github/workflows/rosetta-release.yml index 06634d20871d..744e7a4083cf 100644 --- a/.github/workflows/rosetta-release.yml +++ b/.github/workflows/rosetta-release.yml @@ -22,7 +22,7 @@ jobs: runs-on: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 + image: ghcr.io/dfinity/ic-build@sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" environment: DockerHub diff --git a/.github/workflows/salt-sharing-canister-release.yml b/.github/workflows/salt-sharing-canister-release.yml index a326e1c30ced..acdd96bff845 100644 --- a/.github/workflows/salt-sharing-canister-release.yml +++ b/.github/workflows/salt-sharing-canister-release.yml @@ -32,7 +32,7 @@ jobs: labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 + image: ghcr.io/dfinity/ic-build@sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" diff --git a/.github/workflows/schedule-daily-bare-metal.yml b/.github/workflows/schedule-daily-bare-metal.yml index 90a71e5de198..65b2c883d6a7 100644 --- a/.github/workflows/schedule-daily-bare-metal.yml +++ b/.github/workflows/schedule-daily-bare-metal.yml @@ -14,7 +14,7 @@ jobs: runs-on: &dind-large-setup labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 + image: ghcr.io/dfinity/ic-build@sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" environment: Bare Metal Tests diff --git a/.github/workflows/schedule-daily.yml b/.github/workflows/schedule-daily.yml index c329a6f752b0..409e9c5340d9 100644 --- a/.github/workflows/schedule-daily.yml +++ b/.github/workflows/schedule-daily.yml @@ -14,7 +14,7 @@ jobs: runs-on: &dind-large-setup labels: dind-large container: &container-setup - image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 + image: ghcr.io/dfinity/ic-build@sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 720 # 12 hours diff --git a/.github/workflows/schedule-rust-bench.yml b/.github/workflows/schedule-rust-bench.yml index 759f4c6e2106..4d2868997c7b 100644 --- a/.github/workflows/schedule-rust-bench.yml +++ b/.github/workflows/schedule-rust-bench.yml @@ -24,7 +24,7 @@ jobs: # see linux-x86-64 runner group labels: rust-benchmarks container: - image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 + image: ghcr.io/dfinity/ic-build@sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e # running on bare metal machine using ubuntu user options: --user ubuntu --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 720 # 12 hours diff --git a/.github/workflows/system-tests-benchmarks-nightly.yml b/.github/workflows/system-tests-benchmarks-nightly.yml index cb9efbf84ad8..a14d62eb9464 100644 --- a/.github/workflows/system-tests-benchmarks-nightly.yml +++ b/.github/workflows/system-tests-benchmarks-nightly.yml @@ -17,7 +17,7 @@ jobs: group: dm1 labels: dind-large container: - image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 + image: ghcr.io/dfinity/ic-build@sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e options: >- -e NODE_NAME --privileged --cgroupns host --mount type=tmpfs,target="/tmp/containers" timeout-minutes: 480 diff --git a/.github/workflows/update-mainnet-canister-revisions.yaml b/.github/workflows/update-mainnet-canister-revisions.yaml index 41a81eebb7a4..1356c890c10f 100644 --- a/.github/workflows/update-mainnet-canister-revisions.yaml +++ b/.github/workflows/update-mainnet-canister-revisions.yaml @@ -25,7 +25,7 @@ jobs: labels: dind-small environment: CREATE_PR container: - image: ghcr.io/dfinity/ic-build@sha256:88eab17245eb00929dddf0eadbab2e359952e06c440c890420ba257409e30149 + image: ghcr.io/dfinity/ic-build@sha256:53faf54ebb066724dfa6b69bd21f11d5b1a8b58e839870fe612cf2553cbc332e options: >- -e NODE_NAME --privileged --cgroupns host -v /var/tmp:/var/tmp -v /ceph-s3-info:/ceph-s3-info --mount type=tmpfs,target="/tmp/containers" env: diff --git a/ci/container/TAG b/ci/container/TAG index 1bc94839cfef..92b8c5740426 100644 --- a/ci/container/TAG +++ b/ci/container/TAG @@ -1 +1 @@ -285e2d5f1b7bc3735765c70b70504aad04c171c7ee7ebae00c03f24d608cd688 +180b7a18c045f013033db88ee52d44c4c9f1b7f3f51ba132ab53ded517d492da From 58eab2624fd72b4a2ecdd30e083d461952164ba8 Mon Sep 17 00:00:00 2001 From: Bas van Dijk Date: Fri, 10 Jul 2026 21:04:05 +0000 Subject: [PATCH 11/13] chore: adapt for rustc-1.97.0 --- Cargo.Bazel.json.lock | 30 +++++++++---------- Cargo.Bazel.toml.lock | 18 +++++------ Cargo.lock | 22 +++++++------- Cargo.toml | 2 +- bazel/rust.MODULE.bazel | 2 +- rs/bitcoin/ckbtc/minter/src/state.rs | 10 ++----- rs/bitcoin/ckbtc/minter/src/state/eventlog.rs | 2 +- rs/bitcoin/ckbtc/minter/src/tx.rs | 2 +- .../ic_boundary/src/rate_limiting/generic.rs | 21 ++++--------- rs/canister_client/src/cbor.rs | 2 +- rs/canister_client/src/http_client.rs | 2 +- .../sandboxed_execution_controller.rs | 2 +- rs/canister_sandbox/src/rpc.rs | 2 +- rs/config/src/crypto.rs | 4 +-- rs/consensus/dkg/src/remote.rs | 2 +- .../src/vault/local_csp_vault/idkg/mod.rs | 4 +-- .../tarpc_csp_vault_server.rs | 2 +- rs/crypto/sha2/src/context/mod.rs | 2 +- rs/crypto/src/vetkd/mod.rs | 2 +- rs/embedders/src/wasm_utils/validation.rs | 2 +- rs/ethereum/cketh/minter/src/map.rs | 2 +- .../src/canister_manager/types.rs | 2 +- .../src/execution_environment.rs | 10 +++---- rs/execution_environment/src/scheduler.rs | 8 +---- rs/ic_os/build_tools/dflate/src/main.rs | 2 +- rs/ic_os/networking/network/src/interfaces.rs | 6 +--- rs/ic_os/networking/network/src/systemd.rs | 8 ++--- .../src/execution_environment/errors.rs | 4 +-- .../test_utils/in_memory_ledger/src/lib.rs | 16 +++++----- rs/nns/governance/src/governance.rs | 2 +- .../governance/src/neuron_data_validation.rs | 7 ++--- rs/nns/test_utils/src/gtc_helpers.rs | 2 +- rs/nns/test_utils/src/registry.rs | 2 +- .../src/catch_up_package_provider.rs | 2 +- rs/prep/src/internet_computer.rs | 6 ++-- rs/registry/admin/bin/main.rs | 6 ++-- .../canister/src/invariants/endpoint.rs | 2 +- .../do_add_or_remove_data_centers.rs | 9 ++---- rs/registry/nns_data_provider/src/registry.rs | 2 +- rs/replay/src/backup.rs | 2 +- rs/replay/src/player.rs | 4 +-- rs/replica/bin/replica/main.rs | 4 +-- .../common/rosetta_core/src/identifiers.rs | 4 +-- rs/rosetta-api/icp/src/request_handler.rs | 2 +- .../canister_test/src/canister.rs | 6 ++-- rs/sns/cli/src/deploy.rs | 8 ++--- rs/sns/governance/src/extensions.rs | 2 +- rs/sns/governance/src/icrc_ledger_helper.rs | 2 +- rs/sns/governance/src/proposal.rs | 4 +-- rs/state_layout/src/state_layout.rs | 4 +-- rs/state_manager/src/state_sync/types.rs | 9 ++---- .../execution_environment/src/lib.rs | 2 +- .../integration_test_common/src/lib.rs | 6 ++-- .../crypto/rpc_csp_vault_reconnection_test.rs | 6 ++-- rs/tests/driver/src/driver/farm.rs | 2 +- .../driver/src/driver/logs_stream_task.rs | 4 +-- rs/types/management_canister_types/src/lib.rs | 14 ++++----- rs/types/types/src/consensus/idkg.rs | 2 +- rs/types/types/src/crypto/error.rs | 18 +++++------ .../types/src/crypto/threshold_sig/ni_dkg.rs | 4 +-- .../src/crypto/threshold_sig/ni_dkg/config.rs | 2 +- .../src/crypto/threshold_sig/ni_dkg/errors.rs | 2 +- .../ni_dkg/errors/key_removal_error.rs | 2 +- 63 files changed, 155 insertions(+), 193 deletions(-) diff --git a/Cargo.Bazel.json.lock b/Cargo.Bazel.json.lock index dcfd0699c6f3..a9bd58d0cfd0 100644 --- a/Cargo.Bazel.json.lock +++ b/Cargo.Bazel.json.lock @@ -1,5 +1,5 @@ { - "checksum": "e841dfcec9174ce8904a03843eaaa081012da2bfeb0764c10705a19bc35392cd", + "checksum": "872bc54fbe6201ac14379b1bf41f532c3c0cb3460a3b17ddf4cb9bce5a2622ef", "crates": { "abnf 0.12.0": { "name": "abnf", @@ -22116,7 +22116,7 @@ "target": "ethers_core" }, { - "id": "ethnum 1.3.2", + "id": "ethnum 1.5.3", "target": "ethnum" }, { @@ -23563,7 +23563,7 @@ ], "cfg(windows)": [ { - "id": "windows-sys 0.59.0", + "id": "windows-sys 0.61.2", "target": "windows_sys" } ] @@ -26365,14 +26365,14 @@ ], "license_file": null }, - "ethnum 1.3.2": { + "ethnum 1.5.3": { "name": "ethnum", - "version": "1.3.2", + "version": "1.5.3", "package_url": "https://github.com/nlordell/ethnum-rs", "repository": { "Http": { - "url": "https://static.crates.io/crates/ethnum/1.3.2/download", - "sha256": "0198b9d0078e0f30dedc7acbb21c974e838fc8fae3ee170128658a98cb2c1c04" + "url": "https://static.crates.io/crates/ethnum/1.5.3/download", + "sha256": "40404c3f5f511ec4da6fe866ddf6a717c309fdbb69fbbad7b0f3edab8f2e835f" } }, "targets": [ @@ -26410,7 +26410,7 @@ "selects": {} }, "edition": "2021", - "version": "1.3.2" + "version": "1.5.3" }, "license": "MIT OR Apache-2.0", "license_ids": [ @@ -34634,7 +34634,7 @@ "target": "pin_project_lite" }, { - "id": "socket2 0.5.9", + "id": "socket2 0.6.1", "target": "socket2" }, { @@ -63712,7 +63712,7 @@ ], "cfg(not(all(target_family = \"wasm\", target_os = \"unknown\")))": [ { - "id": "socket2 0.5.9", + "id": "socket2 0.6.1", "target": "socket2" } ] @@ -70312,7 +70312,7 @@ "alias": "libc_errno" }, { - "id": "windows-sys 0.59.0", + "id": "windows-sys 0.61.2", "target": "windows_sys" } ], @@ -71268,7 +71268,7 @@ ], "cfg(windows)": [ { - "id": "windows-sys 0.59.0", + "id": "windows-sys 0.61.2", "target": "windows_sys" } ] @@ -71383,7 +71383,7 @@ ], "cfg(windows)": [ { - "id": "windows-sys 0.59.0", + "id": "windows-sys 0.61.2", "target": "windows_sys" } ] @@ -81524,7 +81524,7 @@ ], "cfg(windows)": [ { - "id": "windows-sys 0.59.0", + "id": "windows-sys 0.61.2", "target": "windows_sys" } ], @@ -101374,7 +101374,7 @@ "erased-serde 0.3.28", "escargot 0.5.7", "ethers-core 2.0.8", - "ethnum 1.3.2", + "ethnum 1.5.3", "evm_rpc_client 0.4.0", "evm_rpc_types 3.1.1", "exec 0.3.1", diff --git a/Cargo.Bazel.toml.lock b/Cargo.Bazel.toml.lock index 781b04af0bb0..22c1db8dee34 100644 --- a/Cargo.Bazel.toml.lock +++ b/Cargo.Bazel.toml.lock @@ -4093,7 +4093,7 @@ dependencies = [ "libc", "option-ext", "redox_users 0.5.0", - "windows-sys 0.59.0", + "windows-sys 0.61.2", ] [[package]] @@ -4555,9 +4555,9 @@ dependencies = [ [[package]] name = "ethnum" -version = "1.3.2" +version = "1.5.3" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "0198b9d0078e0f30dedc7acbb21c974e838fc8fae3ee170128658a98cb2c1c04" +checksum = "40404c3f5f511ec4da6fe866ddf6a717c309fdbb69fbbad7b0f3edab8f2e835f" dependencies = [ "serde", ] @@ -5938,7 +5938,7 @@ dependencies = [ "libc", "percent-encoding", "pin-project-lite", - "socket2 0.5.9", + "socket2 0.6.1", "system-configuration 0.7.0", "tokio", "tower-layer", @@ -10787,7 +10787,7 @@ dependencies = [ "quinn-udp", "rustc-hash 2.1.1", "rustls 0.23.27", - "socket2 0.5.9", + "socket2 0.6.1", "thiserror 2.0.18", "tokio", "tracing", @@ -11819,7 +11819,7 @@ dependencies = [ "errno 0.3.10", "libc", "linux-raw-sys 0.12.1", - "windows-sys 0.59.0", + "windows-sys 0.61.2", ] [[package]] @@ -11962,7 +11962,7 @@ dependencies = [ "security-framework 3.5.1", "security-framework-sys", "webpki-root-certs", - "windows-sys 0.59.0", + "windows-sys 0.61.2", ] [[package]] @@ -11983,7 +11983,7 @@ dependencies = [ "security-framework 3.5.1", "security-framework-sys", "webpki-root-certs", - "windows-sys 0.59.0", + "windows-sys 0.61.2", ] [[package]] @@ -13657,7 +13657,7 @@ dependencies = [ "getrandom 0.3.4", "once_cell", "rustix 1.1.4", - "windows-sys 0.59.0", + "windows-sys 0.61.2", ] [[package]] diff --git a/Cargo.lock b/Cargo.lock index 5945998238af..67728f4621f2 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1292,7 +1292,7 @@ dependencies = [ "bitflags 2.11.0", "cexpr", "clang-sys", - "itertools 0.10.5", + "itertools 0.13.0", "log", "prettyplease", "proc-macro2", @@ -4543,9 +4543,9 @@ dependencies = [ [[package]] name = "ethnum" -version = "1.5.2" +version = "1.5.3" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "ca81e6b4777c89fd810c25a4be2b1bd93ea034fbe58e6a75216a34c6b82c539b" +checksum = "40404c3f5f511ec4da6fe866ddf6a717c309fdbb69fbbad7b0f3edab8f2e835f" dependencies = [ "serde", ] @@ -6112,7 +6112,7 @@ dependencies = [ "httpdate", "itoa", "pin-project-lite", - "socket2 0.4.10", + "socket2 0.5.10", "tokio", "tower-service", "tracing", @@ -20617,7 +20617,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "22505a5c94da8e3b7c2996394d1c933236c4d743e81a410bcca4e6989fc066a4" dependencies = [ "bytes", - "heck 0.4.1", + "heck 0.5.0", "itertools 0.12.1", "log", "multimap", @@ -20637,12 +20637,12 @@ version = "0.13.5" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "be769465445e8c1474e9c5dac2018218498557af32d9ed057325ec9a41ae81bf" dependencies = [ - "heck 0.4.1", - "itertools 0.10.5", + "heck 0.5.0", + "itertools 0.14.0", "log", "multimap", "once_cell", - "petgraph 0.6.5", + "petgraph 0.7.1", "prettyplease", "prost 0.13.5", "prost-types 0.13.5", @@ -20671,7 +20671,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "8a56d757972c98b346a9b766e3f02746cde6dd1cd1d1d563472929fdd74bec4d" dependencies = [ "anyhow", - "itertools 0.10.5", + "itertools 0.14.0", "proc-macro2", "quote", "syn 2.0.117", @@ -20684,7 +20684,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "27c6023962132f4b30eb4c172c91ce92d933da334c59c23cddee82358ddafb0b" dependencies = [ "anyhow", - "itertools 0.10.5", + "itertools 0.14.0", "proc-macro2", "quote", "syn 2.0.117", @@ -23453,7 +23453,7 @@ version = "0.8.9" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "c1c97747dbf44bb1ca44a561ece23508e99cb592e862f22222dcf42f51d1e451" dependencies = [ - "heck 0.4.1", + "heck 0.5.0", "proc-macro2", "quote", "syn 2.0.117", diff --git a/Cargo.toml b/Cargo.toml index e0a02b0c8150..97d21c2efe98 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -653,7 +653,7 @@ ed25519-dalek = { version = "2.2.0", features = [ "pem", "hazmat", ] } -ethnum = { version = "1.3.2", features = ["serde"] } +ethnum = { version = "1.5.3", features = ["serde"] } evm_rpc_client = "0.4.0" evm_rpc_types = "3.1.0" flate2 = "1.0.31" diff --git a/bazel/rust.MODULE.bazel b/bazel/rust.MODULE.bazel index 0898e7c44199..ca9b9dbe4242 100644 --- a/bazel/rust.MODULE.bazel +++ b/bazel/rust.MODULE.bazel @@ -455,7 +455,7 @@ crate.spec( crate.spec( features = ["serde"], package = "ethnum", - version = "^1.3.2", + version = "^1.5.3", ) crate.spec( package = "evm_rpc_client", diff --git a/rs/bitcoin/ckbtc/minter/src/state.rs b/rs/bitcoin/ckbtc/minter/src/state.rs index 22af29faba49..d4461eff1c02 100644 --- a/rs/bitcoin/ckbtc/minter/src/state.rs +++ b/rs/bitcoin/ckbtc/minter/src/state.rs @@ -1230,13 +1230,7 @@ impl CkBtcMinterState { ) -> Option<&ConsolidateUtxosRequest> { self.current_consolidate_utxos_request .as_ref() - .and_then(|req| { - if req.block_index == block_index { - Some(req) - } else { - None - } - }) + .filter(|&req| req.block_index == block_index) } /// Push a new ConsolidateUtxosRequest. @@ -1821,7 +1815,7 @@ impl CkBtcMinterState { .get(&input.previous_output) .copied() .unwrap_or_else(|| { - panic!("BUG: no account for outpoint {:?}", &input.previous_output) + panic!("BUG: no account for outpoint {:?}", input.previous_output) }), ) } diff --git a/rs/bitcoin/ckbtc/minter/src/state/eventlog.rs b/rs/bitcoin/ckbtc/minter/src/state/eventlog.rs index bfbebd53ca23..7e030907a8de 100644 --- a/rs/bitcoin/ckbtc/minter/src/state/eventlog.rs +++ b/rs/bitcoin/ckbtc/minter/src/state/eventlog.rs @@ -496,7 +496,7 @@ impl EventLogger for CkBtcEventLogger { None => { return Err(ReplayLogError::InconsistentLog(format!( "Cannot replace a non-existent transaction {}", - &old_txid + old_txid ))); } }; diff --git a/rs/bitcoin/ckbtc/minter/src/tx.rs b/rs/bitcoin/ckbtc/minter/src/tx.rs index c2ff51329f7d..1d201b76cee8 100644 --- a/rs/bitcoin/ckbtc/minter/src/tx.rs +++ b/rs/bitcoin/ckbtc/minter/src/tx.rs @@ -42,7 +42,7 @@ pub struct DisplayOutpoint<'a>(pub &'a OutPoint); impl fmt::Display for DisplayOutpoint<'_> { fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result { - write!(fmt, "{}:{}", &self.0.txid, self.0.vout) + write!(fmt, "{}:{}", self.0.txid, self.0.vout) } } diff --git a/rs/boundary_node/ic_boundary/src/rate_limiting/generic.rs b/rs/boundary_node/ic_boundary/src/rate_limiting/generic.rs index d401275faff3..b2eadd46e29f 100644 --- a/rs/boundary_node/ic_boundary/src/rate_limiting/generic.rs +++ b/rs/boundary_node/ic_boundary/src/rate_limiting/generic.rs @@ -110,13 +110,8 @@ impl Bucket { } if let Some(v) = self.rule.canister_id { - if let Some(x) = ctx.canister_id { - // If we have a canister id - compare it - if x != v { - return None; - } - } else { - // Otherwise ignore this rule + // If we have a canister id - compare it, otherwise ignore this rule + if ctx.canister_id? != v { return None; } } @@ -127,14 +122,10 @@ impl Bucket { return None; } - if let Some(rgx) = &self.rule.methods_regex { - if let Some(v) = ctx.method { - if !rgx.is_match(v) { - return None; - } - } else { - return None; - } + if let Some(rgx) = &self.rule.methods_regex + && !rgx.is_match(ctx.method?) + { + return None; } if let Some(v) = self.rule.ip diff --git a/rs/canister_client/src/cbor.rs b/rs/canister_client/src/cbor.rs index 7c90052ba499..3a7ce27f69aa 100644 --- a/rs/canister_client/src/cbor.rs +++ b/rs/canister_client/src/cbor.rs @@ -30,7 +30,7 @@ pub fn parse_query_response(message: &CBOR) -> Result { )), None => Err(format!( "Key '{:?}' not found in '{:?}'", - status_key, &content + status_key, content )), }?; diff --git a/rs/canister_client/src/http_client.rs b/rs/canister_client/src/http_client.rs index 285c1af2da3a..4fb0b2fb42a3 100644 --- a/rs/canister_client/src/http_client.rs +++ b/rs/canister_client/src/http_client.rs @@ -240,7 +240,7 @@ impl HttpClient { let readable_response = if is_update_call { format!("{:?}", serde_cbor::from_slice::(&parsed_body)) } else { - format!("{:?}", &std::str::from_utf8(&parsed_body)) + format!("{:?}", std::str::from_utf8(&parsed_body)) }; return Err(format!( diff --git a/rs/canister_sandbox/src/replica_controller/sandboxed_execution_controller.rs b/rs/canister_sandbox/src/replica_controller/sandboxed_execution_controller.rs index 5254b289e050..f18c99882c0c 100644 --- a/rs/canister_sandbox/src/replica_controller/sandboxed_execution_controller.rs +++ b/rs/canister_sandbox/src/replica_controller/sandboxed_execution_controller.rs @@ -1519,7 +1519,7 @@ impl SandboxedExecutionController { .get_ref() .resource_limits() .maximum_state_delta - .and_then(|d| if d.get() != 0 { Some(d) } else { None }) + .filter(|&d| d.get() != 0) .unwrap_or(self.default_subnet_heap_delta_capacity); heap_delta_capacity / MAX_SANDBOXES_RSS_TO_HEAP_DELTA_RATIO } diff --git a/rs/canister_sandbox/src/rpc.rs b/rs/canister_sandbox/src/rpc.rs index 35956df1b834..4af14791ac77 100644 --- a/rs/canister_sandbox/src/rpc.rs +++ b/rs/canister_sandbox/src/rpc.rs @@ -252,7 +252,7 @@ impl ReplyManager { pub fn flush_with_errors(&self) { let mut mut_repr = self.repr.lock().unwrap(); - for (_cookie, cell) in mut_repr.cells.iter() { + for cell in mut_repr.cells.values() { cell.post_result(Err(Error::ServerError)); } mut_repr.cells.clear(); diff --git a/rs/config/src/crypto.rs b/rs/config/src/crypto.rs index 38e21b210d67..29dde0c84136 100644 --- a/rs/config/src/crypto.rs +++ b/rs/config/src/crypto.rs @@ -156,7 +156,7 @@ impl CryptoConfig { if permissions_owner != 0o700 { return Err(format!( "Crypto state directory {} has permissions {:#o}, disallowing owner access", - &dir.display(), + dir.display(), unix_permission_bits )); } @@ -164,7 +164,7 @@ impl CryptoConfig { if permissions_all != 0 { return Err(format!( "Crypto state directory {} has permissions {:#o}, allowing general access", - &dir.display(), + dir.display(), unix_permission_bits )); } diff --git a/rs/consensus/dkg/src/remote.rs b/rs/consensus/dkg/src/remote.rs index 064afda4dd83..ebe6c41b1b02 100644 --- a/rs/consensus/dkg/src/remote.rs +++ b/rs/consensus/dkg/src/remote.rs @@ -147,7 +147,7 @@ impl<'a> RemoteDkgContext<'a> { else { let err = format!( "Failed to find resharing transcript for a remote dkg for tag {:?}", - &dkg_id.dkg_tag + dkg_id.dkg_tag ); return Ok(Err(vec![(dkg_id, err)])); }; diff --git a/rs/crypto/internal/crypto_service_provider/src/vault/local_csp_vault/idkg/mod.rs b/rs/crypto/internal/crypto_service_provider/src/vault/local_csp_vault/idkg/mod.rs index 7bc6c2bc65ce..47725b5fcb75 100644 --- a/rs/crypto/internal/crypto_service_provider/src/vault/local_csp_vault/idkg/mod.rs +++ b/rs/crypto/internal/crypto_service_provider/src/vault/local_csp_vault/idkg/mod.rs @@ -836,7 +836,7 @@ fn idkg_retain_active_dealing_encryption_public_keys( PublicKeyRetainError::OldestPublicKeyNotFound => IDkgRetainKeysError::InternalError { internal_error: format!( "Could not find oldest IDKG public key {:?} locally", - &oldest_public_key + oldest_public_key ), }, }) @@ -863,7 +863,7 @@ fn would_idkg_retain_modify_public_key_store( IDkgRetainKeysError::InternalError { internal_error: format!( "Could not find oldest IDKG public key {:?} locally", - &oldest_public_key + oldest_public_key ), } } diff --git a/rs/crypto/internal/crypto_service_provider/src/vault/remote_csp_vault/tarpc_csp_vault_server.rs b/rs/crypto/internal/crypto_service_provider/src/vault/remote_csp_vault/tarpc_csp_vault_server.rs index 3845fe21363f..381a7762ac36 100644 --- a/rs/crypto/internal/crypto_service_provider/src/vault/remote_csp_vault/tarpc_csp_vault_server.rs +++ b/rs/crypto/internal/crypto_service_provider/src/vault/remote_csp_vault/tarpc_csp_vault_server.rs @@ -686,7 +686,7 @@ impl TarpcCspVaultServerImpl { let (conn, _addr) = self.listener.accept().await.unwrap_or_else(|e| { panic!( "Error listening at socket {:?}: {}", - &self.listener.local_addr(), + self.listener.local_addr(), e ) }); diff --git a/rs/crypto/sha2/src/context/mod.rs b/rs/crypto/sha2/src/context/mod.rs index 1db9b3e037ab..8a1e3cca2537 100644 --- a/rs/crypto/sha2/src/context/mod.rs +++ b/rs/crypto/sha2/src/context/mod.rs @@ -49,7 +49,7 @@ impl fmt::Debug for DomainSeparationContext { write!( f, "DomainSeparationContext{{ domain: \"{}\" }}", - &self.domain + self.domain ) } } diff --git a/rs/crypto/src/vetkd/mod.rs b/rs/crypto/src/vetkd/mod.rs index d000eefc3973..925c4c3238c9 100644 --- a/rs/crypto/src/vetkd/mod.rs +++ b/rs/crypto/src/vetkd/mod.rs @@ -221,7 +221,7 @@ fn create_encrypted_key_share_internal( .ok_or_else(|| { VetKdKeyShareCreationError::InternalError(format!( "public coefficients for NI-DKG ID {} are empty", - &args.ni_dkg_id + args.ni_dkg_id )) })?, }; diff --git a/rs/embedders/src/wasm_utils/validation.rs b/rs/embedders/src/wasm_utils/validation.rs index 2543db5194b6..b8501306e1e4 100644 --- a/rs/embedders/src/wasm_utils/validation.rs +++ b/rs/embedders/src/wasm_utils/validation.rs @@ -1045,7 +1045,7 @@ fn validate_import_section(module: &Module) -> Result MultiKeyMap { Key: Clone, { let mut to_remove = Vec::new(); - for (key, _alt_key) in self.by_key.iter() { + for key in self.by_key.keys() { if predicate(key) { to_remove.push(key.clone()); } diff --git a/rs/execution_environment/src/canister_manager/types.rs b/rs/execution_environment/src/canister_manager/types.rs index 83b69be5b19f..ce0c9e536584 100644 --- a/rs/execution_environment/src/canister_manager/types.rs +++ b/rs/execution_environment/src/canister_manager/types.rs @@ -806,7 +806,7 @@ impl From for UserError { ), CanisterNotFound(canister_id) => Self::new( ErrorCode::CanisterNotFound, - format!("Canister {} not found.{additional_help}", &canister_id), + format!("Canister {} not found.{additional_help}", canister_id), ), CanisterIdAlreadyExists(canister_id) => Self::new( ErrorCode::CanisterIdAlreadyExists, diff --git a/rs/execution_environment/src/execution_environment.rs b/rs/execution_environment/src/execution_environment.rs index ff1adee2dede..d4dd58c2e263 100644 --- a/rs/execution_environment/src/execution_environment.rs +++ b/rs/execution_environment/src/execution_environment.rs @@ -664,7 +664,7 @@ impl ExecutionEnvironment { None => { let err = UserError::new( ErrorCode::CanisterNotFound, - format!("Canister {} not found.", &canister_id), + format!("Canister {} not found.", canister_id), ); ExecuteSubnetMessageResult::Finished { response: Err(err), @@ -2701,7 +2701,7 @@ impl ExecutionEnvironment { None => { let err = UserError::new( ErrorCode::CanisterNotFound, - format!("Canister {} not found.", &canister_id), + format!("Canister {} not found.", canister_id), ); ExecuteSubnetMessageResult::Finished { response: Err(err), @@ -2993,7 +2993,7 @@ impl ExecutionEnvironment { return ExecuteSubnetMessageResult::Finished { response: Err(UserError::new( ErrorCode::CanisterNotFound, - format!("Canister {} not found.", &canister_id), + format!("Canister {} not found.", canister_id), )), refund: msg.take_cycles(), }; @@ -4875,7 +4875,7 @@ fn get_canister( Some(canister) => Ok(canister), None => Err(UserError::new( ErrorCode::CanisterNotFound, - format!("Canister {} not found.", &canister_id), + format!("Canister {} not found.", canister_id), )), } } @@ -4892,7 +4892,7 @@ fn canister_make_mut( Some(canister) => Ok(canister), None => Err(UserError::new( ErrorCode::CanisterNotFound, - format!("Canister {} not found.", &canister_id), + format!("Canister {} not found.", canister_id), )), } } diff --git a/rs/execution_environment/src/scheduler.rs b/rs/execution_environment/src/scheduler.rs index 6cee1ed5b1db..74e58d9cf30d 100644 --- a/rs/execution_environment/src/scheduler.rs +++ b/rs/execution_environment/src/scheduler.rs @@ -2131,13 +2131,7 @@ fn subnet_heap_delta_capacity( ) -> NumBytes { resource_limits .maximum_state_delta - .and_then(|maximum_state_delta| { - if maximum_state_delta.get() != 0 { - Some(maximum_state_delta) - } else { - None - } - }) + .filter(|&maximum_state_delta| maximum_state_delta.get() != 0) .unwrap_or(config.subnet_heap_delta_capacity) } diff --git a/rs/ic_os/build_tools/dflate/src/main.rs b/rs/ic_os/build_tools/dflate/src/main.rs index ee38724a16d6..6794fa6c435d 100644 --- a/rs/ic_os/build_tools/dflate/src/main.rs +++ b/rs/ic_os/build_tools/dflate/src/main.rs @@ -27,7 +27,7 @@ fn main() -> Result<()> { let mut source = File::open(&file)?; let file_name = file .file_name() - .ok_or(anyhow!("Invalid path: '{}'", &file.display()))? + .ok_or(anyhow!("Invalid path: '{}'", file.display()))? .to_string_lossy() .into_owned(); diff --git a/rs/ic_os/networking/network/src/interfaces.rs b/rs/ic_os/networking/network/src/interfaces.rs index 68a56e81cc2c..6d18c739c2ae 100644 --- a/rs/ic_os/networking/network/src/interfaces.rs +++ b/rs/ic_os/networking/network/src/interfaces.rs @@ -28,11 +28,7 @@ pub fn has_ipv6_connectivity( // Format with the prefix length let ip = format!("{generated_ipv6}/{ipv6_prefix_length}"); - eprintln!( - "Bringing {} up with ip address {}", - &interface.name, - &ip.to_string() - ); + eprintln!("Bringing {} up with ip address {}", interface.name, ip); get_command_stdout("ip", &["addr", "add", &ip, "dev", &interface.name])?; activate_link(&interface.name)?; diff --git a/rs/ic_os/networking/network/src/systemd.rs b/rs/ic_os/networking/network/src/systemd.rs index d20a54e21f63..0165fe06a6a4 100644 --- a/rs/ic_os/networking/network/src/systemd.rs +++ b/rs/ic_os/networking/network/src/systemd.rs @@ -93,7 +93,7 @@ pub fn generate_systemd_config_files( match has_ipv6_connectivity(i, ipv6_address, ipv6_config.prefix_length, &ping_target) { Ok(result) => result, Err(e) => { - eprintln!("Error testing connectivity on {}: {}", &i.name, e); + eprintln!("Error testing connectivity on {}: {}", i.name, e); false } } @@ -103,11 +103,7 @@ pub fn generate_systemd_config_files( eprintln!("Using fastest interface: {fastest_interface:?}"); // Format the IP address to include the subnet length. See `man systemd.network`. - let ipv6_address = format!( - "{}/{}", - &ipv6_address.to_string(), - ipv6_config.prefix_length - ); + let ipv6_address = format!("{}/{}", ipv6_address, ipv6_config.prefix_length); generate_and_write_systemd_files( output_directory, fastest_interface, diff --git a/rs/interfaces/src/execution_environment/errors.rs b/rs/interfaces/src/execution_environment/errors.rs index d03b3f4a9202..7c40b9bf1fed 100644 --- a/rs/interfaces/src/execution_environment/errors.rs +++ b/rs/interfaces/src/execution_environment/errors.rs @@ -532,9 +532,9 @@ impl HypervisorError { let help = format!("{}", self.error_help()); let description = if help.is_empty() { - format!("Error from Canister {}: {}", canister_id, &self,) + format!("Error from Canister {}: {}", canister_id, self) } else { - format!("Error from Canister {}: {}.\n{}", canister_id, &self, help) + format!("Error from Canister {}: {}.\n{}", canister_id, self, help) }; let code = match self { diff --git a/rs/ledger_suite/test_utils/in_memory_ledger/src/lib.rs b/rs/ledger_suite/test_utils/in_memory_ledger/src/lib.rs index 7f8464add27a..fcb6cd6ab5e7 100644 --- a/rs/ledger_suite/test_utils/in_memory_ledger/src/lib.rs +++ b/rs/ledger_suite/test_utils/in_memory_ledger/src/lib.rs @@ -771,8 +771,8 @@ where assert!( !allowance.amount.is_zero(), "Expected allowance is zero! Should not happen... from: {:?}, spender: {:?}", - &from, - &spender + from, + spender ); let actual_allowance = AccountId::get_allowance(env, ledger_id, from, spender); if let Some(in_memory_expires_at) = allowance.expires_at @@ -782,12 +782,12 @@ where Tokens::zero(), Tokens::try_from(actual_allowance.allowance.clone()).unwrap(), "Expected amount of expired actual allowance to be zero, but it is not: {:?}", - &actual_allowance + actual_allowance ); assert!( actual_allowance.expires_at.is_none(), "Expected expired actual allowance to have no expires_at, but it has one: {:?}", - &actual_allowance + actual_allowance ); allowances_checked += 1; continue; @@ -810,8 +810,8 @@ where allowance.amount, Tokens::try_from(actual_allowance.allowance.clone()).unwrap(), "Mismatch in allowance for approval from {:?} spender {:?}: {:?} ({:?} vs {:?}) at {:?}", - &from, - &spender, + from, + spender, approval, allowance, actual_allowance, @@ -821,8 +821,8 @@ where allowance.expires_at.map(|t| t.as_nanos_since_unix_epoch()), actual_allowance.expires_at, "Mismatch in allowance expiration for approval from {:?} spender {:?}: {:?} ({:?} vs {:?}) at {:?}", - &from, - &spender, + from, + spender, approval, allowance, actual_allowance, diff --git a/rs/nns/governance/src/governance.rs b/rs/nns/governance/src/governance.rs index 01a682ce04bf..920b03cf1cb5 100644 --- a/rs/nns/governance/src/governance.rs +++ b/rs/nns/governance/src/governance.rs @@ -1202,7 +1202,7 @@ impl TryFrom Err(vec!["Request.nns_proposal_id is unspecified.".to_string()]) } }; - let request_str = format!("{:#?}", &request); + let request_str = format!("{:#?}", request); // Validate request.result let swap_result = if let Some(result) = request.result { SwapResult::try_from(result).map_err(|err| vec![err]) diff --git a/rs/nns/governance/src/neuron_data_validation.rs b/rs/nns/governance/src/neuron_data_validation.rs index 9afb7521ffae..384b8d334e98 100644 --- a/rs/nns/governance/src/neuron_data_validation.rs +++ b/rs/nns/governance/src/neuron_data_validation.rs @@ -594,11 +594,8 @@ impl CardinalityAndRangeValidator for KnownNeuronIndexValidator { neuron: &Neuron, ) -> Option { let neuron_id = neuron.id(); - let known_neuron_name = match neuron.known_neuron_data() { - // Most neurons aren't known neurons. - None => return None, - Some(known_neuron_data) => &known_neuron_data.name, - }; + // Most neurons aren't known neurons. + let known_neuron_name = &neuron.known_neuron_data()?.name; let index_has_entry = with_stable_neuron_indexes(|indexes| { indexes .known_neuron() diff --git a/rs/nns/test_utils/src/gtc_helpers.rs b/rs/nns/test_utils/src/gtc_helpers.rs index 73ea1fb3a3fb..e65673ba2984 100644 --- a/rs/nns/test_utils/src/gtc_helpers.rs +++ b/rs/nns/test_utils/src/gtc_helpers.rs @@ -139,7 +139,7 @@ impl GenesisTokenCanisterInitPayloadBuilder { println!( "Seed used in generating GTC release schedule is: {:?}", - &seed + seed ); let rng = StdRng::from_seed(seed); diff --git a/rs/nns/test_utils/src/registry.rs b/rs/nns/test_utils/src/registry.rs index 044a9126b4a7..f10679ae780a 100644 --- a/rs/nns/test_utils/src/registry.rs +++ b/rs/nns/test_utils/src/registry.rs @@ -407,7 +407,7 @@ pub fn new_node_keys_and_node_id() -> (ValidNodePublicKeys, NodeId) { let npks = generate_node_keys_once(&config, None).unwrap_or_else(|_| { panic!( "Generation of new node keys with CryptoConfig {:?} failed", - &config + config ) }); let node_id = npks.node_id(); diff --git a/rs/orchestrator/src/catch_up_package_provider.rs b/rs/orchestrator/src/catch_up_package_provider.rs index 641c7e4c9d0d..19038740a92a 100644 --- a/rs/orchestrator/src/catch_up_package_provider.rs +++ b/rs/orchestrator/src/catch_up_package_provider.rs @@ -425,7 +425,7 @@ impl CatchUpPackageProvider { ); write_protobuf_using_tmp_file(&cup_file_path, cup_proto).map_err(|e| { OrchestratorError::IoError( - format!("Failed to serialize protobuf to disk: {:?}", &cup_file_path), + format!("Failed to serialize protobuf to disk: {:?}", cup_file_path), e, ) })?; diff --git a/rs/prep/src/internet_computer.rs b/rs/prep/src/internet_computer.rs index 09acd2960191..475c5a62395b 100644 --- a/rs/prep/src/internet_computer.rs +++ b/rs/prep/src/internet_computer.rs @@ -190,15 +190,15 @@ impl TopologyConfig { /// Set node operator on nodes that don't already have one set. pub fn with_initial_node_operator(mut self, node_operator: PrincipalId) -> Self { - for (_, sc) in self.subnets.iter_mut() { - for (_, nc) in sc.membership.iter_mut() { + for sc in self.subnets.values_mut() { + for nc in sc.membership.values_mut() { if nc.node_operator_principal_id.is_none() { nc.node_operator_principal_id = Some(node_operator); } } } - for (_, nc) in self.unassigned_nodes.iter_mut() { + for nc in self.unassigned_nodes.values_mut() { if nc.node_operator_principal_id.is_none() { nc.node_operator_principal_id = Some(node_operator); } diff --git a/rs/registry/admin/bin/main.rs b/rs/registry/admin/bin/main.rs index d014456e3900..850408ea91cd 100644 --- a/rs/registry/admin/bin/main.rs +++ b/rs/registry/admin/bin/main.rs @@ -1469,7 +1469,7 @@ impl ProposalTitle for ProposeToChangeNnsCanisterCmd { Some(title) => title.clone(), None => format!( "Upgrade NNS Canister: {} to wasm with hash: {}", - self.canister_id, &self.wasm_module_sha256 + self.canister_id, self.wasm_module_sha256 ), } } @@ -1554,7 +1554,7 @@ impl ProposalTitle for ProposeToHardResetNnsRootToVersionCmd { Some(title) => title.clone(), None => format!( "Hard reset NNS root to wasm with hash: {}", - &self.wasm_module_sha256 + self.wasm_module_sha256 ), } } @@ -3082,7 +3082,7 @@ impl ProposalPayload for ProposeToAddOrRe let payload = self.get_payload(); if !self.skip_confirmation { - println!("\n{}", &payload); + println!("\n{}", payload); println!("Is the above payload correct? [Y/n]"); let mut buffer = String::new(); diff --git a/rs/registry/canister/src/invariants/endpoint.rs b/rs/registry/canister/src/invariants/endpoint.rs index 83d50e0acc3b..a09441668993 100644 --- a/rs/registry/canister/src/invariants/endpoint.rs +++ b/rs/registry/canister/src/invariants/endpoint.rs @@ -67,7 +67,7 @@ pub(crate) fn check_endpoint_invariants( return Err(InvariantCheckError { msg: format!( "{error_prefix}: Duplicate endpoint ({:?}, {:?}); previous endpoints: {new_valid_endpoints:?}", - &endpoint.ip_addr, &endpoint.port + endpoint.ip_addr, endpoint.port ), source: None, }); diff --git a/rs/registry/canister/src/mutations/do_add_or_remove_data_centers.rs b/rs/registry/canister/src/mutations/do_add_or_remove_data_centers.rs index 3562f1f0dd6d..6bd4c4b8470b 100644 --- a/rs/registry/canister/src/mutations/do_add_or_remove_data_centers.rs +++ b/rs/registry/canister/src/mutations/do_add_or_remove_data_centers.rs @@ -13,10 +13,7 @@ impl Registry { &mut self, payload: AddOrRemoveDataCentersProposalPayload, ) { - println!( - "{}do_add_or_remove_data_centers: {:?}", - LOG_PREFIX, &payload - ); + println!("{}do_add_or_remove_data_centers: {:?}", LOG_PREFIX, payload); let mut mutations = vec![]; @@ -40,7 +37,7 @@ impl Registry { if self.get(key.as_bytes(), latest_version).is_some() { panic!( "{}do_add_or_remove_data_centers: Cannot add DataCenterRecord with ID: '{}' already exists", - LOG_PREFIX, &dc.id + LOG_PREFIX, dc.id ); } @@ -53,7 +50,7 @@ impl Registry { Err(msg) => { println!( "{}do_add_or_remove_data_centers: invalid DataCenterRecord: {}, {:?}", - LOG_PREFIX, msg, &dc + LOG_PREFIX, msg, dc ); } } diff --git a/rs/registry/nns_data_provider/src/registry.rs b/rs/registry/nns_data_provider/src/registry.rs index f84c9cfa6db3..21f2e565cc28 100644 --- a/rs/registry/nns_data_provider/src/registry.rs +++ b/rs/registry/nns_data_provider/src/registry.rs @@ -225,7 +225,7 @@ impl RegistryCanister { }, Err(error_string) => Err(ic_registry_transport::Error::UnknownError(format!( "Error on registry_get_value_since: {} using agent {:?}", - error_string, &agent + error_string, agent ))), } } diff --git a/rs/replay/src/backup.rs b/rs/replay/src/backup.rs index d6f8aa788bd7..9c04a186af72 100644 --- a/rs/replay/src/backup.rs +++ b/rs/replay/src/backup.rs @@ -431,7 +431,7 @@ pub(crate) fn deserialize_consensus_artifacts( artifact_path.exists(), "Path to invalid artifact doesn't exist." ); - println!("Invalid artifact detected: {:?}", &artifact_path); + println!("Invalid artifact detected: {:?}", artifact_path); rename_file(&artifact_path); return Err(ExitPoint::ValidationIncomplete(height)); } diff --git a/rs/replay/src/player.rs b/rs/replay/src/player.rs index d7ee0cfd85d7..a4f889d7a377 100644 --- a/rs/replay/src/player.rs +++ b/rs/replay/src/player.rs @@ -442,7 +442,7 @@ impl Player { Some(printer) => printer(bytes), _ => println!( "Ingress id={} response={}", - &msg.ingress.id(), + msg.ingress.id(), hex::encode(bytes) ), }, @@ -682,7 +682,7 @@ impl Player { /// Fetch registry records from the given `nns_url`, and update the local /// registry store with the new records. pub fn update_registry_local_store(&self) { - println!("RegistryLocalStore path: {:?}", &self.local_store_path); + println!("RegistryLocalStore path: {:?}", self.local_store_path); let latest_version = self.registry.get_latest_version(); println!("RegistryLocalStore latest version: {latest_version}"); let records = self diff --git a/rs/replica/bin/replica/main.rs b/rs/replica/bin/replica/main.rs index 0949052c310b..2d10e085b989 100644 --- a/rs/replica/bin/replica/main.rs +++ b/rs/replica/bin/replica/main.rs @@ -351,7 +351,7 @@ fn frames_post_processor() -> impl Fn(&mut pprof::Frames) { #[cfg(feature = "profiler")] fn finalize_report(guard: &ProfilerGuard) { if let Ok(report) = guard.report().build() { - println!("report: {:?}", &report); + println!("report: {:?}", report); let file = File::create("flamegraph.svg").unwrap(); report.flamegraph(file).unwrap(); @@ -363,7 +363,7 @@ fn finalize_report(guard: &ProfilerGuard) { profile.encode(&mut content).unwrap(); file.write_all(&content).unwrap(); - println!("report: {:?}", &report); + println!("report: {:?}", report); }; if let Ok(report) = guard diff --git a/rs/rosetta-api/common/rosetta_core/src/identifiers.rs b/rs/rosetta-api/common/rosetta_core/src/identifiers.rs index d99736af0d88..24dc1d383f94 100644 --- a/rs/rosetta-api/common/rosetta_core/src/identifiers.rs +++ b/rs/rosetta-api/common/rosetta_core/src/identifiers.rs @@ -231,7 +231,7 @@ impl TryFrom for icrc_ledger_types::icrc1::account::Account { owner: Principal::from_str(&value.address).with_context(|| { format!( "Unable to convert accountidentifier.address {:?} to Principal", - &value.address + value.address ) })?, subaccount, @@ -268,7 +268,7 @@ impl TryFrom for icp_ledger::AccountIdentifier { icp_ledger::AccountIdentifier::from_hex(&value.address).map_err(|err| { anyhow!( "Unable to convert accountidentifier.address {:?} to AccountIdentifier. Error: {:?}", - &value.address, + value.address, err ) }) diff --git a/rs/rosetta-api/icp/src/request_handler.rs b/rs/rosetta-api/icp/src/request_handler.rs index b07d297e7dde..471377b28b89 100644 --- a/rs/rosetta-api/icp/src/request_handler.rs +++ b/rs/rosetta-api/icp/src/request_handler.rs @@ -182,7 +182,7 @@ impl RosettaRequestHandler { .map_err(|e| { ApiError::invalid_account_id(format!( "Account {} is not valid address, {}", - &msg.account_identifier.address, e, + msg.account_identifier.address, e, )) })?; let block = self.get_block(msg.block_identifier).await?; diff --git a/rs/rust_canisters/canister_test/src/canister.rs b/rs/rust_canisters/canister_test/src/canister.rs index 334a41a667a6..b8f95427d0d8 100644 --- a/rs/rust_canisters/canister_test/src/canister.rs +++ b/rs/rust_canisters/canister_test/src/canister.rs @@ -260,11 +260,11 @@ where Ok(v) => return Ok(v), Err(e) => match backoff.next_backoff() { Some(interval) => { - eprintln!("Retrying due to: {}", &e); + eprintln!("Retrying due to: {}", e); tokio::time::sleep(interval).await; } None => { - eprintln!("Failed due to: {}", &e); + eprintln!("Failed due to: {}", e); return Err(e); } }, @@ -1109,7 +1109,7 @@ impl<'a> Install<'a> { self.wasm.0.clone(), payload, ); - eprintln!("Install args: {}", &install_args); + eprintln!("Install args: {}", install_args); match self.runtime { Runtime::Local(local_runtime) => local_runtime .install_canister_helper_async(install_args) diff --git a/rs/sns/cli/src/deploy.rs b/rs/sns/cli/src/deploy.rs index 5e5a5637c81b..738b9a21042b 100644 --- a/rs/sns/cli/src/deploy.rs +++ b/rs/sns/cli/src/deploy.rs @@ -38,7 +38,7 @@ pub fn lookup_or_else_create_canisters( } }; - println!("SNS canister IDs:\n{:?}", &sns_canister_ids); + println!("SNS canister IDs:\n{:?}", sns_canister_ids); sns_canister_ids } @@ -80,7 +80,7 @@ pub fn get_canister_id( verbose: bool, network: &String, ) -> Option { - println!("dfx canister --network {} id {}", &network, canister_name); + println!("dfx canister --network {} id {}", network, canister_name); let output = call_dfx(&["canister", "--network", network, "id", canister_name]); let canister_id = String::from_utf8(output.stdout) @@ -136,7 +136,7 @@ where file.seek(SeekFrom::Start(0))?; let mut writer = BufWriter::new(file); - writeln!(&mut writer, "{}", &serde_json::to_string_pretty(&new_json)?)?; + writeln!(&mut writer, "{}", serde_json::to_string_pretty(&new_json)?)?; writer.flush()?; Ok(()) } @@ -401,7 +401,7 @@ impl DirectSnsDeployerForTests { if !output.status.success() { panic!( "Failed to add {} as a controller of {}", - &controller, canister_name + controller, canister_name ); } } diff --git a/rs/sns/governance/src/extensions.rs b/rs/sns/governance/src/extensions.rs index c199f60036f8..cdfec578c745 100644 --- a/rs/sns/governance/src/extensions.rs +++ b/rs/sns/governance/src/extensions.rs @@ -224,7 +224,7 @@ pub struct ExtensionOperationSpec { impl ExtensionOperationSpec { pub fn name(&self) -> String { - format!("{}", &self.operation_type) + format!("{}", self.operation_type) } pub fn description(&self) -> &str { diff --git a/rs/sns/governance/src/icrc_ledger_helper.rs b/rs/sns/governance/src/icrc_ledger_helper.rs index f3ccba079d2e..8604488c254e 100644 --- a/rs/sns/governance/src/icrc_ledger_helper.rs +++ b/rs/sns/governance/src/icrc_ledger_helper.rs @@ -107,7 +107,7 @@ fn decode_nat_to_u64(value: Nat) -> Result { [val] => Ok(*val), _ => Err(format!( "Nat value `{:?}` is too large, max supported value: {}", - &value, + value, u64::MAX, )), } diff --git a/rs/sns/governance/src/proposal.rs b/rs/sns/governance/src/proposal.rs index 4f9ac89caa94..efec2ae0dea9 100644 --- a/rs/sns/governance/src/proposal.rs +++ b/rs/sns/governance/src/proposal.rs @@ -520,7 +520,7 @@ fn validate_and_render_motion(motion: &Motion) -> Result { ## Motion Text: {}", - &motion.motion_text + motion.motion_text )) } @@ -544,7 +544,7 @@ fn validate_and_render_manage_nervous_system_parameters( ## New nervous system parameters: {:#?}", - ¤t_parameters, new_parameters + current_parameters, new_parameters )) } diff --git a/rs/state_layout/src/state_layout.rs b/rs/state_layout/src/state_layout.rs index 452e76b65b47..52719d50ef13 100644 --- a/rs/state_layout/src/state_layout.rs +++ b/rs/state_layout/src/state_layout.rs @@ -1313,7 +1313,7 @@ impl StateLayout { let cp_path = self.diverged_checkpoints().join(&checkpoint_name); let tmp_path = self .fs_tmp() - .join(format!("diverged_checkpoint_{}", &checkpoint_name)); + .join(format!("diverged_checkpoint_{}", checkpoint_name)); self.rename_to_tmp_path(&cp_path, &tmp_path) .map_err(|err| LayoutError::IoError { path: cp_path.clone(), @@ -1363,7 +1363,7 @@ impl StateLayout { pub fn remove_backup(&self, height: Height) -> Result<(), LayoutError> { let backup_name = Self::checkpoint_name(height); let backup_path = self.backups().join(&backup_name); - let tmp_path = self.fs_tmp().join(format!("backup_{}", &backup_name)); + let tmp_path = self.fs_tmp().join(format!("backup_{}", backup_name)); self.rename_to_tmp_path(&backup_path, &tmp_path) .map_err(|err| LayoutError::IoError { path: backup_path.clone(), diff --git a/rs/state_manager/src/state_sync/types.rs b/rs/state_manager/src/state_sync/types.rs index a55835c72420..31a4d7f6dd8c 100644 --- a/rs/state_manager/src/state_sync/types.rs +++ b/rs/state_manager/src/state_sync/types.rs @@ -515,12 +515,9 @@ impl StateSyncMessage { } } StateSyncChunk::FileGroupChunk(index) => { - if let Some(chunk_table_indices) = self.state_sync_file_group.get(&index) { - for chunk_table_index in chunk_table_indices { - payload.extend(get_single_chunk(*chunk_table_index as usize)?); - } - } else { - return None; + let chunk_table_indices = self.state_sync_file_group.get(&index)?; + for chunk_table_index in chunk_table_indices { + payload.extend(get_single_chunk(*chunk_table_index as usize)?); } } StateSyncChunk::FileChunk(index) => { diff --git a/rs/test_utilities/execution_environment/src/lib.rs b/rs/test_utilities/execution_environment/src/lib.rs index 34a5b0399948..d774eb9066a2 100644 --- a/rs/test_utilities/execution_environment/src/lib.rs +++ b/rs/test_utilities/execution_environment/src/lib.rs @@ -2047,7 +2047,7 @@ impl ExecutionTest { let mut state = self.state.take().unwrap(); let cost_schedule = state.get_own_cost_schedule(); abort_all_paused_executions(&mut state, &self.exec_env, cost_schedule, &self.log); - for (_, paused_subnet_message) in self.paused_subnet_messages.iter_mut() { + for paused_subnet_message in self.paused_subnet_messages.values_mut() { paused_subnet_message.instructions = NumInstructions::new(0); } self.state = Some(state); diff --git a/rs/tests/boundary_nodes/integration_test_common/src/lib.rs b/rs/tests/boundary_nodes/integration_test_common/src/lib.rs index 55027f9fde03..a80d563bdf38 100644 --- a/rs/tests/boundary_nodes/integration_test_common/src/lib.rs +++ b/rs/tests/boundary_nodes/integration_test_common/src/lib.rs @@ -177,7 +177,7 @@ pub fn api_query_test(env: TestEnv) { let out = agent.query(&cid, "read").call().await?; if !out.eq(&[0, 0, 0, 0]) { - bail!("{name} failed: got {:?}, expected {:?}", out, &[0, 0, 0, 0],) + bail!("{name} failed: got {:?}, expected {:?}", out, [0, 0, 0, 0],) } Ok(()) @@ -219,7 +219,7 @@ pub fn api_call_test(env: TestEnv) { let out = agent.query(&cid, "read").call().await?; if !out.eq(&[1, 0, 0, 0]) { - bail!("{name} failed: got {:?}, expected {:?}", out, &[1, 0, 0, 0],) + bail!("{name} failed: got {:?}, expected {:?}", out, [1, 0, 0, 0],) } Ok(()) @@ -256,7 +256,7 @@ pub fn api_sync_call_test(env: TestEnv) { // check that the update call went through let out = agent.query(&cid, "read").call().await?; if !out.eq(&[1, 0, 0, 0]) { - bail!("{name} failed: got {:?}, expected {:?}", out, &[1, 0, 0, 0],) + bail!("{name} failed: got {:?}, expected {:?}", out, [1, 0, 0, 0],) } Ok(()) }) diff --git a/rs/tests/crypto/rpc_csp_vault_reconnection_test.rs b/rs/tests/crypto/rpc_csp_vault_reconnection_test.rs index c20928894738..a2c37daa9941 100644 --- a/rs/tests/crypto/rpc_csp_vault_reconnection_test.rs +++ b/rs/tests/crypto/rpc_csp_vault_reconnection_test.rs @@ -128,7 +128,7 @@ impl SystemdCli<'_> { fn state(&self) -> String { let cmd = format!( "systemctl show --property ActiveState --value {}", - &self.service + self.service ); self.log_ssh_command(&cmd); self.node @@ -142,7 +142,7 @@ impl SystemdCli<'_> { info!(self.logger, "Killing {}", self.service); let cmd = format!( "sudo kill -9 $(systemctl show --property MainPID --value {})", - &self.service + self.service ); self.log_ssh_command(&cmd); self.node.block_on_bash_script(&cmd).expect("run command"); @@ -150,7 +150,7 @@ impl SystemdCli<'_> { fn stop(&self) { info!(self.logger, "Stopping {}", self.service); - let cmd = format!("sudo systemctl stop {}", &self.service); + let cmd = format!("sudo systemctl stop {}", self.service); self.log_ssh_command(&cmd); self.node.block_on_bash_script(&cmd).expect("run command"); } diff --git a/rs/tests/driver/src/driver/farm.rs b/rs/tests/driver/src/driver/farm.rs index c11949204749..cc2bd0752cdc 100644 --- a/rs/tests/driver/src/driver/farm.rs +++ b/rs/tests/driver/src/driver/farm.rs @@ -145,7 +145,7 @@ impl Farm { .override_host_features .clone() .unwrap_or_else(|| vm.required_host_features.clone()); - let path = format!("group/{}/vm/{}", group_name, &vm.name); + let path = format!("group/{}/vm/{}", group_name, vm.name); let rb = Self::json(self.post(&path), &vm); let rbb = || rb.try_clone().expect("could not clone a request builder"); let resp = self.retry_until_success_long(rbb)?; diff --git a/rs/tests/driver/src/driver/logs_stream_task.rs b/rs/tests/driver/src/driver/logs_stream_task.rs index 61122f70cafc..d6aa4da63a49 100644 --- a/rs/tests/driver/src/driver/logs_stream_task.rs +++ b/rs/tests/driver/src/driver/logs_stream_task.rs @@ -370,9 +370,9 @@ fn discover_uvms(root_path: PathBuf) -> Result> { .map(|e| e.path().to_owned()) { let file = - std::fs::File::open(&entry).with_context(|| format!("Could not open: {:?}", &entry))?; + std::fs::File::open(&entry).with_context(|| format!("Could not open: {:?}", entry))?; let vm: AllocatedVm = serde_json::from_reader(file) - .with_context(|| format!("{:?}: Could not read json.", &entry))?; + .with_context(|| format!("{:?}: Could not read json.", entry))?; uvms.insert(vm.name.to_string(), vm.ipv6); } Ok(uvms) diff --git a/rs/types/management_canister_types/src/lib.rs b/rs/types/management_canister_types/src/lib.rs index 31e694ba99e5..31f17293c443 100644 --- a/rs/types/management_canister_types/src/lib.rs +++ b/rs/types/management_canister_types/src/lib.rs @@ -2171,8 +2171,8 @@ pub struct InstallCodeArgs { impl std::fmt::Display for InstallCodeArgs { fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { writeln!(f, "InstallCodeArgs {{")?; - writeln!(f, " mode: {:?}", &self.mode)?; - writeln!(f, " canister_id: {:?}", &self.canister_id)?; + writeln!(f, " mode: {:?}", self.mode)?; + writeln!(f, " canister_id: {:?}", self.canister_id)?; writeln!(f, " wasm_module: <{:?} bytes>", self.wasm_module.len())?; writeln!(f, " arg: <{:?} bytes>", self.arg.len())?; writeln!(f, "}}") @@ -2240,8 +2240,8 @@ pub struct InstallCodeArgsV2 { impl std::fmt::Display for InstallCodeArgsV2 { fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { writeln!(f, "InstallCodeArgsV2 {{")?; - writeln!(f, " mode: {:?}", &self.mode)?; - writeln!(f, " canister_id: {:?}", &self.canister_id)?; + writeln!(f, " mode: {:?}", self.mode)?; + writeln!(f, " canister_id: {:?}", self.canister_id)?; writeln!(f, " wasm_module: <{:?} bytes>", self.wasm_module.len())?; writeln!(f, " arg: <{:?} bytes>", self.arg.len())?; writeln!(f, "}}") @@ -3969,9 +3969,9 @@ pub struct InstallChunkedCodeArgs { impl std::fmt::Display for InstallChunkedCodeArgs { fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { writeln!(f, "InstallChunkedCodeArgs {{")?; - writeln!(f, " mode: {:?}", &self.mode)?; - writeln!(f, " target_canister: {:?}", &self.target_canister)?; - writeln!(f, " store_canister: {:?}", &self.store_canister)?; + writeln!(f, " mode: {:?}", self.mode)?; + writeln!(f, " target_canister: {:?}", self.target_canister)?; + writeln!(f, " store_canister: {:?}", self.store_canister)?; writeln!(f, " arg: <{:?} bytes>", self.arg.len())?; writeln!(f, "}}") } diff --git a/rs/types/types/src/consensus/idkg.rs b/rs/types/types/src/consensus/idkg.rs index 8fc0746bddaf..7dee5cbd755a 100644 --- a/rs/types/types/src/consensus/idkg.rs +++ b/rs/types/types/src/consensus/idkg.rs @@ -129,7 +129,7 @@ impl std::borrow::Borrow for IDkgMasterPublicKeyId { impl std::fmt::Display for IDkgMasterPublicKeyId { fn fmt(&self, fmt: &mut std::fmt::Formatter<'_>) -> Result<(), std::fmt::Error> { - write!(fmt, "{}", &self.0) + write!(fmt, "{}", self.0) } } diff --git a/rs/types/types/src/crypto/error.rs b/rs/types/types/src/crypto/error.rs index 785b156d3665..40eee4546078 100644 --- a/rs/types/types/src/crypto/error.rs +++ b/rs/types/types/src/crypto/error.rs @@ -13,7 +13,7 @@ pub struct InvalidArgumentError { impl fmt::Display for InvalidArgumentError { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { - write!(f, "Semantic error in argument: {}", &self.message) + write!(f, "Semantic error in argument: {}", self.message) } } @@ -25,7 +25,7 @@ pub struct InternalError { impl fmt::Display for InternalError { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { - write!(f, "Internal error: {}", &self.internal_error) + write!(f, "Internal error: {}", self.internal_error) } } @@ -42,9 +42,9 @@ impl fmt::Display for MalformedPublicKeyError { write!( f, "Malformed {:?} public key: 0x{:?}. Internal error: {}", - &self.algorithm, - &self.key_bytes.as_ref().map(hex::encode), - &self.internal_error + self.algorithm, + self.key_bytes.as_ref().map(hex::encode), + self.internal_error ) } } @@ -62,9 +62,9 @@ impl fmt::Display for MalformedDataError { write!( f, "Malformed {:?} data: 0x{:?}. Internal error: {}", - &self.algorithm, - &self.data.as_ref().map(hex::encode), - &self.internal_error + self.algorithm, + self.data.as_ref().map(hex::encode), + self.internal_error ) } } @@ -81,7 +81,7 @@ impl fmt::Display for KeyNotFoundError { write!( f, "Secret key with id {} not found in secret key store. Internal error: {}", - &self.key_id, &self.internal_error + self.key_id, self.internal_error ) } } diff --git a/rs/types/types/src/crypto/threshold_sig/ni_dkg.rs b/rs/types/types/src/crypto/threshold_sig/ni_dkg.rs index 810e6ab3e11e..0e4e7a27d9db 100644 --- a/rs/types/types/src/crypto/threshold_sig/ni_dkg.rs +++ b/rs/types/types/src/crypto/threshold_sig/ni_dkg.rs @@ -206,7 +206,7 @@ pub struct NiDkgDealing { impl fmt::Display for NiDkgDealing { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { - write!(f, "{:?}", &self) + write!(f, "{:?}", self) } } @@ -300,7 +300,7 @@ impl TryFrom<&pb::NiDkgTranscript> for NiDkgTranscript { impl fmt::Display for NiDkgTranscript { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { - write!(f, "{:?}", &self) + write!(f, "{:?}", self) } } diff --git a/rs/types/types/src/crypto/threshold_sig/ni_dkg/config.rs b/rs/types/types/src/crypto/threshold_sig/ni_dkg/config.rs index 03346bfd2d92..94c4aff6a63c 100644 --- a/rs/types/types/src/crypto/threshold_sig/ni_dkg/config.rs +++ b/rs/types/types/src/crypto/threshold_sig/ni_dkg/config.rs @@ -332,7 +332,7 @@ impl NiDkgConfig { impl fmt::Display for NiDkgConfig { fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { - write!(f, "{:?}", &self) + write!(f, "{:?}", self) } } diff --git a/rs/types/types/src/crypto/threshold_sig/ni_dkg/errors.rs b/rs/types/types/src/crypto/threshold_sig/ni_dkg/errors.rs index 0b103acecad1..d74b77b5bb12 100644 --- a/rs/types/types/src/crypto/threshold_sig/ni_dkg/errors.rs +++ b/rs/types/types/src/crypto/threshold_sig/ni_dkg/errors.rs @@ -63,7 +63,7 @@ impl fmt::Display for MalformedFsEncryptionPublicKeyError { write!( f, "The (forward-secure) encryption public key is malformed: {}", - &self.internal_error + self.internal_error ) } } diff --git a/rs/types/types/src/crypto/threshold_sig/ni_dkg/errors/key_removal_error.rs b/rs/types/types/src/crypto/threshold_sig/ni_dkg/errors/key_removal_error.rs index 4a67d6f80725..b9dbdfbb3890 100644 --- a/rs/types/types/src/crypto/threshold_sig/ni_dkg/errors/key_removal_error.rs +++ b/rs/types/types/src/crypto/threshold_sig/ni_dkg/errors/key_removal_error.rs @@ -23,6 +23,6 @@ pub enum DkgKeyRemovalError { impl fmt::Display for DkgKeyRemovalError { fn fmt(&self, f: &mut Formatter<'_>) -> fmt::Result { - write!(f, "{:?}", &self) + write!(f, "{:?}", self) } } From 0957c4a8465c91f317d1a5f16913a0941aeeb610 Mon Sep 17 00:00:00 2001 From: Bas van Dijk Date: Tue, 14 Jul 2026 08:39:00 +0000 Subject: [PATCH 12/13] chore: fix rustc 1.97.0 clippy violations Fix clippy lints newly enforced by rustc 1.97.0: - useless_borrows_in_formatting: drop redundant `&`/`&mut` in format!/println!/assert!/assert_eq! arguments - for_kv_map: iterate with .keys()/.values()/.values_mut() instead of .iter()/.iter_mut() with a discarded tuple element - unneeded_wildcard_pattern: drop `amount: _` covered by `..` - dead_code: remove the local CANISTER_FREEZE_BALANCE_RESERVE duplicate in nns_shielding.rs; the identical `pub const` from ic_system_test_driver::util is already glob-imported (as used by ingress_rate_limiting.rs) Co-Authored-By: Claude Opus 4.8 (1M context) --- rs/consensus/dkg/src/lib.rs | 4 ++-- rs/consensus/dkg/src/payload_builder.rs | 4 ++-- .../bls12_381/tests/integration_tests.rs | 2 +- .../src/key_id/tests.rs | 8 ++++---- .../src/threshold/tests.rs | 2 +- .../src/vault/api/tests.rs | 8 ++++---- .../src/vault/test_utils/threshold_sig.rs | 2 +- rs/crypto/internal/logmon/src/tests.rs | 2 +- .../src/sign/threshold_sig/store/tests.rs | 2 +- rs/crypto/tests/canister_threshold_idkg.rs | 2 +- .../src/scheduler/tests.rs | 2 +- .../adapter/tests/server_test.rs | 20 +++++++++---------- rs/ledger_suite/icrc1/ledger/tests/tests.rs | 2 +- rs/nns/governance/src/governance/tests/mod.rs | 4 ++-- rs/nns/governance/src/voting.rs | 6 +++--- rs/node_rewards/canister/src/metrics/tests.rs | 2 +- rs/replica_tests/tests/tests.rs | 2 +- .../tests/store_tests.rs | 4 +--- rs/sns/governance/tests/interleaving_tests.rs | 2 +- rs/state_manager/tests/state_manager.rs | 2 +- .../general_execution_tests/nns_shielding.rs | 1 - 21 files changed, 40 insertions(+), 43 deletions(-) diff --git a/rs/consensus/dkg/src/lib.rs b/rs/consensus/dkg/src/lib.rs index aa38ea6b440c..cac4769d1f84 100644 --- a/rs/consensus/dkg/src/lib.rs +++ b/rs/consensus/dkg/src/lib.rs @@ -1009,7 +1009,7 @@ mod tests { "Configs: {:?}", summary.dkg.configs ); - for (dkg_id, _) in summary.dkg.configs.iter() { + for dkg_id in summary.dkg.configs.keys() { assert_eq!(dkg_id.target_subnet, NiDkgTargetSubnet::Local); } assert_eq!(summary.dkg.transcripts_for_remote_subnets.len(), 0); @@ -1568,7 +1568,7 @@ mod tests { PoolReader::new(&pool_1).get_highest_finalized_summary_block(); if let BlockPayload::Summary(summary) = block.payload.as_ref() { assert_eq!(summary.dkg.configs.len(), 2); - for (dkg_id, _) in summary.dkg.configs.iter() { + for dkg_id in summary.dkg.configs.keys() { assert_eq!(dkg_id.target_subnet, NiDkgTargetSubnet::Local); } } else { diff --git a/rs/consensus/dkg/src/payload_builder.rs b/rs/consensus/dkg/src/payload_builder.rs index 0a24b0e6f1bb..941470ddf7a9 100644 --- a/rs/consensus/dkg/src/payload_builder.rs +++ b/rs/consensus/dkg/src/payload_builder.rs @@ -1334,7 +1334,7 @@ mod tests { // Test the regular case (Both DKGs succeeded) let next_summary = create_summary_payload(&genesis_summary); - for (_, conf) in next_summary.configs.iter() { + for conf in next_summary.configs.values() { let tag = &conf.dkg_id().dkg_tag; match tag { NiDkgTag::HighThreshold | NiDkgTag::HighThresholdForKey(_) => assert_eq!( @@ -1350,7 +1350,7 @@ mod tests { // In this case, the `current_transcripts` are being reshared. genesis_summary.configs.clear(); let next_summary = create_summary_payload(&genesis_summary); - for (_, conf) in next_summary.configs.iter() { + for conf in next_summary.configs.values() { let tag = &conf.dkg_id().dkg_tag; match tag { NiDkgTag::HighThreshold | NiDkgTag::HighThresholdForKey(_) => assert_eq!( diff --git a/rs/crypto/internal/crypto_lib/threshold_sig/bls12_381/tests/integration_tests.rs b/rs/crypto/internal/crypto_lib/threshold_sig/bls12_381/tests/integration_tests.rs index 0f33edc7b2ab..5db03855f660 100644 --- a/rs/crypto/internal/crypto_lib/threshold_sig/bls12_381/tests/integration_tests.rs +++ b/rs/crypto/internal/crypto_lib/threshold_sig/bls12_381/tests/integration_tests.rs @@ -102,7 +102,7 @@ fn encrypted_chunks_should_validate(epoch: Epoch) { .map(|i| { println!("generating key pair {i}..."); let key_pair = kgen(KEY_GEN_ASSOCIATED_DATA, sys, rng); - println!("{:#?}", &key_pair.0); + println!("{:#?}", key_pair.0); key_pair }) .collect(); diff --git a/rs/crypto/internal/crypto_service_provider/src/key_id/tests.rs b/rs/crypto/internal/crypto_service_provider/src/key_id/tests.rs index 717eaaf27386..021f1adbe5ac 100644 --- a/rs/crypto/internal/crypto_service_provider/src/key_id/tests.rs +++ b/rs/crypto/internal/crypto_service_provider/src/key_id/tests.rs @@ -229,7 +229,7 @@ mod stability_tests { KeyId::from(&test.input), test.expected_key_id(), "Parameterized test {:?} failed", - &test + test ); } } @@ -255,7 +255,7 @@ mod stability_tests { KeyId::from(&test.input), test.expected_key_id(), "Parameterized test {:?} failed", - &test + test ); } } @@ -299,7 +299,7 @@ mod stability_tests { KeyId::from(&test.input), test.expected_key_id(), "Parameterized test {:?} failed", - &test + test ); } } @@ -387,7 +387,7 @@ t7Ica9iKR8XXVy+W5eyW52YYPbGzXZ0FgxPcOMk3Tm2qx/zJJ7pkN+rJeIEgQHEj KeyId::try_from(&test.input), Ok(test.expected_key_id()), "Parameterized test {:?} failed", - &test + test ) } } diff --git a/rs/crypto/internal/crypto_service_provider/src/threshold/tests.rs b/rs/crypto/internal/crypto_service_provider/src/threshold/tests.rs index 27fa7b34ce98..4da6abe39989 100644 --- a/rs/crypto/internal/crypto_service_provider/src/threshold/tests.rs +++ b/rs/crypto/internal/crypto_service_provider/src/threshold/tests.rs @@ -169,7 +169,7 @@ pub mod util { ) .is_err(), "Individual signature verification accepted incorrect message '{:?}' instead of '{:?}'", - &incorrect_message, + incorrect_message, message ); } diff --git a/rs/crypto/internal/crypto_service_provider/src/vault/api/tests.rs b/rs/crypto/internal/crypto_service_provider/src/vault/api/tests.rs index 249c11485022..fd9838e44f28 100644 --- a/rs/crypto/internal/crypto_service_provider/src/vault/api/tests.rs +++ b/rs/crypto/internal/crypto_service_provider/src/vault/api/tests.rs @@ -534,7 +534,7 @@ mod node_keys_errors_to_key_counts_conversions { test.expected, "for ParameterizedTest #{}: {:?}", i, - &test + test ); } } @@ -660,7 +660,7 @@ mod node_keys_errors_to_key_counts_conversions { test.expected, "for ParameterizedTest #{}: {:?}", i, - &test + test ); } } @@ -741,7 +741,7 @@ mod node_keys_errors_to_key_counts_conversions { test.expected, "for ParameterizedTest #{}: {:?}", i, - &test + test ); } } @@ -1054,7 +1054,7 @@ mod node_keys_errors_to_key_counts_conversions { test.expected, "for ParameterizedTest #{}: {:?}", i, - &test + test ); } } diff --git a/rs/crypto/internal/crypto_service_provider/src/vault/test_utils/threshold_sig.rs b/rs/crypto/internal/crypto_service_provider/src/vault/test_utils/threshold_sig.rs index 91eca1e7a336..80999243d9c1 100644 --- a/rs/crypto/internal/crypto_service_provider/src/vault/test_utils/threshold_sig.rs +++ b/rs/crypto/internal/crypto_service_provider/src/vault/test_utils/threshold_sig.rs @@ -161,7 +161,7 @@ pub fn test_threshold_signatures( ) .is_err(), "Individual signature verification accepted incorrect message '{:?}' instead of '{:?}'", - &incorrect_message, + incorrect_message, message ); } diff --git a/rs/crypto/internal/logmon/src/tests.rs b/rs/crypto/internal/logmon/src/tests.rs index 9a6f445b9132..c7fd7494a290 100644 --- a/rs/crypto/internal/logmon/src/tests.rs +++ b/rs/crypto/internal/logmon/src/tests.rs @@ -22,7 +22,7 @@ where &'static str: From<::Item>, { enum_variants.into_iter().for_each(|variant| { - let display = format!("{}", &variant); + let display = format!("{}", variant); let value: &'static str = variant.into(); let expected = value.to_case(Case::Snake).to_string(); assert_eq!(display, expected); diff --git a/rs/crypto/src/sign/threshold_sig/store/tests.rs b/rs/crypto/src/sign/threshold_sig/store/tests.rs index 0c672297123e..07a6e12b9320 100644 --- a/rs/crypto/src/sign/threshold_sig/store/tests.rs +++ b/rs/crypto/src/sign/threshold_sig/store/tests.rs @@ -343,7 +343,7 @@ fn should_not_purge_all_transcripts_of_certain_threshold_if_capacity_exceeded( // verify there is at least one high threshold transcript and at least one low threshold transcript let mut found_single_threshold = false; let mut found_other_threshold = false; - for (ni_dkg_id, _value) in store.store.iter() { + for ni_dkg_id in store.store.keys() { if ni_dkg_id.dkg_tag == single_transcript_threshold { found_single_threshold = true; } else if ni_dkg_id.dkg_tag == other_transcripts_threshold { diff --git a/rs/crypto/tests/canister_threshold_idkg.rs b/rs/crypto/tests/canister_threshold_idkg.rs index 056805ad1f00..ca26d4b42ac1 100644 --- a/rs/crypto/tests/canister_threshold_idkg.rs +++ b/rs/crypto/tests/canister_threshold_idkg.rs @@ -2519,7 +2519,7 @@ mod load_transcript_with_openings { .expect("empty openings"); complaint_with_openings.remove(&complaint); complaint.dealer_id = NodeId::from(PrincipalId::new_anonymous()); - for (_opener_id, opening) in openings.iter_mut() { + for opening in openings.values_mut() { opening.dealer_id = NodeId::from(PrincipalId::new_anonymous()); } complaint_with_openings.insert(complaint, openings); diff --git a/rs/execution_environment/src/scheduler/tests.rs b/rs/execution_environment/src/scheduler/tests.rs index 74970017aa4a..00fe5d38bcad 100644 --- a/rs/execution_environment/src/scheduler/tests.rs +++ b/rs/execution_environment/src/scheduler/tests.rs @@ -191,7 +191,7 @@ fn consensus_queue_is_emptied() { assert_eq!(sign_with_ecdsa_contexts.len(), 2); // Produce reject responses for both contexts and execute a round. - for (callback_id, _) in sign_with_ecdsa_contexts.iter() { + for callback_id in sign_with_ecdsa_contexts.keys() { let response = ConsensusResponse::new( *callback_id, Payload::Reject(RejectContext::new(RejectCode::SysFatal, "")), diff --git a/rs/https_outcalls/adapter/tests/server_test.rs b/rs/https_outcalls/adapter/tests/server_test.rs index 24cca333e91b..750491cd51f1 100644 --- a/rs/https_outcalls/adapter/tests/server_test.rs +++ b/rs/https_outcalls/adapter/tests/server_test.rs @@ -352,7 +352,7 @@ MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgob29X4H4m2XOkSZE // Make a request without socks proxy. let request = tonic::Request::new(HttpsOutcallRequest { - url: format!("http://{}/get", &unreachable_url), + url: format!("http://{}/get", unreachable_url), headers: Vec::new(), method: HttpMethod::Get as i32, body: "hello".to_string().as_bytes().to_vec(), @@ -366,7 +366,7 @@ MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgob29X4H4m2XOkSZE // Make a request with socks proxy/ let request = tonic::Request::new(HttpsOutcallRequest { - url: format!("http://{}/get", &unreachable_url), + url: format!("http://{}/get", unreachable_url), headers: Vec::new(), method: HttpMethod::Get as i32, body: "hello".to_string().as_bytes().to_vec(), @@ -456,7 +456,7 @@ MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgob29X4H4m2XOkSZE let mut client = spawn_grpc_server(server_config); let request = tonic::Request::new(HttpsOutcallRequest { - url: format!("http://{}/get", &url), + url: format!("http://{}/get", url), headers: Vec::new(), method: HttpMethod::Get as i32, body: "hello".to_string().as_bytes().to_vec(), @@ -485,7 +485,7 @@ MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgob29X4H4m2XOkSZE let mut client = spawn_grpc_server(server_config); let request = tonic::Request::new(HttpsOutcallRequest { - url: format!("http://{}/get", &url), + url: format!("http://{}/get", url), headers: Vec::new(), method: HttpMethod::Get as i32, body: "hello".to_string().as_bytes().to_vec(), @@ -509,7 +509,7 @@ MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgob29X4H4m2XOkSZE let mut client = spawn_grpc_server(server_config); let request = tonic::Request::new(HttpsOutcallRequest { - url: format!("https://{}/post", &url), + url: format!("https://{}/post", url), headers: Vec::new(), method: HttpMethod::Post as i32, body: "420".to_string().as_bytes().to_vec(), @@ -535,7 +535,7 @@ MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgob29X4H4m2XOkSZE let mut client = spawn_grpc_server(server_config); let request = tonic::Request::new(HttpsOutcallRequest { - url: format!("https://{}/head", &url), + url: format!("https://{}/head", url), headers: Vec::new(), method: HttpMethod::Head as i32, body: "".to_string().as_bytes().to_vec(), @@ -642,7 +642,7 @@ MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgob29X4H4m2XOkSZE let mut client = spawn_grpc_server(server_config); let request = tonic::Request::new(HttpsOutcallRequest { - url: format!("https://{}/size", &url), + url: format!("https://{}/size", url), headers: Vec::new(), method: HttpMethod::Get as i32, body: format!("{}", response_limit + 1).as_bytes().to_vec(), @@ -673,7 +673,7 @@ MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgob29X4H4m2XOkSZE let mut client = spawn_grpc_server(server_config); let request = tonic::Request::new(HttpsOutcallRequest { - url: format!("https://{}/size", &url), + url: format!("https://{}/size", url), headers: Vec::new(), method: HttpMethod::Get as i32, body: format!("{response_size}").as_bytes().to_vec(), @@ -700,7 +700,7 @@ MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgob29X4H4m2XOkSZE let mut client = spawn_grpc_server(server_config); let request = tonic::Request::new(HttpsOutcallRequest { - url: format!("https://{}/delay", &url), + url: format!("https://{}/delay", url), headers: Vec::new(), method: HttpMethod::Get as i32, body: format!("{delay}").as_bytes().to_vec(), @@ -777,7 +777,7 @@ MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgob29X4H4m2XOkSZE let mut client = spawn_grpc_server(server_config); let request = tonic::Request::new(HttpsOutcallRequest { - url: format!("https://{}/invalid", &url), + url: format!("https://{}/invalid", url), headers: Vec::new(), method: HttpMethod::Get as i32, body: "hello".as_bytes().to_vec(), diff --git a/rs/ledger_suite/icrc1/ledger/tests/tests.rs b/rs/ledger_suite/icrc1/ledger/tests/tests.rs index 0d73051d69cf..b8e622c499b6 100644 --- a/rs/ledger_suite/icrc1/ledger/tests/tests.rs +++ b/rs/ledger_suite/icrc1/ledger/tests/tests.rs @@ -1347,7 +1347,7 @@ fn test_icrc3_get_blocks() { expected_block_count, all_blocks.len(), expected_blocks_by_id.len(), - &ranges + ranges ); for (pos, BlockWithId { id, block }) in all_blocks.into_iter().enumerate() { let expected_block = match expected_blocks_by_id.get(&id) { diff --git a/rs/nns/governance/src/governance/tests/mod.rs b/rs/nns/governance/src/governance/tests/mod.rs index 65a250fdb4a3..1126aec29082 100644 --- a/rs/nns/governance/src/governance/tests/mod.rs +++ b/rs/nns/governance/src/governance/tests/mod.rs @@ -1003,7 +1003,7 @@ mod metrics_tests { assert!(s.contains(&format!( "governance_proposal_deadline_timestamp_seconds{{proposal_id=\"1\",proposal_topic=\"{}\",proposal_type=\"{}\"}} {} 10", Topic::NeuronManagement.as_str_name(), - &manage_neuron_action.as_str_name(), + manage_neuron_action.as_str_name(), deadline_ts, ))); @@ -1013,7 +1013,7 @@ mod metrics_tests { assert!(s.contains(&format!( "governance_proposal_deadline_timestamp_seconds{{proposal_id=\"3\",proposal_topic=\"{}\",proposal_type=\"{}\"}} {} 10", Topic::Governance.as_str_name(), - &motion_action.as_str_name(), + motion_action.as_str_name(), deadline_ts, ))); diff --git a/rs/nns/governance/src/voting.rs b/rs/nns/governance/src/voting.rs index 99c467cdbbd8..2d9f41c462d9 100644 --- a/rs/nns/governance/src/voting.rs +++ b/rs/nns/governance/src/voting.rs @@ -1217,7 +1217,7 @@ mod test { let ballots = &governance.heap_data.proposals.get(&1).unwrap().ballots; assert_eq!(ballots.len(), 100); - for (_, ballot) in ballots.iter() { + for ballot in ballots.values() { assert_eq!(ballot.vote, Vote::Yes as i32); } } @@ -1331,7 +1331,7 @@ mod test { let ballots = &governance.heap_data.proposals.get(&1).unwrap().ballots; assert_eq!(ballots.len(), 9); - for (_, ballot) in ballots.iter() { + for ballot in ballots.values() { assert_eq!(ballot.vote, Vote::Yes as i32); } @@ -1436,7 +1436,7 @@ mod test { let ballots = &governance.heap_data.proposals.get(&1).unwrap().ballots; assert_eq!(ballots.len(), 9); - for (_, ballot) in ballots.iter() { + for ballot in ballots.values() { assert_eq!(ballot.vote, Vote::Yes as i32); } diff --git a/rs/node_rewards/canister/src/metrics/tests.rs b/rs/node_rewards/canister/src/metrics/tests.rs index ed2a3209fe3e..b96bb171f02e 100644 --- a/rs/node_rewards/canister/src/metrics/tests.rs +++ b/rs/node_rewards/canister/src/metrics/tests.rs @@ -170,7 +170,7 @@ impl NodeMetricsHistoryResponseTracker { fn with_subnet(mut self, subnet_id: SubnetId) -> Self { self.current_subnet = subnet_id; - for (_, metrics) in self.subnets_responses.iter_mut() { + for metrics in self.subnets_responses.values_mut() { metrics.insert(subnet_id, Vec::new()); } self diff --git a/rs/replica_tests/tests/tests.rs b/rs/replica_tests/tests/tests.rs index d47fb178c74a..0a7e67dc13d9 100644 --- a/rs/replica_tests/tests/tests.rs +++ b/rs/replica_tests/tests/tests.rs @@ -1302,7 +1302,7 @@ fn test_inter_canister_message_exchange_1() { escape(&adder_canister_id), ), vec![], None); - println!("Canister: {}", &canister_id); + println!("Canister: {}", canister_id); for num in &[5, 17, 113] { env.execute_ingress(canister_id, "compute", vec![*num]) diff --git a/rs/rosetta-api/icp/ledger_canister_blocks_synchronizer/tests/store_tests.rs b/rs/rosetta-api/icp/ledger_canister_blocks_synchronizer/tests/store_tests.rs index 00759596bbd0..876e1447c615 100644 --- a/rs/rosetta-api/icp/ledger_canister_blocks_synchronizer/tests/store_tests.rs +++ b/rs/rosetta-api/icp/ledger_canister_blocks_synchronizer/tests/store_tests.rs @@ -145,9 +145,7 @@ async fn store_account_balances_test() { let to_account: Option; let from_account: Option; match operation { - Operation::Burn { - from, amount: _, .. - } => { + Operation::Burn { from, .. } => { from_account = Some(from.to_hex()); to_account = None; } diff --git a/rs/sns/governance/tests/interleaving_tests.rs b/rs/sns/governance/tests/interleaving_tests.rs index 1be49c85f5ab..e7d69adda8c8 100644 --- a/rs/sns/governance/tests/interleaving_tests.rs +++ b/rs/sns/governance/tests/interleaving_tests.rs @@ -104,7 +104,7 @@ fn test_cant_increase_dissolve_delay_while_disbursing() { // disburse_neuron (in particular, the locks). atomic::fence(AOrdering::SeqCst); unsafe { - println!("{:#?}", &mut (*raw_ptr).proto.in_flight_commands); + println!("{:#?}", (*raw_ptr).proto.in_flight_commands); } let increase_dissolve_result = increase_dissolve_delay( unsafe { &mut *raw_ptr }, diff --git a/rs/state_manager/tests/state_manager.rs b/rs/state_manager/tests/state_manager.rs index 0df27efa45fe..abdc17bd1722 100644 --- a/rs/state_manager/tests/state_manager.rs +++ b/rs/state_manager/tests/state_manager.rs @@ -1407,7 +1407,7 @@ fn validate_replicated_state_is_called() { metrics, "state_manager_tip_handler_request_duration_seconds", ); - for (label, _stats) in request_duration.iter() { + for label in request_duration.keys() { if label.get("request") == Some(&"validate_replicated_state_and_finalize".to_string()) { return true; } diff --git a/rs/tests/execution/general_execution_tests/nns_shielding.rs b/rs/tests/execution/general_execution_tests/nns_shielding.rs index 7130f31882e7..cfb7e2547a87 100644 --- a/rs/tests/execution/general_execution_tests/nns_shielding.rs +++ b/rs/tests/execution/general_execution_tests/nns_shielding.rs @@ -17,7 +17,6 @@ use ic_types_test_utils::ids::node_test_id; use ic_universal_canister::wasm; use lazy_static::lazy_static; -const CANISTER_FREEZE_BALANCE_RESERVE: Cycles = Cycles::new(5_000_000_000_000); lazy_static! { static ref INITIAL_CYCLES: Cycles = CANISTER_FREEZE_BALANCE_RESERVE + Cycles::new(5_000_000_000_000); From fd2a8845687499eab2c635a007f4c1aab0e87a3d Mon Sep 17 00:00:00 2001 From: IDX GitHub Automation Date: Tue, 14 Jul 2026 08:40:41 +0000 Subject: [PATCH 13/13] Automatically updated Cargo*.lock --- Cargo.Bazel.json.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Cargo.Bazel.json.lock b/Cargo.Bazel.json.lock index a02a2a78ee75..98b4b1652761 100644 --- a/Cargo.Bazel.json.lock +++ b/Cargo.Bazel.json.lock @@ -1,5 +1,5 @@ { - "checksum": "607398f501234430d179782f3255247d0fadba6fd387c0f0b07470d4b0ba3875", + "checksum": "3400af9d008b727142c1e50ae09873d3bf926c4b7b2ef5503bd51c4cb1616726", "crates": { "abnf 0.12.0": { "name": "abnf",