chore(linter): enable unconvert linter (#1881)

Author: mangalaman93

.golangci.yml

@@ -20,12 +20,13 @@ linters:
   disable-all: true
   enable:
     - errcheck
-    - ineffassign
-    - gosec
     - gofmt
+    - goimports
+    - gosec
     - gosimple
     - govet
+    - ineffassign
     - lll
-    - unused
     - staticcheck
-    - goimports
+    - unconvert
+    - unused

badger/cmd/bank.go

@@ -116,7 +116,7 @@ func key(account int) []byte {
 func toUint64(val []byte) uint64 {
 	u, err := strconv.ParseUint(string(val), 10, 64)
 	y.Check(err)
-	return uint64(u)
+	return u
 }
 
 func toSlice(bal uint64) []byte {
@@ -217,7 +217,7 @@ func get(txn *badger.Txn, k []byte) (*badger.Item, error) {
 
 // seekTotal retrives the total of all accounts by seeking for each account key.
 func seekTotal(txn *badger.Txn) ([]account, error) {
-	expected := uint64(numAccounts) * uint64(initialBal)
+	expected := uint64(numAccounts) * initialBal
 	var accounts []account
 
 	var total uint64

badger/cmd/info.go

@@ -166,7 +166,7 @@ func showKeys(db *badger.DB, prefix []byte) error {
 	defer txn.Discard()
 
 	iopt := badger.DefaultIteratorOptions
-	iopt.Prefix = []byte(prefix)
+	iopt.Prefix = prefix
 	iopt.PrefetchValues = false
 	iopt.AllVersions = opt.keyHistory
 	iopt.InternalAccess = opt.showInternal

db2_test.go

@@ -388,7 +388,7 @@ func TestBigValues(t *testing.T) {
 					return err
 				}
 				return item.Value(func(val []byte) error {
-					if len(val) == 0 || len(val) != len(data) || !bytes.Equal(val, []byte(data)) {
+					if len(val) == 0 || len(val) != len(data) || !bytes.Equal(val, data) {
 						log.Fatalf("key not found %q", len(key))
 					}
 					return nil
@@ -397,7 +397,7 @@ func TestBigValues(t *testing.T) {
 		}
 
 		for i := 0; i < keyCount; i++ {
-			require.NoError(t, saveByKey(key(i), []byte(data)))
+			require.NoError(t, saveByKey(key(i), data))
 		}
 
 		for i := 0; i < keyCount; i++ {
@@ -858,7 +858,7 @@ func TestMaxVersion(t *testing.T) {
 	t.Run("normal", func(t *testing.T) {
 		runBadgerTest(t, nil, func(t *testing.T, db *DB) {
 			// This will create commits from 1 to N.
-			for i := 0; i < int(N); i++ {
+			for i := 0; i < N; i++ {
 				txnSet(t, db, key(i), nil, 0)
 			}
 			ver := db.MaxVersion()

db_test.go

@@ -617,7 +617,7 @@ func TestGetMore(t *testing.T) {
 			}
 			k := data(i)
 			txn := db.NewTransaction(false)
-			_, err := txn.Get([]byte(k))
+			_, err := txn.Get(k)
 			require.Equal(t, ErrKeyNotFound, err, "should not have found k: %q", k)
 			txn.Discard()
 		}
@@ -1763,7 +1763,7 @@ func TestLSMOnly(t *testing.T) {
 	// Also test for error, when ValueThresholdSize is greater than maxBatchSize.
 	dopts.ValueThreshold = LSMOnlyOptions(dir).ValueThreshold
 	// maxBatchSize is calculated from MaxTableSize.
-	dopts.MemTableSize = int64(LSMOnlyOptions(dir).ValueThreshold)
+	dopts.MemTableSize = LSMOnlyOptions(dir).ValueThreshold
 	_, err = Open(dopts)
 	require.Error(t, err, "db creation should have been failed")
 	require.Contains(t, err.Error(),
@@ -2339,7 +2339,7 @@ func TestBannedPrefixes(t *testing.T) {
 
 	for _, key := range keys {
 		require.NoError(t, db.Update(func(txn *Txn) error {
-			return txn.SetEntry(NewEntry([]byte(key), []byte("value")))
+			return txn.SetEntry(NewEntry(key, []byte("value")))
 		}))
 	}
 	validate()

discard.go

@@ -131,7 +131,7 @@ func (lf *discardStats) Update(fidu uint32, discard int64) int64 {
 
 	// Could not find the fid. Add the entry.
 	idx = lf.nextEmptySlot
-	lf.set(idx*16, uint64(fid))
+	lf.set(idx*16, fid)
 	lf.set(idx*16+8, uint64(discard))
 
 	// Move to next slot.
@@ -142,7 +142,7 @@ func (lf *discardStats) Update(fidu uint32, discard int64) int64 {
 	lf.zeroOut()
 
 	sort.Sort(lf)
-	return int64(discard)
+	return discard
 }
 
 func (lf *discardStats) Iterate(f func(fid, stats uint64)) {

histogram.go

@@ -106,7 +106,7 @@ func (histogram *histogramData) Update(value int64) {
 		}
 
 		// Check if the value should be added to the "index" bin
-		if value < int64(histogram.bins[index]) {
+		if value < histogram.bins[index] {
 			histogram.countPerBin[index]++
 			break
 		}

managed_db_test.go

@@ -74,7 +74,7 @@ func TestDropAllManaged(t *testing.T) {
 			wg.Add(1)
 			txn := db.NewTransactionAt(math.MaxUint64, true)
 			require.NoError(t, txn.SetEntry(NewEntry([]byte(key("key", int(i))), val(true))))
-			require.NoError(t, txn.CommitAt(uint64(i), func(err error) {
+			require.NoError(t, txn.CommitAt(i, func(err error) {
 				require.NoError(t, err)
 				wg.Done()
 			}))
@@ -793,7 +793,7 @@ func TestZeroDiscardStats(t *testing.T) {
 
 			fids := db.vlog.sortedFids()
 			for _, fid := range fids {
-				db.vlog.discardStats.Update(uint32(fid), 1)
+				db.vlog.discardStats.Update(fid, 1)
 			}
 
 			// Ensure we have some valid fids.
@@ -821,7 +821,7 @@ func TestZeroDiscardStats(t *testing.T) {
 			// Fill discard stats. Normally these are filled by compaction.
 			fids := db.vlog.sortedFids()
 			for _, fid := range fids {
-				db.vlog.discardStats.Update(uint32(fid), 1)
+				db.vlog.discardStats.Update(fid, 1)
 			}
 
 			db.vlog.discardStats.Iterate(func(id, val uint64) { require.NotZero(t, val) })

manifest_test.go

@@ -114,17 +114,6 @@ func key(prefix string, i int) string {
 	return prefix + fmt.Sprintf("%04d", i)
 }
 
-func buildTestTable(t *testing.T, prefix string, n int, opts table.Options) *table.Table {
-	y.AssertTrue(n <= 10000)
-	keyValues := make([][]string, n)
-	for i := 0; i < n; i++ {
-		k := key(prefix, i)
-		v := fmt.Sprintf("%d", i)
-		keyValues[i] = []string{k, v}
-	}
-	return buildTable(t, keyValues, opts)
-}
-
 // TODO - Move these to somewhere where table package can also use it.
 // keyValues is n by 2 where n is number of pairs.
 func buildTable(t *testing.T, keyValues [][]string, bopts table.Options) *table.Table {
@@ -162,6 +151,17 @@ func TestOverlappingKeyRangeError(t *testing.T) {
 	// linter, I realized that the runCompactDef function below always returns error.
 	t.Skip()
 
+	buildTestTable := func(t *testing.T, prefix string, n int, opts table.Options) *table.Table {
+		y.AssertTrue(n <= 10000)
+		keyValues := make([][]string, n)
+		for i := 0; i < n; i++ {
+			k := key(prefix, i)
+			v := fmt.Sprintf("%d", i)
+			keyValues[i] = []string{k, v}
+		}
+		return buildTable(t, keyValues, opts)
+	}
+
 	dir, err := os.MkdirTemp("", "badger-test")
 	require.NoError(t, err)
 	defer removeDir(dir)

memtable.go

@@ -487,7 +487,7 @@ loop:
 		}
 
 		var vp valuePointer
-		vp.Len = uint32(int(e.hlen) + len(e.Key) + len(e.Value) + crc32.Size)
+		vp.Len = uint32(e.hlen + len(e.Key) + len(e.Value) + crc32.Size)
 		read.recordOffset += vp.Len
 
 		vp.Offset = e.offset