Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue 3 Support #218

Open
jd-solanki opened this issue Dec 6, 2020 · 8 comments
Open

Vue 3 Support #218

jd-solanki opened this issue Dec 6, 2020 · 8 comments

Comments

@jd-solanki
Copy link

when will this be Vue 3 ready?

@dgrubelic
Copy link
Owner

dgrubelic commented Mar 22, 2021

Hi @jd-0001 , after a long time, I have managed to extract time to work on this project again. Support for Vue 3 will be ready in new release 2.0.0 along with full TS support. I don't currently know the exact date of the release, but i believe it will be before summer. Thx everybody for your support so far... :)

Keep track of the progress in PRs like this #228

@DarkEvents
Copy link

Hello,
is there already a branch release (even pre-alpha) compatible with Vue 3?
Tnx

@dgrubelic
Copy link
Owner

Hey.. No, sorry, not yet. Still WIP :)

@ajmas
Copy link

ajmas commented Dec 9, 2021

What changes are needed to make this Vue3 compatible?

In relation to this, a few questions:

  • should the dependencies be move to peerDependencies?
  • should vue-authenticate take an axios instance as parameter, to avoid need of vue-axios

update

Decided to play around and see what it would take: https://github.com/ajmas/vue-authenticate/tree/playground

Right now I am just experimenting, so don't consider this a working build, but it is working for me.

@dgrubelic would it be worth making a PR for these changes and eventually bumping the release to 2.0.0, since this wold be a breaking change, due to Vue 3 specific support.

@devfaiz
Copy link

devfaiz commented Dec 19, 2021

Any luck with the upgrade @dgrubelic?

@ajmas
Copy link

ajmas commented Dec 19, 2021

He hasn’t been answering here or on Twitter. I hope all is okay. In the meantime I have been working on a fork which includes this support, since I needed it.

I could release it as vue-authenticate-2, if there is any interest?

@devfaiz
Copy link

devfaiz commented Dec 19, 2021

I would really appreciate that if you can release it

@ajmas
Copy link

ajmas commented Dec 21, 2021

@devfaiz Have now made a release at https://www.npmjs.com/package/vue-authenticate-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants