upgrade rust toolchain 1.62.1 && edition 2021 && cargo clippy --fix

Closes: #476

Author: satyamacn

devtools/x-core/Cargo.toml

@@ -3,7 +3,7 @@ name = "x-core"
 version = "0.1.0"
 authors = ["Diem Association <[email protected]>"]
 description = "Core data structures used by x"
-edition = "2018"
+edition = "2021"
 publish = false
 license = "Apache-2.0"
 

devtools/x-lint/Cargo.toml

@@ -3,7 +3,7 @@ name = "x-lint"
 version = "0.1.0"
 authors = ["Diem Association <[email protected]>"]
 description = "Lint engine for x"
-edition = "2018"
+edition = "2021"
 publish = false
 license = "Apache-2.0"
 

devtools/x/Cargo.toml

@@ -3,7 +3,7 @@ name = "x"
 version = "0.1.0"
 authors = ["Diem Association <[email protected]>"]
 description = "Diem extended cargo tasks"
-edition = "2018"
+edition = "2021"
 publish = false
 license = "Apache-2.0"
 

devtools/x/src/lint/guppy.rs

@@ -13,6 +13,7 @@ use guppy::{
 };
 use std::{
     collections::{BTreeMap, HashMap},
+    fmt::Write as FmtWrite,
     iter,
 };
 use x_core::{WorkspaceStatus, XCoreContext};
@@ -269,9 +270,7 @@ impl<'cfg> ProjectLinter for DirectDepDups<'cfg> {
             if versions.len() > 1 {
                 let mut msg = format!("duplicate direct dependency '{}':\n", direct_dep);
                 for (version, packages) in versions {
-                    msg.push_str(&format!("  * {} (", version));
-                    msg.push_str(&packages.join(", "));
-                    msg.push_str(")\n");
+                    writeln!(&mut msg, "  * {} ({})", version, &packages.join(", ")).unwrap();
                 }
                 out.write(LintLevel::Error, msg);
             }
@@ -360,12 +359,14 @@ impl<'cfg> PackageLinter for OverlayFeatures<'cfg> {
         if !overlays.is_empty() {
             let mut msg = "overlay features enabled by default:\n".to_string();
             for (from_feature, to_package, to_feature) in overlays {
-                msg.push_str(&format!(
-                    "  * {} -> {}/{}\n",
+                writeln!(
+                    &mut msg,
+                    "  * {} -> {}/{}",
                     feature_str(from_feature),
                     to_package,
                     feature_str(to_feature)
-                ));
+                )
+                .unwrap();
             }
             msg.push_str("Use a line in the [features] section instead.\n");
             out.write(LintLevel::Error, msg);

language/benchmarks/Cargo.toml

@@ -7,7 +7,7 @@ repository = "https://github.com/diem/diem"
 homepage = "https://diem.com"
 license = "Apache-2.0"
 publish = false
-edition = "2018"
+edition = "2021"
 
 [dependencies]
 anyhow = "1.0.52"

language/documentation/examples/diem-framework/crates/cli/Cargo.toml

@@ -5,7 +5,7 @@ description = "CLI frontend for the Move compiler and VM (with Diem Framework)"
 authors = ["Diem Association <[email protected]>"]
 license = "Apache-2.0"
 publish = false
-edition = "2018"
+edition = "2021"
 
 [dependencies]
 anyhow = "1.0.52"

language/documentation/examples/diem-framework/crates/crypto-derive/Cargo.toml

@@ -3,7 +3,7 @@ name = "diem-crypto-derive"
 version = "0.0.3"
 authors = ["Diem Association <[email protected]>"]
 publish = false
-edition = "2018"
+edition = "2021"
 license = "Apache-2.0"
 
 [lib]

language/documentation/examples/diem-framework/crates/crypto/Cargo.toml

@@ -3,7 +3,7 @@ name = "diem-crypto"
 version = "0.0.3"
 authors = ["Diem Association <[email protected]>"]
 publish = false
-edition = "2018"
+edition = "2021"
 license = "Apache-2.0"
 
 [dependencies]

language/documentation/examples/diem-framework/crates/natives/Cargo.toml

@@ -3,7 +3,7 @@ name = "diem-framework-natives"
 version = "0.0.0"
 authors = ["Diem Association <[email protected]>"]
 publish = false
-edition = "2018"
+edition = "2021"
 license = "Apache-2.0"
 
 [dependencies]

language/evm/extract-ethereum-abi/Cargo.toml

@@ -4,7 +4,7 @@ version = "0.1.0"
 authors = ["Diem Association <[email protected]>"]
 description = "Extract Etherem ABI"
 publish = false
-edition = "2018"
+edition = "2021"
 license = "Apache-2.0"
 
 [dependencies]