-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sever select to Ethereum status page #17
Comments
Updated in 70ff1a1#diff-28ce30da17769de7dd390cff37d71c70 The screen now different. A server selector would still be interesting. |
I'd be keen to help on this, if it's still relevant? So is the idea to have something like this, possibly without the submit button so that it automatically submits when changed:
By 'active' do you mean servers that are enabled (is_enabled: true)? |
@foxtrotcharlie that looks great! I think that screenshot is exactly what @digitaldonkey wanted to have on this page.
Yup :) |
Great. Do you use a Drupal rendered Select? It looks a little unstyled. Default value should be the current default server and all active servers should be selectable. Would be happy for a PR. |
Thanks for the feedback @digitaldonkey & @amateescu! Yes, it is a Drupal rendered select. Working on parameterising the page. Will submit PR once done. |
Would one of you mind having a look here please: #35 ? I have some questions. Thanks! |
Should networks or perhaps even nodes become an Entity in itself to extend their usefulness overall? |
They both are config entities. Just without a UI implemented. You are welcome to add it. Can you elaborate on how it would improve the usefulness from your perspective? |
The Server status page at admin/reports/ethereum currently works only for the default server.
With the refactored Server settings there should be a SELECT field on top, where you can switch the status page to any ACTIVE server.
Ideally we can reach every server config with admin/reports/ethereum/<id>
For reference. The Servers are Drupal config Entities now. With the following properties.
ethereum/config/optional/ethereum.ethereum_server.infura_ropsten.yml
Lines 1 to 6 in 1a77d26
The text was updated successfully, but these errors were encountered: