Skip to content

Commit 408aac1

Browse files
Merge pull request #125 from digitalsamba/feat/support-iframe-html-attributes
feat: add proper typing for iframe html attributes
2 parents 5f9c7fb + 8d06a79 commit 408aac1

7 files changed

Lines changed: 7 additions & 67 deletions

File tree

dist/cjs/tsconfig.cjs.tsbuildinfo

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

dist/cjs/types.d.ts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -57,22 +57,7 @@ export type InitOptions = {
5757
roomSettings?: Partial<InitialRoomSettings>;
5858
templateParams?: TemplateParams;
5959
};
60-
export type FrameAttributes = {
61-
align: string;
62-
allow: string;
63-
allowFullscreen: boolean;
64-
frameBorder: string;
65-
height: string;
66-
longDesc: string;
67-
marginHeight: string;
68-
marginWidth: string;
69-
name: string;
70-
referrerPolicy: ReferrerPolicy;
71-
scrolling: string;
72-
src: string;
73-
srcdoc: string;
74-
width: string;
75-
} & HTMLElement;
60+
export type FrameAttributes = Partial<HTMLIFrameElement>;
7661
export interface InstanceProperties {
7762
frameAttributes?: Partial<FrameAttributes>;
7863
reportErrors?: boolean;

dist/esm/tsconfig.esm.tsbuildinfo

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

dist/esm/types.d.ts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -57,22 +57,7 @@ export type InitOptions = {
5757
roomSettings?: Partial<InitialRoomSettings>;
5858
templateParams?: TemplateParams;
5959
};
60-
export type FrameAttributes = {
61-
align: string;
62-
allow: string;
63-
allowFullscreen: boolean;
64-
frameBorder: string;
65-
height: string;
66-
longDesc: string;
67-
marginHeight: string;
68-
marginWidth: string;
69-
name: string;
70-
referrerPolicy: ReferrerPolicy;
71-
scrolling: string;
72-
src: string;
73-
srcdoc: string;
74-
width: string;
75-
} & HTMLElement;
60+
export type FrameAttributes = Partial<HTMLIFrameElement>;
7661
export interface InstanceProperties {
7762
frameAttributes?: Partial<FrameAttributes>;
7863
reportErrors?: boolean;

dist/types/tsconfig.types.tsbuildinfo

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

dist/types/types.d.ts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -57,22 +57,7 @@ export type InitOptions = {
5757
roomSettings?: Partial<InitialRoomSettings>;
5858
templateParams?: TemplateParams;
5959
};
60-
export type FrameAttributes = {
61-
align: string;
62-
allow: string;
63-
allowFullscreen: boolean;
64-
frameBorder: string;
65-
height: string;
66-
longDesc: string;
67-
marginHeight: string;
68-
marginWidth: string;
69-
name: string;
70-
referrerPolicy: ReferrerPolicy;
71-
scrolling: string;
72-
src: string;
73-
srcdoc: string;
74-
width: string;
75-
} & HTMLElement;
60+
export type FrameAttributes = Partial<HTMLIFrameElement>;
7661
export interface InstanceProperties {
7762
frameAttributes?: Partial<FrameAttributes>;
7863
reportErrors?: boolean;

src/types.ts

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -95,22 +95,7 @@ export type InitOptions = {
9595
templateParams?: TemplateParams;
9696
};
9797

98-
export type FrameAttributes = {
99-
align: string;
100-
allow: string;
101-
allowFullscreen: boolean;
102-
frameBorder: string;
103-
height: string;
104-
longDesc: string;
105-
marginHeight: string;
106-
marginWidth: string;
107-
name: string;
108-
referrerPolicy: ReferrerPolicy;
109-
scrolling: string;
110-
src: string;
111-
srcdoc: string;
112-
width: string;
113-
} & HTMLElement;
98+
export type FrameAttributes = Partial<HTMLIFrameElement>
11499

115100
export interface InstanceProperties {
116101
frameAttributes?: Partial<FrameAttributes>;

0 commit comments

Comments
 (0)