Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows standalone build #20

Closed
gdurif opened this issue Jul 10, 2020 · 10 comments
Closed

Windows standalone build #20

gdurif opened this issue Jul 10, 2020 · 10 comments
Assignees
Labels
WIP Work In Progress: this issue is in the process to be fixed/tackled.

Comments

@gdurif
Copy link
Collaborator

gdurif commented Jul 10, 2020

  1. run build_standalone.R (based on R package electricShine)
  2. If 1. not working, try running build_standalone_windows.R (based on R package RInno)
@fradav
Copy link
Contributor

fradav commented Jul 10, 2020

Both scripts fails with :

package 'rlang' successfully unpacked and MD5 sums checked
Erreur : (converti depuis l'avis) cannot remove prior installation of package 'rlang'
Exécution arrêtée

@gdurif
Copy link
Collaborator Author

gdurif commented Jul 10, 2020

build_standalone.R with electricShine worked, c.f. https://github.com/diyabc/diyabcGUI/releases/tag/v1.0

In the future, we might want to switch to build_standalone_windows.R (potential cleaner build)

@gdurif gdurif self-assigned this Jul 10, 2020
@gdurif gdurif added the WIP Work In Progress: this issue is in the process to be fixed/tackled. label Sep 1, 2020
@fradav
Copy link
Contributor

fradav commented Sep 13, 2020

Apparently the standalone is missing a few key DLL for the included binaries to work on a "vanilla" windows :

  • libiomp5md.dll (openmp library used by diyabc, distributed with intel mkl installation)
  • vcruntime140_1.dll (microsoft c++ redistributable).
    I make two separate issues about this

@fradav
Copy link
Contributor

fradav commented Sep 13, 2020

diyabc/abcranger#64
diyabc/diyabc#36

As a side note, we should have a "vanilla" windows VM (as a snapshot for example) to test this.

@fradav
Copy link
Contributor

fradav commented Sep 14, 2020

Good news, I can reproduce the problems in a windows vm.

@fradav
Copy link
Contributor

fradav commented Sep 14, 2020

It is completely fixed for abcranger latest release.
However, for diyabc exe, the choice of openmp as multithreading backend forces us to deploy the windows binary with two dlls (included in the release page) vcomp140.dll and vcruntime140.dll : there is no workaround, sorry.

@gdurif
Copy link
Collaborator Author

gdurif commented Nov 30, 2020

TODO

  • diyabc executable detected as threat and blocked by windows (Windows security detects a component of diyabc binary as a threat diyabc#40)
  • find a way to make the installer considered as safe by Windows (blocked by Edge at download and by Windows at install)
  • find an alternative to electricShine to only wrap R and package dependencies inside the binary and not a pseudo-browser, i.e. the standalone would run diabcGUI::diyabc() and open the app in the host web-browser.

@gdurif
Copy link
Collaborator Author

gdurif commented Dec 4, 2020

Change of plan and new strategy based on DesktopDeployR: see 4178965

TODO:

  • fix issue with log files
  • fix issue when running multiple instances simultaneously

@gdurif
Copy link
Collaborator Author

gdurif commented Dec 4, 2020

TODO fixed in current release (4fd8d59).

@gdurif
Copy link
Collaborator Author

gdurif commented Dec 17, 2020

New standalone release strategy based on DesktopDeployR is now running smoothly.

See build/README.d and build/DesktopDeployR/README.md for more details and instructions.

@gdurif gdurif closed this as completed Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work In Progress: this issue is in the process to be fixed/tackled.
Projects
None yet
Development

No branches or pull requests

2 participants