Skip to content

Consider refactoring HistoricalRecords.__init__() #516

Open
@kseever

Description

@kseever

Problem Statement
This initializer has grown quite a bit over time - now up to 17 parameters. This makes it both hard to reason about and harder still to change.

Describe the solution you'd like
At minimum, coalescing some arguments using something like the introduce parameter object pattern.

Describe alternatives you've considered
Builder is an alternative, though it doesn't seem as idiomatic in the Django plugin ecosystem.

Metadata

Metadata

Assignees

No one assigned

    Labels

    3.0 planningDiscuss proposals for changes in the next major versionacceptedIssue accepted for completionhelp-wanted

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions