Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions failing for people who don't have write access #9

Open
drewbrew opened this issue May 2, 2024 · 5 comments · Fixed by #12
Open

GitHub actions failing for people who don't have write access #9

drewbrew opened this issue May 2, 2024 · 5 comments · Fixed by #12

Comments

@drewbrew
Copy link
Collaborator

drewbrew commented May 2, 2024

See the runs here: #7

@drewbrew
Copy link
Collaborator Author

drewbrew commented May 2, 2024

we don't actually want deploying to GH pages to happen on every PR, right? 8e4d55e#diff-e053be5b21a057e8d9e29f82426606cb8348a8b6001c522ef7d450c54018291aR7

@mtrythall
Copy link
Collaborator

@drewbrew Probably not. I set it up this way when I was rapidly prototyping.

What would you like to see? Build only on push to gh-pages?

jefftriplett added a commit that referenced this issue May 2, 2024
jefftriplett added a commit that referenced this issue May 2, 2024
@drewbrew
Copy link
Collaborator Author

drewbrew commented May 2, 2024

Maybe build on push to check for errors, only deploy on main?

@jefftriplett
Copy link
Member

This deploy on PR is fixed.

I re-opened this so we don't lose what should happen with a PR. Maybe it should build so we see errors or some a linter?

@drewbrew
Copy link
Collaborator Author

drewbrew commented May 3, 2024

Yeah, if there's a lint option, I'm all for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants