Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

banner behind modal #33

Open
AgDude opened this issue Jan 15, 2016 · 2 comments
Open

banner behind modal #33

AgDude opened this issue Jan 15, 2016 · 2 comments

Comments

@AgDude
Copy link

AgDude commented Jan 15, 2016

Because the banner is currently inside of ion-content it can't be displayed over the top of a modal. probably needs to go into its own top-level container similar to how ionicLoading works.
@johnnyoin
Copy link

Those two commits should do it:
johnnyoin@88b0b8d
johnnyoin@e1a4b8f

@trazek
Copy link

trazek commented Feb 12, 2016

Thanks. Any plan to add this to an updated version?

pliablepixels added a commit to pliablepixels/ionic-content-banner that referenced this issue Sep 3, 2016
@pliablepixels
applied djett41#33
dc124da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AgDude @johnnyoin @trazek