Default simulator helm chart values conflict

[EliSauder]

The default values for simulator.enabled and simulator.exampleCertificate.enabled don't match. This can result in a state where you have disabled the simulator but still create the certificate.

adcs-issuer/charts/adcs-issuer/values.yaml

Line 142 in 96f3605

enabled: false # Enable or disable the ADCS Simulator.

adcs-issuer/charts/adcs-issuer/values.yaml

Line 263 in 96f3605

enabled: true # Enable or disable the example certificate.

Recommendation:
Add additional configuration to the example certificate to check both variables

adcs-issuer/charts/adcs-issuer/templates/simulator-example-certificate.yaml

Line 1 in 96f3605

{{- if .Values.simulator.exampleCertificate.enabled }}

Change to:

{{- if and .Values.simulator.enabled .Values.simulator.exampleCertificate.enabled }}

[djkormo]

Thats correct. It will be added on the next versions.