Skip to content

Commit 5499547

Browse files
committed
use centralized webpack config.output.library options
1 parent f23051a commit 5499547

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

devtools/test_dashboard/server.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,7 @@ devtoolsConfig.entry = path.join(devtoolsPath, 'devtools.js');
3535
devtoolsConfig.output = {
3636
path: config.output.path,
3737
filename: 'test_dashboard-bundle.js',
38-
library: {
39-
name: 'Tabs',
40-
type: 'umd',
41-
umdNamedDefine: false
42-
}
38+
library: config.output.library
4339
};
4440

4541
devtoolsConfig.target = config.target;

test/jasmine/karma.conf.js

+2-5
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ var minimist = require('minimist');
55
var NodePolyfillPlugin = require('node-polyfill-webpack-plugin');
66
var LoaderOptionsPlugin = require('webpack').LoaderOptionsPlugin;
77
var constants = require('../../tasks/util/constants');
8+
var webpackConfig = require('../../webpack.config.js');
89

910
var isCI = Boolean(process.env.CI);
1011

@@ -298,11 +299,7 @@ func.defaultConfig = {
298299
new LoaderOptionsPlugin({
299300
// test: /\.xxx$/, // may apply this only for some modules
300301
options: {
301-
library: {
302-
name: 'Plotly',
303-
type: 'umd',
304-
umdNamedDefine: false
305-
}
302+
library: webpackConfig.output.library
306303
}
307304
})
308305
]

0 commit comments

Comments
 (0)