Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.sum incomplete for go mod vendor on 4.13.0 #548

Open
amesgen opened this issue Mar 8, 2025 · 0 comments
Open

go.sum incomplete for go mod vendor on 4.13.0 #548

amesgen opened this issue Mar 8, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@amesgen
Copy link

amesgen commented Mar 8, 2025

Describe the bug
Packaging gh-dash (e.g. for nixpkgs) requires that go mod vendor works. However, running go mod vendor for 4.13.0 results in

go: github.com/dlvhdr/gh-dash/v4/ui/common tested by
	github.com/dlvhdr/gh-dash/v4/ui/common.test imports
	github.com/stretchr/testify/require: missing go.sum entry for module providing package github.com/stretchr/testify/require (imported by github.com/dlvhdr/gh-dash/v4/ui/common); to add:
	go get -t github.com/dlvhdr/gh-dash/v4/ui/common

Of course, this is easy to work around, but ideally, it is fixed upstream.

Expected behavior
gh-dash should be go mod vendor-clean, maybe by enforcing this on CI? Thanks!

@amesgen amesgen added the bug Something isn't working label Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant