Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging into mxnet repo #71

Open
hjk41 opened this issue Feb 12, 2017 · 6 comments
Open

merging into mxnet repo #71

hjk41 opened this issue Feb 12, 2017 · 6 comments

Comments

@hjk41
Copy link
Member

hjk41 commented Feb 12, 2017

I propose to merge mxnet.cpp into mxnet project.

  1. It will attract more attention to mxnet.cpp.
  2. It will enable integrated test with mxnet, so that future checkins to mxnet will not break mxnet.cpp
@hjk41
Copy link
Member Author

hjk41 commented Feb 12, 2017

@lx75249 @zhangchen-qinyinghua

@conopt
Copy link
Collaborator

conopt commented Feb 12, 2017

The most convinient way is to add a subdirectory (cpp-package) in mxnet's root, like other language bindings (R and scala). In this way, the main work is test integration. (I guess we can also add some hook for regenerating op.h when mxnet is updated? I'm not sure if it's possible in github)

@hjk41
Copy link
Member Author

hjk41 commented Feb 13, 2017

I agree with the subdirectory approach. As for the update hook, I guess we can hook it, but not sure if we can execute python script inside the hook.
Anyway, let's merge it first, and then try to figure out the hook thing.
@lx75249 Could you create a PR to mxnet with the subdirectory?

@conopt
Copy link
Collaborator

conopt commented Feb 13, 2017

OK. I will do it.

@qiyuangong
Copy link

I think this should be done ASAP. Because this repo is far behind other interfaces, e.g, Python. Meanwhile, it is really important for industrial envo (e.g, data center), where Python and other dependencies are normally not installed.

@zhangchen-qinyinghua
Copy link
Collaborator

I agree :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants