Skip to content

Commit 01c68e7

Browse files
committed
Fix i386 "softfloat" bug
See https://golang.org/issues/44500 for details (tldr, Go 1.16 changes "GO386" from "387" to "softfloat" but the bootstrap compiler isn't 1.16 yet so balks at the changed value). This also makes our "compilation" much more explicit by explicitly noting the "env" needed to build each bashbrew architecture we support and embedding those directly. (I've also added "i386" to GitHub Actions, which will double our matrix size, but will hopefully help us catch issues like this in the future.)
1 parent f85f779 commit 01c68e7

File tree

11 files changed

+380
-177
lines changed

11 files changed

+380
-177
lines changed

.github/workflows/ci.yml

+1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ jobs:
2424
run: |
2525
git clone --depth 1 https://github.com/docker-library/bashbrew.git -b master ~/bashbrew
2626
strategy="$(~/bashbrew/scripts/github-actions/generate.sh)"
27+
strategy="$(~/bashbrew/scripts/github-actions/munge-i386.sh -c <<<"$strategy")"
2728
jq . <<<"$strategy" # sanity check / debugging aid
2829
echo "::set-output name=strategy::$strategy"
2930

1.15/alpine3.12/Dockerfile

+34-19
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

1.15/alpine3.13/Dockerfile

+34-19
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

1.15/buster/Dockerfile

+21-20
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

1.16/alpine3.12/Dockerfile

+34-19
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

1.16/alpine3.13/Dockerfile

+34-19
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)