Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.md getting appended while using alias #1854

Closed
1 task
SumithChandran opened this issue Aug 11, 2022 · 10 comments · Fixed by #1855
Closed
1 task

.md getting appended while using alias #1854

SumithChandran opened this issue Aug 11, 2022 · 10 comments · Fixed by #1855
Assignees
Milestone

Comments

@SumithChandran
Copy link

Bug Report

Steps to reproduce

Hi
I am trying to use alias to resolve the files in other repo. While doing that I need to add to token to get access.
'/changlog':'https://some/raw/url/README.md?token=Mytoken,

When I try to have the above alias, the value is getting resolved to https://some/raw/url/README.md?token= Mytoken.md.

The result is suffixing with ".md" .
Please help me resolve this issue.

What is current behaviour

https://some/raw/url/README.md?token= Mytoken.md
.md gets appended at the end of token url while using alias

What is the expected behaviour

https://some/raw/url/README.md?token= Mytoken

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS:

  • Node.js version:

  • npm/yarn version:

  • Browser version:

  • Docsify version:

  • Docsify plugins:

Please create a reproducible sandbox

Here are files to reproduce the issue
test with vs code

Mention the docsify version in which this bug was not present (if any)

@trusktr
Copy link
Member

trusktr commented Aug 11, 2022

Does '/changlog.md': 'https://some/raw/url/README.md?token=Mytoken work?

@SumithChandran
Copy link
Author

SumithChandran commented Aug 11, 2022

Does '/changlog.md': 'https://some/raw/url/README.md?token=Mytoken work?

No its not working.
image

.md is appending.

@trusktr
Copy link
Member

trusktr commented Aug 11, 2022

Looks like a bug. Do you have a link we can use to debug?

@SumithChandran
Copy link
Author

I have attached all the files I used to test in this bug report.
https://github.com/docsifyjs/docsify/files/9308204/ezyzip.zip

I have used raw link from my on repo for testing.

@vergilcw
Copy link

Hi @trusktr and @sy-records, I have the same issue as the OP. Merging this PR would be a big help, thanks for taking a look!

@sy-records sy-records self-assigned this Jan 14, 2025
@sy-records sy-records added this to the 5.x milestone Jan 14, 2025
@SumithChandran
Copy link
Author

Hi @sy-records ,
Just now tested the same locally and getting the same error.
Image

.md is still getting added at the end of the URL.

Here is the readme raw URL I used for testing:
https://github.com/SumithChandran/test/blob/main/README.md

Is that expected since its not yet released ?
Image

@sy-records
Copy link
Member

yep. You can try https://github.com/sy-records/docsify-nightly

@SumithChandran
Copy link
Author

SumithChandran commented Apr 10, 2025

@sy-records ,
Thanks a lot on fixing that issue.
The raw url with token is working fine now.

But during my testing I found another issue where this alias URL is not rendering/sourcing the images in the raw URL.
Image

I tested this because there will be images in the other documents we add as alias which need to be rendered.

This is how I tested.
I added images both from repo folder as well as from URL.
Both are not rendered.
Image

Also, Is this fix going to be rolled out to the main version anytime soon ?

@sy-records
Copy link
Member

This has nothing to do with docsify, it's a private link so it's not accessible.

Image

We will release v5-rc1 as soon as possible!

@SumithChandran
Copy link
Author

Ok got it.
Thanks a lot @sy-records.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants