Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building dojo project no longer generates output files after update to 1.17 #92

Open
rhpijnacker-philips opened this issue May 24, 2023 · 4 comments

Comments

@rhpijnacker-philips
Copy link

In our product, we use the dojo build to deploy a number of layers, which are optimized using the closure compiler.
After updating to 1.17 we find that, while it does produce the .consoleStripped.js and .uncompressed.js output files, the actually optimized files are no longer generated.

Please note that we already (locally) upgraded the closureCompiler to version 20210601 to allow us to use the newer style JavaScript syntax. Just swapping the 1.17.3 version with this older version fixes the problem of the generated output files.

@dasa
Copy link
Contributor

dasa commented May 24, 2023

1.17.3 includes Closure Compiler v20220601. (PR) Any errors in the console or build-report.txt? Are you setting optimizeOptions in your profile?

@rhpijnacker-philips
Copy link
Author

There are no errors, and no more warnings than with the older version of the compiler.

Process finished normally
	errors: 0
	warnings: 415
	build time: 52.934 seconds

The only options that we specify are to target a newer JavaScript version:

    optimizeOptions: {
      languageIn: 'ECMASCRIPT_NEXT',
      languageOut: 'ECMASCRIPT_2020'
    },

This was the reason for us to update to 20210601 back in the day.

@dasa
Copy link
Contributor

dasa commented May 25, 2023

I don't always trust that summary. I find there can still be errors in the output or build-report.txt file.

@rhpijnacker-philips
Copy link
Author

Neither do I, I just copied the summary as "proof".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants