Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ruff linting #807

Open
haixuanTao opened this issue Mar 5, 2025 · 2 comments
Open

Fix ruff linting #807

haixuanTao opened this issue Mar 5, 2025 · 2 comments
Labels
good first issue Good for newcomers

Comments

@haixuanTao
Copy link
Collaborator

haixuanTao commented Mar 5, 2025 •
edited
Loading

The current codebase seems to have issues when linting with ruff:

uvx ruff check --select ALL

As they are a lot of linting issues with the current code base. I think that an iterative ( multiple small PR ) and automated approach could be very interesting. :slight_smile:

An automated fix could look like:

uvx ruff check --select ALL --fix
@haixuanTao haixuanTao added the good first issue Good for newcomers label Mar 5, 2025
@Rustix69
Copy link

Rustix69 commented Mar 7, 2025

@haixuanTao can you assign it to me i can do this

@7SOMAY
Copy link
Contributor

7SOMAY commented Mar 7, 2025

Hi, @haixuanTao. Can you please review my pull request?

@Rustix69 Rustix69 mentioned this issue Mar 8, 2025
Closed
haixuanTao added a commit that referenced this issue Mar 9, 2025
@haixuanTao
#807 Fixed (#818)
0310d5b 
Fixed using Automated Script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Done Rustix69/Dora
3 participants
@haixuanTao @7SOMAY @Rustix69