Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dora-magma node #839

Open
haixuanTao opened this issue Mar 10, 2025 · 8 comments
Open

Add dora-magma node #839

haixuanTao opened this issue Mar 10, 2025 · 8 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@haixuanTao
Copy link
Collaborator

Add support for Microsoft Magma model: https://github.com/microsoft/Magma?tab=readme-ov-file

This would require to add magma as a git submodule within the nodes in the likes of dora-rdt-1b and then connect the model from transformers in the likes of: https://github.com/microsoft/Magma/blob/main/agents/robot_traj/app.py

Making sure the input and output matches requirements.

Note that it seems that this uses a different transformers model.

@haixuanTao haixuanTao added the good first issue Good for newcomers label Mar 10, 2025
@MunishMummadi
Copy link
Contributor

I might need little guidance with this issue!!

@MunishMummadi
Copy link
Contributor

@dora-bot assign me

Copy link

Hello @MunishMummadi, this issue is now assigned to you!

@Codexgigaa
Copy link

It looks like this task has been pending for over 19 hours without updates. If no progress has been made, I’d like to take over and proceed with the implementation. Please let me know if I can work on this. Thanks!

@MunishMummadi
Copy link
Contributor

Thank you for your concern. Last i checked/wrote it takes 14 days for an issue to be considered stale/no-activity. I write my code — so, it will take some time sorry.

@haixuanTao
Copy link
Collaborator Author

FYI @Codexgigaa, we can create an additional sub-issue which is to create a dora-magma-recorder enabling to collect data in the correct magma format in a way that we can train/fintune magma. See the default repo

@MunishMummadi
Copy link
Contributor

Update: I am testing few changes. I will be able to push a patch in few hours.

@Codexgigaa
Copy link

Thanks for the update! I’ll start working on creating the dora-magma-recorder to ensure data is collected in the correct format for training and fine-tuning Magma. I'll first review the default repo to understand the expected data structure and then integrate the recorder within Dora. Let me know if there are any specific requirements or constraints to consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants