Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IntoArrow within our arrow-convert crate #852

Open
haixuanTao opened this issue Mar 12, 2025 · 6 comments
Open

Improve IntoArrow within our arrow-convert crate #852

haixuanTao opened this issue Mar 12, 2025 · 6 comments
Assignees
Labels
good first issue Good for newcomers rust

Comments

@haixuanTao
Copy link
Collaborator

Currently we implement automatic rust conversion from simple types to arrow but we still miss a lot of types.

We could greatly benefit from having more automatic into arrow and from arrow conversion in dora-rs.

The file to modify is: https://github.com/dora-rs/dora/blob/c6ce45785fa1b130030ec233eebb9d463c5b8664/libraries/arrow-convert/src/into_impls.rs
and: https://github.com/dora-rs/dora/blob/52045f3af84924e5a1cbc3283ade98a962514089/libraries/arrow-convert/src/from_impls.rs

This should be a good first issue for rust dev as this is fully contained within a simple crate.

@haixuanTao haixuanTao added the good first issue Good for newcomers label Mar 12, 2025
@github-actions github-actions bot added the rust label Mar 12, 2025
@Shar-jeel-Sajid
Copy link
Contributor

@dora-bot assign me

Copy link

Hello @Shar-jeel-Sajid, this issue is now assigned to you!

@Tushar4059x
Copy link

@haixuanTao What are the highest priority missing types we should implement first?

@haixuanTao
Copy link
Collaborator Author

  • Borrowed list
  • string
  • boolean
  • temporal

We can take inspiration from: https://docs.rs/arrow_convert/latest/arrow_convert/

I wonder if we can even import it and use it as is!

@Shar-jeel-Sajid
Copy link
Contributor

I read about https://docs.rs/arrow_convert/latest/arrow_convert/. I think we can import and integrate it in dora. Should i use this crate?

@haixuanTao
Copy link
Collaborator Author

We can! If we can make it not break the current API

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers rust
Projects
None yet
Development

No branches or pull requests

3 participants