Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve C++ Arrow type Conversion #854

Open
haixuanTao opened this issue Mar 13, 2025 · 4 comments
Open

Improve C++ Arrow type Conversion #854

haixuanTao opened this issue Mar 13, 2025 · 4 comments
Assignees

Comments

@haixuanTao
Copy link
Collaborator

We should improve dora C++ arrow type conversion at https://github.com/dora-rs/dora/blob/2488d0916c6dac4b6acb404d600c2ed025fd62d1/apis/c++/node/src/lib.rs

We can definetely do more than:

    let data = match metadata.type_info.data_type {
        dora_node_api::arrow::datatypes::DataType::UInt8 => {
            let array: &UInt8Array = data.as_primitive();
            array.values().to_vec()
        }
        dora_node_api::arrow::datatypes::DataType::Null => {
            vec![]
        }
        _ => {
            todo!("dora C++ Node does not yet support higher level type of arrow. Only UInt8. 
                The ultimate solution should be based on arrow FFI interface. Feel free to contribute :)")
        }
    };
@Codexgigaa
Copy link

@dora-bot assign me

Copy link

Hello @Codexgigaa, this issue is now assigned to you!

@Codexgigaa
Copy link

Hello @haixuanTao ,

I hope you're doing well! I have a few doubts regarding the project and would really appreciate your guidance. Could you please let me know the best place or platform where I can ask my questions or discuss these doubts with you?

Thank you for your help!

Best regards,
Lovish Bhardwaj

@haixuanTao
Copy link
Collaborator Author

We use discord: https://discord.gg/QHA96fP3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants