Proj0217: Enable requiring license acceptance #91
Conversation
|
I like this rule a lot. I'm wondering though, if there reasons to deviate, and if that is case, if allowing an explicit false is the best way to do so. We still can advise in the documentation to set it to true, but only warn when not set. If people added |
|
And may be add a screenshot to Markdown what the result is. |
Corniel
left a comment
Corniel
left a comment
There was a problem hiding this comment.
Besides the remarks made, I think this is a nice addition to our rules.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| this feature by setting `<PackageRequireLicenseAcceptance>` to `true` | ||
| ensures consumers of your package are given this prompt when trying to install | ||
| your package. However, if you don't explicitly define this, users will not be prompted | ||
| even if you would have liked them to. |
There was a problem hiding this comment.
[LanguageTool] reported by reviewdog 🐶
Did you mean “had liked”? (IF_WOULD_HAVE_VBN[1])
Suggestions: had liked
Rule: https://community.languagetool.org/rule/show/IF_WOULD_HAVE_VBN?lang=en-US&subId=1
Category: GRAMMAR
Documentation for dotnet-project-file-analyzers#342