Proj0036: Remove None when redundant

[Corniel]

Documentation for issue 376. I'm not sure yet what title to give it. Any suggestions?

[CptWesley]

Title suggestion: Remove redundant None nodes

Exceptions should perhaps be made for cases where the None node does do something (e.g. specify a custom path) that the other node is not doing (although this should probably fire off some other warning for being illegible and I'm not 100% sure how IDEs handle this situation).

[Corniel]

Title suggestion: Remove redundant None nodes

Partly I like the name, but it suggest way more than the rule covers (right now). We're not checking Include or Update <None>s that are not needed (which also can be the case). Do we, once we have a way to detect them, in the future put that under the same rule?!

Exceptions should perhaps be made for cases where the None node does do something (e.g. specify a custom path) that the other node is not doing (although this should probably fire off some other warning for being illegible and I'm not 100% sure how IDEs handle this situation).

<ItemGroup>
  <None Include="*.md">
    <CopyToOutputDirectory>Always</CopyToOutputDirectory>
  </None>
  <None Remove="LICENSE.md" />

But this can also be written as:

<ItemGroup>
  <None Include="*.md">
    <CopyToOutputDirectory>Always</CopyToOutputDirectory>
  </None>
  <None Update="LICENSE.md">
    <CopyToOutputDirectory>Never</CopyToOutputDirectory>
 </None>

And yes, this is longer, but it is an - at least I think - uncommon scenario, that is preferable because of the simplicity of the implementation which leads to less FN's, and the unlikelyness of FP's.

[Corniel]

@Gemberkoekje Do you have a preferred title in mind?

[Gemberkoekje]

Minimize the usage of NONE ?

[LauraXiulan]

"Remove redundant None nodes with Remove attribute"? I like Wesleys suggestion, we could expand the rule later.

Another consideration, what to do when attributes are combined in one statement. For example this is possible:

<ItemGroup>
  <!-- Include every C# source file, except anything in the "sub" folder -->
  <Compile Include="**/*.cs" Exclude="sub/**/*.cs">
</ItemGroup>

Is that possible for None Remove as well? Although the initial issue was raised based on 'accidental' adding and this definitely is an explicit action. So might be out of scope.

[Corniel]

Based on rule Proj0026, I went for: Remove None when redundant.