Skip to content

CancellationToken in ISingleClientProxy.InvokeAsync is not optional #27996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SLjavad opened this issue Jan 2, 2023 · 8 comments
Open

CancellationToken in ISingleClientProxy.InvokeAsync is not optional #27996

SLjavad opened this issue Jan 2, 2023 · 8 comments
Assignees
@wadepickett
Labels
doc-enhancement Pri1 seQUESTered Identifies that an issue has been imported into Quest. SignalR Source - Docs.ms Docs Customer feedback via GitHub Issue

Comments

@SLjavad
Copy link

SLjavad commented Jan 2, 2023 •
edited by github-actions bot
Loading

the CancellationToken parameter in InvokeAsync function is optional in Client Result section of document.
but it's not optional in real code

image

document :

image

please fix it

Document Details

⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

Associated WorkItem - 65762
@dotnet-bot dotnet-bot added ⌚ Not Triaged SignalR Source - Docs.ms Docs Customer feedback via GitHub Issue labels Jan 2, 2023
@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Jan 2, 2023 •
edited
Loading

ClientProxyExtensions.InvokeAsync shows it's required on each overload. @wadepickett move these embedded snippets to projects.

@BrennanConroy
Copy link
Member

And don't use default or new CancellationToken(false) or CancellationToken.None in the docs.

@wadepickett
Copy link
Contributor

wadepickett commented Feb 23, 2023 •
edited
Loading

Related: #28459 : Use hubs in SignalR: Move all code examples to app project vers 7.0

Related discussion I need to remember to review on dotnet/aspnetcore (development) 11542
"CancellationToken in the hub method signature is only supported for Server to client streaming currently."

@wadepickett wadepickett added the reQUEST Triggers an issue to be imported into Quest label Feb 23, 2023
@github-actions github-actions bot added seQUESTered Identifies that an issue has been imported into Quest. and removed reQUEST Triggers an issue to be imported into Quest labels Feb 23, 2023
@wadepickett wadepickett mentioned this issue Mar 29, 2023
Open
@wadepickett wadepickett moved this to 🏗 In progress in dotnet/AspNetCore.Docs March 2023 Mar 29, 2023
@wadepickett wadepickett mentioned this issue Mar 30, 2023
Closed
@BrennanConroy BrennanConroy mentioned this issue Sep 20, 2023
Closed
@wadepickett
Copy link
Contributor

Related to PR #dotnet/AspNetCore.Docs.Samples/pull/138, which is where I got stuck and this unfortunately sat for so long since I was having trouble getting a workable app sample together due to lack of experience with it. I will get back to it.

@wadepickett wadepickett moved this from 🔖 Ready to 🏗 In progress in dotnet/AspNetCore.Docs Dec 2023 Dec 5, 2023
@dotnetrepoman dotnetrepoman bot added mapQuest clean move and removed mapQuest clean move labels Dec 3, 2024
@wadepickett wadepickett moved this from 🔖 Ready to 🏗 In progress in dotnet/AspNetCore.Docs March 2025 sprint Mar 5, 2025
@dotnetrepoman dotnetrepoman bot added the mapQuest clean move label Mar 5, 2025
@dotnet-policy-service dotnet-policy-service bot removed the mapQuest clean move label Mar 5, 2025
@dotnetrepoman dotnetrepoman bot added the mapQuest clean move label Mar 10, 2025
@dotnet-policy-service dotnet-policy-service bot removed the mapQuest clean move label Mar 10, 2025
@wadepickett wadepickett moved this from 🔖 Ready to 🏗 In progress in dotnet/AspNetCore.Docs April 2025 sprint Apr 2, 2025
@dotnetrepoman dotnetrepoman bot added the mapQuest clean move label Apr 2, 2025
@dotnet-policy-service dotnet-policy-service bot removed the mapQuest clean move label Apr 2, 2025
@dotnetrepoman dotnetrepoman bot added the mapQuest clean move label May 6, 2025
@wadepickett wadepickett moved this from 🔖 Ready to 🏗 In progress in dotnet/AspNetCore.Docs May 2025 sprint May 6, 2025
@dotnet-policy-service dotnet-policy-service bot removed the mapQuest clean move label May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wadepickett wadepickett

Labels
doc-enhancement Pri1 seQUESTered Identifies that an issue has been imported into Quest. SignalR Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
dotnet/AspNetCore.Docs May 2025 sprint
Status: 🏗 In progress
dotnet/AspNetCore.Docs January 2024
Status: 🏗 In progress
dotnet/AspNetCore.Docs March 2023
Status: 🏗 In progress
dotnet/AspNetCore.Docs Oct 2023
Status: 🔖 Ready
Milestone
No milestone
Development

No branches or pull requests
7 participants
@guardrex @Rick-Anderson @BrennanConroy @dotnet-bot @wadepickett @SLjavad @Alerinos