Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add RPlotExporter Images to Html Exporter #1646

Open
Eddie-Hartman opened this issue Jan 31, 2021 · 3 comments
Open

Feature Request: Add RPlotExporter Images to Html Exporter #1646

Eddie-Hartman opened this issue Jan 31, 2021 · 3 comments

Comments

@Eddie-Hartman
Copy link

I'm new to this project and enjoying it so far.

It seems to me like a possible low hanging fruit to add an option that when you are exporting both HTML and RPlot to add the ability to include the images in the HTML as relative links. This makes it really easy to see a lot of the data in one location along with the visualizations you've created.

I've seen the ability to customize exporting options and possibly there is more to what's already customizable that this is a possibility already but just requires a bit more work from the users? If so, point me in the right direction.

Otherwise, please consider it for inclusion in the next release.

@adamsitnik
Copy link
Member

Hi @Eddie-Hartman

I like your idea, but I am afraid that we won't have time to implement it ourselves. Would you like to help us a bit and send a PR?

Thanks!

@AvishaiDotan
Copy link
Contributor

AvishaiDotan commented Jan 11, 2025

First of all thanks to @Eddie-Hartman for helping out in the first steps on this issue.

I have been working on this for a while and would like to propose two approaches to generating this exporter. Before presenting the options, I need to clarify that the implementation of this feature can follow two different ways:

  1. Address this as a single, standalone case for integrating RPlot and HTML exporters.
  2. Develop a generalized logic for all types of integrated exporters, allowing them to be merged if needed.

If the first approach is preferred, we can simply add a parameter to the RPlotExporter.
If the second approach is preferred, I think a new exporter, named IntegratedExporter, would be needed. This exporter would accept the types of exporters and handle the logic for exporting them.

I would appreciate a feedback on which approach would be best.

@AvishaiDotan
Copy link
Contributor

First Draft
#2690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants