`DisassemblyDiagnoser` does not work in `InProcessEmitToolchain`

[timcassell]

Trying to use DisassemblyDiagnoser with InProcessEmitToolchain, I get an error:

// ! InProcessEmitExecutor, exception: System.InvalidOperationException: Sequence contains no matching element
   at System.Linq.ThrowHelper.ThrowNoMatchException()
   at System.Linq.Enumerable.First[TSource](IEnumerable`1 source, Func`2 predicate)
   at BenchmarkDotNet.Disassemblers.ClrMdV2Disassembler.AttachAndDisassemble(Settings settings)
   at BenchmarkDotNet.Disassemblers.SameArchitectureDisassembler.Disassemble(DiagnoserActionParameters parameters)
   at BenchmarkDotNet.Diagnosers.DisassemblyDiagnoser.Handle(HostSignal signal, DiagnoserActionParameters parameters)
   at BenchmarkDotNet.Diagnosers.CompositeDiagnoser.Handle(HostSignal signal, DiagnoserActionParameters parameters)
   at BenchmarkDotNet.Toolchains.InProcess.InProcessHost.SendSignal(HostSignal hostSignal)
   at BenchmarkDotNet.Engines.HostExtensions.AfterAll(IHost host)
   at BenchmarkDotNet.Toolchains.InProcess.Emit.Implementation.RunnableProgram.Run(BenchmarkId benchmarkId, Assembly partitionAssembly, BenchmarkCase benchmarkCase, IHost host)
   at BenchmarkDotNet.Toolchains.InProcess.Emit.InProcessEmitExecutor.ExecuteCore(IHost host, ExecuteParameters parameters)
Executable C:\Users\Tim\Documents\git\ProtoPromiseBenchmarks\AsynchronousBenchmarks\bin\Release\net6.0\001a3848-5fde-4a5d-a284-00d6519a2aaeEmitted.dll not found
ExitCode != 0 and no results reported
No Workload Results were obtained from the run.

The last version where it worked was 0.13.1. It seems ClrMdV2Disassembler broke this case in 0.13.2. @adamsitnik

[adamsitnik]

I am surprised that it ever worked (in the past we were attaching the debugger in a way it was performing full suspend of the debugged process, suspending yourself == deadlock).

We even have a check for that, but it checks only one of the InProcessToolchains:

BenchmarkDotNet/src/BenchmarkDotNet/Disassemblers/DisassemblyDiagnoser.cs

Lines 103 to 106 in d93490d

	if (benchmark.Job.Infrastructure.TryGetToolchain(out var toolchain) && toolchain is InProcessNoEmitToolchain)
	{
	yield return new ValidationError(true, "InProcessToolchain has no DisassemblyDiagnoser support", benchmark);
	}

I won't have the time to fix it anytime soon, but whoever wants to do it they need to check whether we are using the right name of the type:

BenchmarkDotNet/src/BenchmarkDotNet/Disassemblers/ClrMdV2Disassembler.cs

Line 40 in d93490d

ClrType typeWithBenchmark = state.Runtime.EnumerateModules().Select(module => module.GetTypeByName(settings.TypeName)).First(type => type != null);

BenchmarkDotNet/src/BenchmarkDotNet/Disassemblers/SameArchitectureDisassembler.cs

Line 31 in d93490d

typeName: $"BenchmarkDotNet.Autogenerated.Runnable_{parameters.BenchmarkId.Value}",

It's the name of the type generated by the in process toolchain.

In case we can not get it working, we should just mark is as unsupported for all the in process toolchains.

[timcassell]

I did check the type, and it is correct. It just was unable to find it. I hope we can get it to work somehow, because I'm trying to debug #2334.

[adamsitnik]

It's possible that ClrMD does not include types emitted on the fly in reported types list.

Have you tried using the VS Disassemby Window: https://learn.microsoft.com/en-us/visualstudio/debugger/how-to-use-the-disassembly-window?view=vs-2022?

[timcassell]

I did look at that, yeah, but it's hard for me to make sense of because each method isn't nicely segregated like our disassembler does.

[leculver]

I have found and fixed this issue in ClrMD. It will be shipped in ClrMD 3 in the next week or two.

[adamsitnik]

@leculver thank you!

[timcassell]

@leculver Do you have a migration guide/ changelist for v3?