-
-
Notifications
You must be signed in to change notification settings - Fork 985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom exporter options to be defined #1967
Comments
This comment was marked as outdated.
This comment was marked as outdated.
actually, i will reopen this since it would be nice to be able to define exporter-options which are selectable over the args. |
@PaulRitter Could you please elaborate more on that? Please provide sample API design and code example. |
I updated the original comment, did that clear it up? Otherwise im open to thinking a bit more on the idea and coming up with an entire API proposal, but i'd have to get more familiar with the project for that. |
@PaulRitter now I get it: you would like to have the possibility to extend the existing command line argument parsing logic with the possibility to specify user-defined exporters so you can do sth like We could introduce a new method: public static class ConfigParser
{
public static void RegisterCustomExporter(string commandLineName, IExporter exporter) => AvailableExporters.Add(commandLineName, exporter);
} @PaulRitter if that is what you need please send a PR. |
Hi! I would like to take this issue, I submitted a proposal in a PR. The idea is for the user to create an exporter implementing IExporter and then add it from a command line argument . Please let me know what you think, thank you! |
Currently options for the exporters console argument are hardcoded here:
BenchmarkDotNet/src/BenchmarkDotNet/ConsoleArguments/ConfigParser.cs
Lines 52 to 71 in 21a2940
I would love a way to add custom exporters as options to this list.
The text was updated successfully, but these errors were encountered: