Fix Search query for GetParameterNamesAsync() in NuGet v2

- Changed WebRequestFactory to use static HttpClient to avoid connection socket exhaustion

Author: Patrick Assuied

CHANGELOG.md

@@ -14,6 +14,7 @@ on the official Visual Studio extension gallery.
 
 ## 1.4
 - [x] Implement NuGet V2 Feed support
+- [x] Change WebRequestFactory to use a static HttpClient to avoid connection socket exhaustion problem
 
 ## 1.1
 

src/ProjectFileTools.NuGetSearch/Feeds/Web/NuGetV2ServiceFeed.cs

@@ -84,7 +84,7 @@ public async Task<IPackageNameSearchResult> GetPackageNamesAsync(string prefix,
             IReadOnlyList<string> results = new List<string>();
             string frameworkQuery = !string.IsNullOrEmpty(queryConfiguration.CompatibiltyTarget) ? $"&targetFramework={queryConfiguration.CompatibiltyTarget}" : "";
             var serviceEndpoints = new[] { $"{_feed}/Search()" };
-            Func<string, string> queryFunc = x => $"{x}?searchTerm={prefix}{frameworkQuery}&includePrerelease={queryConfiguration.IncludePreRelease}";
+            Func<string, string> queryFunc = x => $"{x}?searchTerm='{prefix}'{frameworkQuery}&includePrerelease={queryConfiguration.IncludePreRelease}";
             XDocument document = await ExecuteAutocompleteServiceQueryAsync(serviceEndpoints, queryFunc, cancellationToken).ConfigureAwait(false);
 
             if (document != null)

src/ProjectFileTools.NuGetSearch/IO/WebRequestFactory.cs

@@ -6,16 +6,14 @@ namespace ProjectFileTools.NuGetSearch.IO
 {
     public class WebRequestFactory : IWebRequestFactory
     {
+        private static readonly HttpClient _httpClient = new HttpClient();
         public async Task<string> GetStringAsync(string endpoint, CancellationToken cancellationToken)
         {
             try
             {
-                using (HttpClient client = new HttpClient())
-                {
-                    HttpResponseMessage responseMessage = await client.GetAsync(endpoint, cancellationToken).ConfigureAwait(false);
-                    responseMessage.EnsureSuccessStatusCode();
-                    return await responseMessage.Content.ReadAsStringAsync().ConfigureAwait(false);
-                }
+                HttpResponseMessage responseMessage = await _httpClient.GetAsync(endpoint, cancellationToken).ConfigureAwait(false);
+                responseMessage.EnsureSuccessStatusCode();
+                return await responseMessage.Content.ReadAsStringAsync().ConfigureAwait(false);
             }
             catch
             {

test/ProjectFileTools.NuGetSearch.Tests/NuGetV2ServiceFeedTests.cs

@@ -39,7 +39,7 @@ public async Task GivenPackagesFound_ReturnListOfIds(string feed, string testFil
                 var webRequestFactory = Mock.Of<IWebRequestFactory>();
 
                 Mock.Get(webRequestFactory)
-                    .Setup(f => f.GetStringAsync("http://localhost/nuget/Search()?searchTerm=Common.Logging&targetFramework=netcoreapp2.0&includePrerelease=False", It.IsAny<CancellationToken>()))
+                    .Setup(f => f.GetStringAsync("http://localhost/nuget/Search()?searchTerm='Common.Logging'&targetFramework=netcoreapp2.0&includePrerelease=False", It.IsAny<CancellationToken>()))
                     .Returns(Task.FromResult(GetXmlFromTestFile(testFile)));
 
                 var sut = new NuGetV2ServiceFeed(feed, webRequestFactory);