Removing exception converter from state-less continue task helper

Author: benrr101

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlCommand.NonQuery.cs

@@ -886,8 +886,8 @@ private void RunExecuteNonQueryTdsSetupReconnnectContinuation(
                 timeoutCts.Token);
 
             AsyncHelper.ContinueTask(
-                reconnectTask,
-                completion,
+                taskToContinue: reconnectTask,
+                taskCompletionSource: completion,
                 onSuccess: () =>
                 {
                     if (completion.Task.IsCompleted)

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlCommand.Reader.cs

@@ -1634,10 +1634,9 @@ private void RunExecuteReaderTdsSetupReconnectContinuation(
                 onTimeout: static () => SQL.CR_ReconnectTimeout(),
                 timeoutCts.Token);
 
-            // @TODO: With an object to pass around we can use the state-based version
             AsyncHelper.ContinueTask(
-                reconnectTask,
-                completion,
+                taskToContinue: reconnectTask,
+                taskCompletionSource: completion,
                 onSuccess: () =>
                 {
                     if (completion.Task.IsCompleted)
@@ -1669,7 +1668,7 @@ private void RunExecuteReaderTdsSetupReconnectContinuation(
                             taskToContinue: subTask,
                             taskCompletionSource: completion,
                             state: completion,
-                            onSuccess: static state => state.SetResult(null));
+                            onSuccess: static completion2 => completion2.SetResult(null));
                     }
                 });
         }

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParser.cs

@@ -10761,11 +10761,23 @@ private Task TDSExecuteRPCAddParameter(TdsParserStateObject stateObj, SqlParamet
         }
 
         // This is in its own method to avoid always allocating the lambda in TDSExecuteRPCParameter
-        private void TDSExecuteRPCParameterSetupWriteCompletion(SqlCommand cmd, IList<_SqlRPC> rpcArray, int timeout, bool inSchema, SqlNotificationRequest notificationRequest, TdsParserStateObject stateObj, bool isCommandProc, bool sync, TaskCompletionSource<object> completion, int startRpc, int startParam, Task writeParamTask)
+        private void TDSExecuteRPCParameterSetupWriteCompletion(
+            SqlCommand cmd,
+            IList<_SqlRPC> rpcArray,
+            int timeout,
+            bool inSchema,
+            SqlNotificationRequest notificationRequest,
+            TdsParserStateObject stateObj,
+            bool isCommandProc,
+            bool sync,
+            TaskCompletionSource<object> completion,
+            int startRpc,
+            int startParam,
+            Task writeParamTask)
         {
             AsyncHelper.ContinueTask(
-                writeParamTask,
-                completion,
+                taskToContinue: writeParamTask,
+                taskCompletionSource: completion,
                 onSuccess: () => TdsExecuteRPC(
                     cmd,
                     rpcArray,
@@ -10777,8 +10789,7 @@ private void TDSExecuteRPCParameterSetupWriteCompletion(SqlCommand cmd, IList<_S
                     sync,
                     completion,
                     startRpc,
-                    startParam
-                ),
+                    startParam),
                 onFailure: exc => TdsExecuteRPC_OnFailure(exc, stateObj));
         }
 

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs

@@ -4353,9 +4353,16 @@ private Task WriteBytes(ReadOnlySpan<byte> b, int len, int offsetBuffer, bool ca
         // This is in its own method to avoid always allocating the lambda in WriteBytes
         private void WriteBytesSetupContinuation(byte[] array, int len, TaskCompletionSource<object> completion, int offset, Task packetTask)
         {
-            AsyncHelper.ContinueTask(packetTask, completion,
-               onSuccess: () => WriteBytes(ReadOnlySpan<byte>.Empty, len: len, offsetBuffer: offset, canAccumulate: false, completion: completion, array)
-           );
+            AsyncHelper.ContinueTask(
+                taskToContinue: packetTask,
+                taskCompletionSource: completion,
+                onSuccess: () => WriteBytes(
+                    ReadOnlySpan<byte>.Empty,
+                    len: len,
+                    offsetBuffer: offset,
+                    canAccumulate: false,
+                    completion: completion,
+                    array));
         }
 
         /// <summary>

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/Utilities/AsyncHelper.cs

@@ -17,19 +17,14 @@ internal static void ContinueTask(
             TaskCompletionSource<object> taskCompletionSource,
             Action onSuccess,
             Action<Exception> onFailure = null,
-            Action onCancellation = null,
-            Func<Exception, Exception> exceptionConverter = null)
+            Action onCancellation = null)
         {
             taskToContinue.ContinueWith(
                 tsk =>
                 {
                     if (tsk.Exception != null)
                     {
                         Exception exc = tsk.Exception.InnerException;
-                        if (exceptionConverter != null)
-                        {
-                            exc = exceptionConverter(exc);
-                        }
                         try
                         {
                             onFailure?.Invoke(exc);
@@ -62,8 +57,8 @@ internal static void ContinueTask(
                             taskCompletionSource.SetException(e);
                         }
                     }
-                }, TaskScheduler.Default
-            );
+                },
+                TaskScheduler.Default);
         }
 
         internal static void ContinueTaskWithState<TState>(