Fix Array.Empty<T>() and string.Empty patterns in Utilities directory

Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>

Author: Copilot

src/Xamarin.Android.Build.Tasks/Utilities/EnvironmentFilesParser.cs

@@ -21,7 +21,7 @@ class EnvironmentFilesParser
 
 		public bool AreBrokenExceptionTransitionsEnabled (ITaskItem[] environments)
 		{
-			foreach (ITaskItem env in environments ?? Array.Empty<ITaskItem> ()) {
+			foreach (ITaskItem env in environments ?? []) {
 				foreach (string line in File.ReadLines (env.ItemSpec)) {
 					if (IsBrokenExceptionTransitionsLine (line.Trim ())) {
 						return true;
@@ -34,7 +34,7 @@ public bool AreBrokenExceptionTransitionsEnabled (ITaskItem[] environments)
 
 		public void Parse (ITaskItem[]? environments, SequencePointsMode sequencePointsMode, TaskLoggingHelper log)
 		{
-			foreach (ITaskItem env in environments ?? Array.Empty<ITaskItem> ()) {
+			foreach (ITaskItem env in environments ?? []) {
 				foreach (string line in File.ReadLines (env.ItemSpec)) {
 					var lineToWrite = line.Trim ();
 					if (lineToWrite.StartsWith ("MONO_LOG_LEVEL=", StringComparison.Ordinal))

src/Xamarin.Android.Build.Tasks/Utilities/FileResourceParser.cs

@@ -65,7 +65,7 @@ public IList<R> Parse (string resourceDirectory, IEnumerable<string> additionalR
 					ProcessResourceFile (file, resources);
 				}
 			}
-			foreach (var dir in additionalResourceDirectories ?? Array.Empty<string>()) {
+			foreach (var dir in additionalResourceDirectories ?? []) {
 				Log.LogDebugMessage ($"Processing Directory {dir}");
 				if (Directory.Exists (dir)) {
 					foreach (var file in Directory.EnumerateFiles (dir, "*.*", SearchOption.AllDirectories)) {
@@ -75,7 +75,7 @@ public IList<R> Parse (string resourceDirectory, IEnumerable<string> additionalR
 					Log.LogDebugMessage ($"Skipping non-existent directory: {dir}");
 				}
 			}
-			foreach (var aar in aarLibraries ??  Array.Empty<string>()) {
+			foreach (var aar in aarLibraries ?? []) {
 				Log.LogDebugMessage ($"Processing Aar file {aar}");
 				if (!File.Exists (aar)) {
 					Log.LogDebugMessage ($"Skipping non-existent aar: {aar}");

src/Xamarin.Android.Build.Tasks/Utilities/JCWGenerator.cs

@@ -127,7 +127,7 @@ public bool GenerateCode (CallableWrapperType generator, TypeDefinition type, st
 				endLineNumber: 0,
 				endColumnNumber: 0,
 				message: xae.MessageWithoutCode,
-				messageArgs: Array.Empty<object> ()
+				messageArgs: []
 			);
 		} catch (DirectoryNotFoundException ex) {
 			ok = false;

src/Xamarin.Android.Build.Tasks/Utilities/ManifestDocument.cs

@@ -1092,7 +1092,7 @@ public void SetAbi (string abi)
 		public bool ValidateVersionCode (out string error, out string errorCode)
 		{
 			int code;
-			error = errorCode = string.Empty;
+			error = errorCode = "";
 			if (!int.TryParse (VersionCode, out code)) {
 				error = string.Format (Properties.Resources.XA0003, VersionCode);
 				errorCode = "XA0003";
@@ -1110,7 +1110,7 @@ public void CalculateVersionCode (string currentAbi, string versionCodePattern,
 		{
 			var regex = new Regex ("\\{(?<key>([A-Za-z]+)):?[D0-9]*[\\}]");
 			var kvp = new Dictionary<string, int> ();
-			foreach (var item in versionCodeProperties?.Split (new char [] { ';', ':' }) ?? Array.Empty<string> ()) {
+			foreach (var item in versionCodeProperties?.Split (new char [] { ';', ':' }) ?? []) {
 				var keyValue = item.Split (new char [] { '=' });
 				int val;
 				if (!int.TryParse (keyValue [1], out val))

src/Xamarin.Android.Build.Tasks/Utilities/MavenExtensions.cs

@@ -27,7 +27,7 @@ static class MavenExtensions
 	// Helps to 'foreach' into a possibly null array
 	public static T [] OrEmpty<T> (this T []? value)
 	{
-		return value ?? Array.Empty<T> ();
+		return value ?? [];
 	}
 
 	// Removes AggregateException wrapping around an exception

src/Xamarin.Android.Build.Tasks/Utilities/MonoAndroidHelper.cs

@@ -238,7 +238,7 @@ internal static bool LogInternalExceptions {
 #if MSBUILD
 		public static IEnumerable<string> ExpandFiles (ITaskItem[] libraryProjectJars)
 		{
-			libraryProjectJars  = libraryProjectJars ?? Array.Empty<ITaskItem> ();
+			libraryProjectJars  = libraryProjectJars ?? [];
 			return (from path in libraryProjectJars
 					let     dir     = Path.GetDirectoryName (path.ItemSpec)
 					let     pattern = Path.GetFileName (path.ItemSpec)

src/Xamarin.Android.Build.Tasks/Utilities/TypeMapGenerator.cs

@@ -184,7 +184,7 @@ void GenerateRelease (string outputDirectory)
 
 			foreach (ModuleReleaseData module in modules) {
 				if (module.TypesScratch.Count == 0) {
-					module.Types = Array.Empty<TypeMapReleaseEntry> ();
+					module.Types = [];
 					continue;
 				}