Skip to content

Commit f090c31

Browse files
committed
Address feedback
1 parent 1869215 commit f090c31

File tree

1 file changed

+20
-36
lines changed

1 file changed

+20
-36
lines changed

src/Xamarin.Android.Build.Tasks/Utilities/LlvmIrGenerator/StringHolder.cs

+20-36
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,7 @@ public static StringHolder AsHolder (object? value, LlvmIrStringEncoding encodin
3434
return holder;
3535
}
3636

37-
public int CompareTo (object obj)
38-
{
39-
var holder = obj as StringHolder;
40-
if (holder == null) {
41-
return 1;
42-
}
43-
44-
return CompareTo (holder);
45-
}
37+
public int CompareTo (object obj) => CompareTo (obj as StringHolder);
4638

4739
public int CompareTo (StringHolder? other)
4840
{
@@ -83,15 +75,7 @@ public override int GetHashCode ()
8375
return hc ^ Encoding.GetHashCode ();
8476
}
8577

86-
public override bool Equals (object obj)
87-
{
88-
var holder = obj as StringHolder;
89-
if (holder == null) {
90-
return false;
91-
}
92-
93-
return Equals (holder);
94-
}
78+
public override bool Equals (object obj) => Equals (obj as StringHolder);
9579

9680
public bool Equals (StringHolder? other)
9781
{
@@ -103,22 +87,22 @@ public bool Equals (StringHolder? other)
10387
}
10488

10589
public static bool operator > (StringHolder a, StringHolder b)
106-
{
107-
return a.CompareTo (b) > 0;
108-
}
109-
110-
public static bool operator < (StringHolder a, StringHolder b)
111-
{
112-
return a.CompareTo (b) < 0;
113-
}
114-
115-
public static bool operator >= (StringHolder a, StringHolder b)
116-
{
117-
return a.CompareTo (b) >= 0;
118-
}
119-
120-
public static bool operator <= (StringHolder a, StringHolder b)
121-
{
122-
return a.CompareTo (b) <= 0;
123-
}
90+
{
91+
return a.CompareTo (b) > 0;
92+
}
93+
94+
public static bool operator < (StringHolder a, StringHolder b)
95+
{
96+
return a.CompareTo (b) < 0;
97+
}
98+
99+
public static bool operator >= (StringHolder a, StringHolder b)
100+
{
101+
return a.CompareTo (b) >= 0;
102+
}
103+
104+
public static bool operator <= (StringHolder a, StringHolder b)
105+
{
106+
return a.CompareTo (b) <= 0;
107+
}
124108
}

0 commit comments

Comments
 (0)