Skip to content

Commit 24d6188

Browse files
authored
A few accessibility fixes (#9017)
* Add aria-label to buttons without it * Horizontally-align property grid headers with content * Change generated colors to fluent versions * Revert color changes * Add aria labels to tooltips
1 parent 4e112fd commit 24d6188

21 files changed

+371
-661
lines changed

src/Aspire.Dashboard/Components/Controls/GridValue.razor

+2-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,8 @@
4747
<span class="defaultHidden">
4848
<FluentButton Appearance="Appearance.Lightweight"
4949
Disabled="@(ValueToVisualize is null && Value is null)"
50-
OnClick="OpenTextVisualizerAsync">
50+
OnClick="OpenTextVisualizerAsync"
51+
aria-label="@DialogsLoc[nameof(Dialogs.OpenInTextVisualizer)]">
5152
<FluentIcon Icon="Icons.Regular.Size16.SlideSearch" />
5253
</FluentButton>
5354
</span>

src/Aspire.Dashboard/Components/Pages/Login.razor

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
<div class="token-entry-footer">
3333
<a href="@NavigationManager.Uri" id="helpLink">@Loc[nameof(Dashboard.Resources.Login.WhereIsMyTokenLinkText)]</a>
3434
<FluentButton Appearance="Appearance.Accent" Name="submit-token" Type="ButtonType.Submit">@Loc[nameof(Dashboard.Resources.Login.LogInButtonText)]</FluentButton>
35-
<FluentTooltip Anchor="helpLink" MaxWidth="650px">
35+
<FluentTooltip Anchor="helpLink" MaxWidth="650px" aria-label="https://go.microsoft.com/fwlink/?linkid=2265718">
3636
<div class="token-help-container">
3737
<div>
3838
<a href="/img/TokenExample.png" target="_blank">

src/Aspire.Dashboard/Components/Pages/Resources.razor

+1-1
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@
145145
<span @onclick:stopPropagation="true" class="main-grid-expand-container @(context.IsCollapsed ? "main-grid-collapsed" : "main-grid-expanded")">
146146
@if (context.Children.Count > 0)
147147
{
148-
<FluentButton Appearance="Appearance.Lightweight" Class="main-grid-expand-button" OnClick="@(() => OnToggleCollapse(context))">
148+
<FluentButton aria-label="@ControlsStringsLoc[nameof(ControlsStrings.ToggleNesting)]" Appearance="Appearance.Lightweight" Class="main-grid-expand-button" OnClick="@(() => OnToggleCollapse(context))">
149149
<FluentIcon Icon="Icons.Regular.Size12.ChevronRight" Color="Color.Neutral" />
150150
</FluentButton>
151151
}

src/Aspire.Dashboard/Components/Pages/TraceDetail.razor

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@
120120
<span @onclick:stopPropagation="true" class="main-grid-expand-container @(context.IsCollapsed ? "main-grid-collapsed" : "main-grid-expanded")">
121121
@if (context.Children.Count > 0)
122122
{
123-
<FluentButton Appearance="Appearance.Lightweight" Class="main-grid-expand-button" OnClick="@(() => OnToggleCollapse(context))">
123+
<FluentButton aria-label="@ControlStringsLoc[nameof(ControlsStrings.ToggleNesting)]" Appearance="Appearance.Lightweight" Class="main-grid-expand-button" OnClick="@(() => OnToggleCollapse(context))">
124124
<FluentIcon Icon="Icons.Regular.Size12.ChevronRight" Color="Color.Neutral" />
125125
</FluentButton>
126126
}

src/Aspire.Dashboard/Components/Pages/Traces.razor

+12-8
Original file line numberDiff line numberDiff line change
@@ -126,14 +126,18 @@
126126
@{
127127
var items = overflow.ItemsOverflow.ToList();
128128
}
129-
<FluentTooltip UseTooltipService="false" Anchor="@overflow.IdMoreButton">
130-
@foreach (var item in items)
131-
{
132-
<div style="margin-top: 8px; margin-bottom: 8px;">
133-
@item.ChildContent
134-
</div>
135-
}
136-
</FluentTooltip>
129+
130+
@if (items.Count > 0)
131+
{
132+
<FluentTooltip aria-label="@(string.Join(", ", items.Select(i => i.Text)))" UseTooltipService="false" Anchor="@overflow.IdMoreButton">
133+
@foreach (var item in items)
134+
{
135+
<div style="margin-top: 8px; margin-bottom: 8px;">
136+
@item.ChildContent
137+
</div>
138+
}
139+
</FluentTooltip>
140+
}
137141
</OverflowTemplate>
138142
</FluentOverflow>
139143
</AspireTemplateColumn>

0 commit comments

Comments
 (0)