Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devcontainer support doesn't work for vscode insiders #7110

Open
aaronpowell opened this issue Jan 14, 2025 · 3 comments · May be fixed by #7111
Open

Devcontainer support doesn't work for vscode insiders #7110

aaronpowell opened this issue Jan 14, 2025 · 3 comments · May be fixed by #7111
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Milestone
9.1

Comments

@aaronpowell
Copy link
Contributor

aaronpowell commented Jan 14, 2025 •
edited
Loading

The devcontainer work to ensure the settings file exists expects a specific path for the settings.json, but that path is for VS Code, not VS Code Insiders: https://github.com/dotnet/aspire/blob/main/src/Aspire.Hosting/Devcontainers/DevcontainerSettingsWriter.cs#L14-L15

For VS Code Insiders it should look at this path /home/vscode/.vscode-server-insiders/data/Machine/settings.json

Versions of things:

  • Aspire 9.1.0-preview.1.25064.6
  • VS Code
Version: 1.97.0-insider (system setup)
Commit: 69d97b0773575a75736850370918e1171cfde5c6
Date: 2025-01-13T09:58:56.423Z
Electron: 32.2.7
ElectronBuildId: 10660205
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.26120
  • Remote Containers extension 0.395.0

Workaround

A current workaround is to symlink the VS Code insiders path to the VS Code one and it seems to work
@aaronpowell
Copy link
Contributor Author

tagging @mitchdenny

@davidfowl
Copy link
Member

He's out, can you send a PR?

@davidfowl davidfowl added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Jan 14, 2025
@davidfowl davidfowl added this to the 9.1 milestone Jan 14, 2025
aaronpowell added a commit to aaronpowell/aspire that referenced this issue Jan 14, 2025
@aaronpowell
Handling vscode insiders devcontainers
ed58347 
Fixes dotnet#7110
@aaronpowell aaronpowell linked a pull request Jan 14, 2025 that will close this issue
Open
@aaronpowell
Copy link
Contributor Author

He's out, can you send a PR?

Was in the middle of that 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Milestone
9.1
Development

Successfully merging a pull request may close this issue.

Handling vscode insiders devcontainers aaronpowell/aspire
2 participants
@davidfowl @aaronpowell